From: Shuah Khan <shuah.kh@samsung.com>
To: gregkh@linuxfoundation.org, akpm@linux-foundation.org,
davidlohr@hp.com, colin.king@canonical.com
Cc: Shuah Khan <shuah.kh@samsung.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] tools: msgque improve error handling when not running as root
Date: Wed, 25 Jun 2014 13:40:10 -0600 [thread overview]
Message-ID: <1403725210-10245-1-git-send-email-shuah.kh@samsung.com> (raw)
The test fails in the middle when it is not run as root while
accessing /proc/sys/kernel/msg_next_id. Changed it to check
for root at the beginning of the test. Also added messages
to indicate start and test pass status.
Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
---
tools/testing/selftests/ipc/msgque.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tools/testing/selftests/ipc/msgque.c b/tools/testing/selftests/ipc/msgque.c
index aa290c0..30c627a 100644
--- a/tools/testing/selftests/ipc/msgque.c
+++ b/tools/testing/selftests/ipc/msgque.c
@@ -193,6 +193,12 @@ int main(int argc, char **argv)
int msg, pid, err;
struct msgque_data msgque;
+ if (getuid() != 0) {
+ fprintf(stderr, "Please run the test as root - Exiting.\n");
+ exit(1);
+ }
+
+ printf("Starting ipc tests:\n");
msgque.key = ftok(argv[0], 822155650);
if (msgque.key == -1) {
printf("Can't make key\n");
@@ -235,6 +241,7 @@ int main(int argc, char **argv)
printf("Failed to test queue\n");
goto err_out;
}
+ printf("All ipc tests Passsed\n");
return 0;
err_destroy:
--
1.9.1
next reply other threads:[~2014-06-25 19:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 19:40 Shuah Khan [this message]
2014-06-25 20:05 ` [PATCH] tools: msgque improve error handling when not running as root Davidlohr Bueso
2014-06-25 20:15 ` Shuah Khan
2014-06-25 20:22 ` Davidlohr Bueso
2014-06-25 20:32 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403725210-10245-1-git-send-email-shuah.kh@samsung.com \
--to=shuah.kh@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=colin.king@canonical.com \
--cc=davidlohr@hp.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).