From: Myungho Jung <mhjungk@gmail.com>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] timer: fix timer_migration to accept only 0 and 1
Date: Wed, 19 Apr 2017 15:24:50 -0700 [thread overview]
Message-ID: <1492640690-3550-1-git-send-email-mhjungk@gmail.com> (raw)
Error is not shown by setting invalid value to timer_migration. Valid
values for timer_migration should be restricted to 0 and 1. Testcase for
this bug is ltp/runpwtests06.
Signed-off-by: Myungho Jung <mhjungk@gmail.com>
---
kernel/sysctl.c | 2 ++
kernel/time/timer.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 8c8714f..21343d1 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -1176,6 +1176,8 @@ static struct ctl_table kern_table[] = {
.maxlen = sizeof(unsigned int),
.mode = 0644,
.proc_handler = timer_migration_handler,
+ .extra1 = &zero,
+ .extra2 = &one,
},
#endif
#ifdef CONFIG_BPF_SYSCALL
diff --git a/kernel/time/timer.c b/kernel/time/timer.c
index 1dc0256..cc6b6bd 100644
--- a/kernel/time/timer.c
+++ b/kernel/time/timer.c
@@ -241,7 +241,7 @@ int timer_migration_handler(struct ctl_table *table, int write,
int ret;
mutex_lock(&mutex);
- ret = proc_dointvec(table, write, buffer, lenp, ppos);
+ ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos);
if (!ret && write)
timers_update_migration(false);
mutex_unlock(&mutex);
--
2.7.4
next reply other threads:[~2017-04-19 22:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 22:24 Myungho Jung [this message]
2017-04-20 12:53 ` [PATCH] timer: fix timer_migration to accept only 0 and 1 Thomas Gleixner
2017-04-20 17:36 ` Myungho Jung
2017-04-20 17:45 ` Thomas Gleixner
2017-04-20 18:08 ` Myungho Jung
2017-04-20 13:14 ` [tip:timers/core] timer/sysclt: Restrict timer migration sysctl values to " tip-bot for Myungho Jung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492640690-3550-1-git-send-email-mhjungk@gmail.com \
--to=mhjungk@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).