From: Alexey Khoroshilov <khoroshilov@ispras.ru>
To: Denis Osterland <Denis.Osterland@diehl.com>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org
Subject: [PATCH] rtc: isl1208: fix error handling in isl1208_probe()
Date: Thu, 9 Aug 2018 01:13:07 +0300 [thread overview]
Message-ID: <1533766387-30529-1-git-send-email-khoroshilov@ispras.ru> (raw)
After moving rtc_register_device() sysfs group is left unremoved
on the error path.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Fixes: 236b7187034e ("rtc: isl1208: switch to rtc_register_device")
---
drivers/rtc/rtc-isl1208.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c
index 1a2c38cc0178..4b5df9bfb8d4 100644
--- a/drivers/rtc/rtc-isl1208.c
+++ b/drivers/rtc/rtc-isl1208.c
@@ -674,7 +674,12 @@ isl1208_probe(struct i2c_client *client, const struct i2c_device_id *id)
}
}
- return rtc_register_device(rtc);
+ rc = rtc_register_device(rtc);
+ if (rc) {
+ sysfs_remove_group(&client->dev.kobj, &isl1208_rtc_sysfs_files);
+ return rc;
+ }
+ return 0;
}
static int
--
2.7.4
next reply other threads:[~2018-08-08 22:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 22:13 Alexey Khoroshilov [this message]
2018-09-15 11:49 ` [PATCH] rtc: isl1208: fix error handling in isl1208_probe() Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533766387-30529-1-git-send-email-khoroshilov@ispras.ru \
--to=khoroshilov@ispras.ru \
--cc=Denis.Osterland@diehl.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).