From: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>
To: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <bhelgaas@google.com>, <rgummal@xilinx.com>,
Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>
Subject: [PATCH 3/4] PCI/portdrv: Check platform supported service IRQ's
Date: Fri, 10 Aug 2018 21:09:39 +0530 [thread overview]
Message-ID: <1533915580-31805-4-git-send-email-bharat.kumar.gogada@xilinx.com> (raw)
In-Reply-To: <1533915580-31805-1-git-send-email-bharat.kumar.gogada@xilinx.com>
Platforms may have dedicated IRQ lines for PCIe services like
AER/PME etc., check for such IRQ lines.
Check mask and fill legacy irq line for services other than
platform supported service IRQ number.
Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>
---
drivers/pci/pcie/portdrv_core.c | 19 +++++++++++++++++--
1 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c
index e0261ad..a7d024c 100644
--- a/drivers/pci/pcie/portdrv_core.c
+++ b/drivers/pci/pcie/portdrv_core.c
@@ -166,6 +166,19 @@ static int pcie_init_service_irqs(struct pci_dev *dev, int *irqs, int mask)
irqs[i] = -1;
/*
+ * Some platforms have dedicated interrupt line from root complex to
+ * interrupt controller for PCIe services like AER/PME etc., check
+ * if platform registered with any such IRQ.
+ */
+ if (pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT) {
+ int plat_mask;
+
+ plat_mask = pci_check_platform_service_irqs(dev, irqs, mask);
+ if (plat_mask > 0)
+ mask = mask & plat_mask;
+ }
+
+ /*
* If we support PME but can't use MSI/MSI-X for it, we have to
* fall back to INTx or other interrupts, e.g., a system shared
* interrupt.
@@ -183,8 +196,10 @@ static int pcie_init_service_irqs(struct pci_dev *dev, int *irqs, int mask)
if (ret < 0)
return -ENODEV;
- for (i = 0; i < PCIE_PORT_DEVICE_MAXSERVICES; i++)
- irqs[i] = pci_irq_vector(dev, 0);
+ for (i = 0; i < PCIE_PORT_DEVICE_MAXSERVICES; i++) {
+ if (mask & (1 << i))
+ irqs[i] = pci_irq_vector(dev, 0);
+ }
return 0;
}
--
1.7.1
next prev parent reply other threads:[~2018-08-10 15:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 15:39 [PATCH 0/4] Add support to register platform service IRQ Bharat Kumar Gogada
2018-08-10 15:39 ` [PATCH 1/4] PCI: Add setup_platform_service_irq hook to struct pci_host_bridge Bharat Kumar Gogada
2018-08-10 15:39 ` [PATCH 2/4] PCI: Add pci_check_platform_service_irqs Bharat Kumar Gogada
2018-08-10 15:39 ` Bharat Kumar Gogada [this message]
2018-09-04 14:12 ` [PATCH 3/4] PCI/portdrv: Check platform supported service IRQ's Bjorn Helgaas
2018-09-06 15:34 ` Bharat Kumar Gogada
2018-08-10 15:39 ` [PATCH 4/4] PCI: xilinx-nwl: Add method to setup_platform_service_irq hook Bharat Kumar Gogada
2018-08-13 9:09 ` kbuild test robot
2018-08-14 15:55 ` Bharat Kumar Gogada
2018-08-13 9:09 ` [RFC PATCH] PCI: xilinx-nwl: nwl_setup_service_irqs() can be static kbuild test robot
2018-09-04 13:48 ` [PATCH 4/4] PCI: xilinx-nwl: Add method to setup_platform_service_irq hook Bjorn Helgaas
2018-09-06 15:27 ` Bharat Kumar Gogada
2018-08-24 12:16 ` [PATCH 0/4] Add support to register platform service IRQ Bharat Kumar Gogada
2018-08-24 16:12 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533915580-31805-4-git-send-email-bharat.kumar.gogada@xilinx.com \
--to=bharat.kumar.gogada@xilinx.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rgummal@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).