From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Luca Weiss <luca@z3ntu.xyz>, Sakari Ailus <sakari.ailus@iki.fi>
Cc: Rob Herring <robh@kernel.org>,
linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
~postmarketos/upstreaming@lists.sr.ht,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-media@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Shunqian Zheng <zhengsq@rock-chips.com>,
phone-devel@vger.kernel.org,
Helen Koike <helen.koike@collabora.com>
Subject: Re: [PATCH] media: dt-bindings: ov2685: convert to dtschema
Date: Tue, 14 Mar 2023 19:36:03 +0100 [thread overview]
Message-ID: <0d13bcfe-6234-4102-c32f-5d175c0df10c@linaro.org> (raw)
In-Reply-To: <5654018.DvuYhMxLoT@z3ntu.xyz>
On 14/03/2023 19:33, Luca Weiss wrote:
>>>> ia/i2c/ovti,ov2685.yaml
>>>
>>> Looks like rockchip-isp1.yaml uses very incomplete sensor examples in
>>> their
>>> binding example, which sort of makes sense since those bindings are
>>> showing
>>> the rockchip isp bindings and contain the bare minimum to show how a
>>> sensor is connected in dt.
>>>
>>> Not sure how to solve this - ov2685 is also one of three sensors that are
>>> used very abbreviated there.
>>
>> Could these regulators be simply made optional?
>
> Sure, from driver side it would just get dummy regulators instead.
>
> Still the clocks are also missing in this rockchip example. Any suggestion
> what to do about those?
>
> Honestly I don't want to spend too much time on some ISP docs that I don't
> really care about, would be nice if the maintainers of that could do that...
In perfect world, the bindings describe the hardware and if hardware
requires supply or clock to operate, then it should be required in the
binding. If some other DTS do not validate - their problem...
In practice, we make tradeoffs. But is it the case here? The binding was
always requiring supplies and clocks, so there is no reason to make
supplies optional. Unless you know the device and they are really optional.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-14 18:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 20:23 [PATCH] media: dt-bindings: ov2685: convert to dtschema Luca Weiss
2023-02-06 21:50 ` Rob Herring
2023-02-09 16:46 ` Luca Weiss
2023-03-14 12:00 ` Sakari Ailus
2023-03-14 18:33 ` Luca Weiss
2023-03-14 18:36 ` Krzysztof Kozlowski [this message]
2023-03-14 19:53 ` Sakari Ailus
2023-03-14 18:37 ` Krzysztof Kozlowski
2023-03-14 18:37 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d13bcfe-6234-4102-c32f-5d175c0df10c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=helen.koike@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=zhengsq@rock-chips.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).