From: Kiran Gunda <kgunda@codeaurora.org>
To: bjorn.andersson@linaro.org, jingoohan1@gmail.com,
lee.jones@linaro.org, b.zolnierkie@samsung.com,
dri-devel@lists.freedesktop.org, daniel.thompson@linaro.org,
jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org,
mark.rutland@arm.com, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org,
Kiran Gunda <kgunda@codeaurora.org>
Subject: [PATCH V3 0/2] Fix WLED FSC Sync and brightness Sync settings
Date: Mon, 1 Mar 2021 14:58:34 +0530 [thread overview]
Message-ID: <1614590916-27070-1-git-send-email-kgunda@codeaurora.org> (raw)
This patch series has the following two WLED fixes
1. As per the current implementation, for WLED5, after
the FSC (Full Scale Current) update the driver is incorrectly
toggling the MOD_SYNC register instead of toggling the SYNC register.
The patch 1/2 fixes this by toggling the SYNC register after
FSC update.
2. Currently, the sync bits are transitioned from set-then-clear
after FSC and brightness update. As per hardware team recommendation
the FSC and brightness sync takes place from clear-then-set transition
of the sync bits. The patch 2/2 fies this issue.
Changes from V2:
1. Added Daniel's "Reviewed-by" tag for patch 1/2.
2. Updated the patch 2/2 description with "set" and "clear"
terminology instead of "1" and "0".
3. Updated the cover letter with "set" and "clear" terminology
instead of "1" and "0".
Changes from V1:
1. Updated the cover letter.
2. Updated the description of the patches as per Daniel's suggestion.
Kiran Gunda (2):
backlight: qcom-wled: Fix FSC update issue for WLED5
backlight: qcom-wled: Correct the sync_toggle sequence
drivers/video/backlight/qcom-wled.c | 37 +++++++++++++++++++++++++------------
1 file changed, 25 insertions(+), 12 deletions(-)
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next reply other threads:[~2021-03-01 9:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 9:28 Kiran Gunda [this message]
2021-03-01 9:28 ` [PATCH V3 1/2] backlight: qcom-wled: Fix FSC update issue for WLED5 Kiran Gunda
2021-03-01 9:28 ` [PATCH V3 2/2] backlight: qcom-wled: Correct the sync_toggle sequence Kiran Gunda
2021-03-01 10:02 ` Daniel Thompson
2021-03-01 16:42 ` kgunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1614590916-27070-1-git-send-email-kgunda@codeaurora.org \
--to=kgunda@codeaurora.org \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).