From: Viresh Kumar <viresh.kumar@linaro.org>
To: Taniya Das <tdas@codeaurora.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
agross@kernel.org, rjw@rjwysocki.net, devicetree@vger.kernel.org,
robh+dt@kernel.org, amit.kucheria@linaro.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
phone-devel@vger.kernel.org, konrad.dybcio@somainline.org,
marijn.suijten@somainline.org, martin.botka@somainline.org,
jeffrey.l.hugo@gmail.com
Subject: Re: [PATCH v4 5/7] cpufreq: qcom-hw: Implement CPRh aware OSM programming
Date: Tue, 13 Apr 2021 09:19:40 +0530 [thread overview]
Message-ID: <20210413034940.o6uzjtnh2ylvikbf@vireshk-i7> (raw)
In-Reply-To: <92e465e4-a0d9-43eb-84f7-69fa355097a9@codeaurora.org>
On 12-04-21, 15:01, Taniya Das wrote:
> Technically the HW we are trying to program here differs in terms of
> clocking, the LUT definitions and many more. It will definitely make
> debugging much more troublesome if we try to accomodate multiple versions of
> CPUFREQ-HW in the same code.
>
> Thus to keep it simple, easy to read, debug, the suggestion is to keep it
> with "v1" tag as the OSM version we are trying to put here is from OSM1.0.
That is a valid point and is always a case with so many drivers. What
I am concerned about is how much code is common across versions, if it
is 5-70%, or more, then we should definitely share, arrange to have
callbacks or ops per version and call them in a generic fashion instead
of writing a new driver. This is what's done across
drivers/frameworks, etc.
--
viresh
next prev parent reply other threads:[~2021-04-13 3:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 17:45 [PATCH v4 0/7] cpufreq-qcom-hw: Implement full OSM programming AngeloGioacchino Del Regno
2021-01-19 17:45 ` [PATCH v4 1/7] cpufreq: blacklist SDM630/636/660 in cpufreq-dt-platdev AngeloGioacchino Del Regno
2021-04-19 19:18 ` Bjorn Andersson
2021-01-19 17:45 ` [PATCH v4 2/7] cpufreq: blacklist MSM8998 " AngeloGioacchino Del Regno
2021-04-19 19:18 ` Bjorn Andersson
2021-01-19 17:45 ` [PATCH v4 3/7] dt-bindings: arm: cpus: Document 'qcom,freq-domain' property AngeloGioacchino Del Regno
2021-01-19 17:45 ` [PATCH v4 4/7] dt-bindings: cpufreq: cpufreq-qcom-hw: Convert to YAML bindings AngeloGioacchino Del Regno
2021-04-19 19:17 ` Bjorn Andersson
2021-01-19 17:45 ` [PATCH v4 5/7] cpufreq: qcom-hw: Implement CPRh aware OSM programming AngeloGioacchino Del Regno
2021-01-20 18:25 ` Taniya Das
2021-01-20 18:54 ` AngeloGioacchino Del Regno
2021-01-20 19:05 ` Bjorn Andersson
2021-02-10 5:13 ` Viresh Kumar
2021-04-12 9:31 ` Taniya Das
2021-04-13 3:49 ` Viresh Kumar [this message]
2021-04-15 1:31 ` Taniya Das
2021-04-19 19:06 ` Bjorn Andersson
2021-04-19 18:52 ` Bjorn Andersson
2021-04-19 20:59 ` AngeloGioacchino Del Regno
2021-04-19 23:22 ` Bjorn Andersson
2021-04-20 3:37 ` Viresh Kumar
2021-01-19 17:45 ` [PATCH v4 6/7] cpufreq: qcom-hw: Allow getting the maximum transition latency for OPPs AngeloGioacchino Del Regno
2021-04-19 19:19 ` Bjorn Andersson
2021-01-19 17:45 ` [PATCH v4 7/7] dt-bindings: cpufreq: qcom-hw: Add bindings for 8998 AngeloGioacchino Del Regno
2021-04-12 5:11 ` [PATCH v4 0/7] cpufreq-qcom-hw: Implement full OSM programming Viresh Kumar
2021-04-13 2:41 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413034940.o6uzjtnh2ylvikbf@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).