From: Marijn Suijten <marijn.suijten@somainline.org>
To: phone-devel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Martin Botka <martin.botka@somainline.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
Pavel Dubrova <pashadubrova@gmail.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Clark <robdclark@gmail.com>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Abhinav Kumar <abhinavk@codeaurora.org>,
Jonathan Marek <jonathan@marek.ca>,
Matthias Kaehlcke <mka@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org
Subject: [PATCH v2 0/2] Use "ref" clocks from firmware for DSI PLL VCO parent
Date: Mon, 30 Aug 2021 20:24:43 +0200 [thread overview]
Message-ID: <20210830182445.167527-1-marijn.suijten@somainline.org> (raw)
All DSI PHY/PLL drivers were referencing their VCO parent clock by a
global name, most of which don't exist or have been renamed. These
clock drivers seem to function fine without that except the 14nm driver
for the sdm6xx [1].
At the same time all DTs provide a "ref" clock as per the requirements
of dsi-phy-common.yaml, but the clock is never used. This patchset puts
that clock to use without relying on a global clock name, so that all
dependencies are explicitly defined in DT (the firmware) in the end.
[1]: https://lore.kernel.org/linux-arm-msm/386db1a6-a1cd-3c7d-a88e-dc83f8a1be96@somainline.org/
Changes since v1:
- Dropped "arm: dts: qcom: apq8064: Use 27MHz PXO clock as DSI PLL
reference" which has made its way into 5.15-fixes in advance of this
patchset landing in 5.16.
- Added Fixes: tags for commits that added missing "ref" clocks to DT
while this firmware clock was never used (until this patchset).
- Documented missing/wrong and later-added clocks (by aforementioned
patches) in patch 1/2 more clearly.
Dmitry:
I have not added the .name="xo" fallback to the 28nm-hpm driver for
the missing "ref" clock in msm8974 yet. This patch is supposed to
make it in for 5.16 while the missing clock should be added in 5.15,
is that enough time?
If not I'll gladly respin a v3 with that fallback, but I hope everyone
can update their DT firmware before that time. Likewise Bjorn
acknowledged that there is enough time for the same to happen on
apq8064.
Marijn Suijten (2):
drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent
clk: qcom: gcc-sdm660: Remove transient global "xo" clock
drivers/clk/qcom/gcc-sdm660.c | 14 --------------
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 4 +++-
drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 4 +++-
drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 4 +++-
drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c | 4 +++-
drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 4 +++-
6 files changed, 15 insertions(+), 19 deletions(-)
--
2.33.0
next reply other threads:[~2021-08-30 18:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 18:24 Marijn Suijten [this message]
2021-08-30 18:24 ` [PATCH v2 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent Marijn Suijten
2021-08-30 22:16 ` Stephen Boyd
2021-08-30 22:45 ` Marijn Suijten
2021-08-30 22:53 ` Stephen Boyd
2021-08-30 23:10 ` Marijn Suijten
2021-09-01 5:35 ` Stephen Boyd
2021-09-01 8:49 ` Marijn Suijten
2021-09-02 3:46 ` Stephen Boyd
2021-09-02 7:27 ` AngeloGioacchino Del Regno
2021-08-30 18:24 ` [PATCH v2 2/2] clk: qcom: gcc-sdm660: Remove transient global "xo" clock Marijn Suijten
2021-09-01 5:35 ` Stephen Boyd
2021-09-01 8:57 ` Marijn Suijten
2021-09-02 3:46 ` Stephen Boyd
2021-09-02 13:05 ` Marijn Suijten
2021-09-02 19:34 ` Stephen Boyd
2021-09-02 7:28 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830182445.167527-1-marijn.suijten@somainline.org \
--to=marijn.suijten@somainline.org \
--cc=abhinavk@codeaurora.org \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jami.kettunen@somainline.org \
--cc=jonathan@marek.ca \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.botka@somainline.org \
--cc=mka@chromium.org \
--cc=mturquette@baylibre.com \
--cc=pashadubrova@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).