From: Andi Shyti <andi@etezian.org>
To: Caleb Connolly <caleb@connolly.tech>
Cc: Andi Shyti <andi@etezian.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: s6sy761: fix coordinate read bit shift
Date: Fri, 5 Mar 2021 13:55:48 +0200 [thread overview]
Message-ID: <YEIcRBjVSrAIaB+c@jack.zhora.eu> (raw)
In-Reply-To: <20210305020310.550527-1-caleb@connolly.tech>
Hi Caleb,
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
Please clean up the commit message.
> The touch coordinates are read by shifting a value left by 3,
> this is incorrect and effectively causes the coordinates to
> be half of the correct value.
>
> Shift by 4 bits instead to report the correct value.
>
> This matches downstream examples, and has been confirmed on my
> device (OnePlus 7 Pro).
The real reason is that from the register we get:
byte 3 byte 2 byte 1
+--------+--------+ +-----------------+ +-----------------+
| | | | | | |
| X[3:0] | Y[3:0] | | Y[11:4] | | X[11:4] |
| | | | | | |
+--------+--------+ +-----------------+ +-----------------+
and the 12 bit values have to fit in a 16bit variable.
The upper 8 bits (in event[2] and event[1] need to be shifted
left by '4' and not by '3' in order to leave space to the lower
4 bits (in event[3]).
>
> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
> ---
> drivers/input/touchscreen/s6sy761.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/s6sy761.c b/drivers/input/touchscreen/s6sy761.c
> index b63d7fdf0cd2..85a1f465c097 100644
> --- a/drivers/input/touchscreen/s6sy761.c
> +++ b/drivers/input/touchscreen/s6sy761.c
> @@ -145,8 +145,8 @@ static void s6sy761_report_coordinates(struct s6sy761_data *sdata,
> u8 major = event[4];
> u8 minor = event[5];
> u8 z = event[6] & S6SY761_MASK_Z;
> - u16 x = (event[1] << 3) | ((event[3] & S6SY761_MASK_X) >> 4);
> - u16 y = (event[2] << 3) | (event[3] & S6SY761_MASK_Y);
> + u16 x = (event[1] << 4) | ((event[3] & S6SY761_MASK_X) >> 4);
> + u16 y = (event[2] << 4) | (event[3] & S6SY761_MASK_Y);
the devil knows how that '3' has ended up there :)
Thanks for catching it!
Reviewed-by: Andi Shyti <andi@etezian.org>
Andi
next prev parent reply other threads:[~2021-03-05 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 2:03 [PATCH] input: s6sy761: fix coordinate read bit shift Caleb Connolly
2021-03-05 11:55 ` Andi Shyti [this message]
2021-03-05 17:54 ` Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEIcRBjVSrAIaB+c@jack.zhora.eu \
--to=andi@etezian.org \
--cc=caleb@connolly.tech \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).