From: Luke Jones <luke@ljones.dev>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
"Barnabás Pőcze" <pobrn@protonmail.com>,
"Pavel Machek" <pavel@ucw.cz>,
"Platform Driver" <platform-driver-x86@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/6] asus-wmi: Implement TUF laptop keyboard power states
Date: Tue, 09 Aug 2022 20:58:12 +1200 [thread overview]
Message-ID: <0LBCGR.NDLPJAR4JTJQ@ljones.dev> (raw)
In-Reply-To: <CAHp75VenHd6JREvxjmcNbeshvgv-S_th9pqBBgQJ+FBgPzgWqA@mail.gmail.com>
Hi Andy,
On Tue, Aug 9 2022 at 10:52:21 +0200, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Tue, Aug 9, 2022 at 4:51 AM Luke D. Jones <luke@ljones.dev> wrote:
>>
>> Adds support for setting various power states of TUF keyboards.
>> These states are combinations of:
>> - boot, set if a boot animation is shown on keyboard
>> - awake, set if the keyboard LEDs are visible while laptop is on
>> - sleep, set if an animation is displayed while the laptop is
>> suspended
>> - keyboard (unknown effect)
>>
>> Adds two sysfs attributes to asus-nb-wmi:
>> - keyboard_rgb_state
>> - keyboard_rgb_state_index
>
> ...
>
>> until the keyboard_rgb_save attribute is set
>> (write-only):
>> * 0 - slow
>> * 1 - medium
>> - * 2 - fast
>> \ No newline at end of file
>
> ^^^
>
>> + * 2 - fast
>> +
>> +What: /sys/devices/platform/<platform>/keyboard_rgb_state
>> +Date: Aug 2022
>> +KernelVersion: 6.1
>> +Contact: "Luke Jones" <luke@ljones.dev>
>> +Description:
>> + Set some RGB keyboard power states (write-only).
>> +
>> + The accepted input is "boot awake sleep keyboard",
>> where "n n n n n"
>> + options are:
>> + * save - 0 or 1, if 0 then settings are not
>> retained on boot
>> + * boot - 0 or 1, controls if a boot
>> animation is shown
>> + * awake - 0 or 1, controls if the keyboard
>> LED are on during awake
>> + * sleep - 0 or 1, controls if a suspended
>> animation is shown.
>> + This is only active
>> if the AC is connected.
>> + * keyboard - 0 or 1, unknown what effect
>> this really has
>> \ No newline at end of file
>
> ^^^
>
> Be sure of not repeating the same mistake. I.e. add a newline as
> suggested.
>
>
>> + flags = 0;
>
> Seems you ignored my comment here...
>
>> + if (sscanf(buf, "%hhd %hhd %hhd %hhd %hhd", &save, &boot,
>> &awake, &sleep, &keyboard) != 5
>> + return -EINVAL;
>
>> + save = save == 0 ? 0x0100 : 0x0000;
>
> ...and here...
>
>> + if (boot)
>> + flags |= 0x02;
>> + if (awake)
>> + flags |= 0x08;
>> + if (sleep)
>> + flags |= 0x20;
>> + if (keyboard)
>> + flags |= 0x80;
>
> ...and here.
>
Umm... I know for sure I fixed all those. I must have screwed up a git
rebase :(
I'll fix again.
next prev parent reply other threads:[~2022-08-09 8:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 2:50 [PATCH v3 0/6] asus-wmi: Add support for RGB keyboards Luke D. Jones
2022-08-09 2:50 ` [PATCH v3 1/6] asus-wmi: Implement TUF laptop keyboard RGB control Luke D. Jones
2022-08-09 8:46 ` Andy Shevchenko
2022-08-09 8:55 ` Luke Jones
2022-08-09 9:29 ` Andy Shevchenko
2022-08-09 9:31 ` Luke Jones
2022-08-09 10:50 ` Pavel Machek
2022-08-10 4:44 ` Luke Jones
2022-08-11 15:01 ` Hans de Goede
2022-08-11 15:05 ` Hans de Goede
2022-08-11 22:13 ` Luke Jones
2022-08-09 2:50 ` [PATCH v3 2/6] asus-wmi: Implement TUF laptop keyboard LED modes Luke D. Jones
2022-08-09 3:16 ` Luke Jones
2022-08-09 9:22 ` Andy Shevchenko
2022-08-09 9:30 ` Luke Jones
2022-08-09 2:50 ` [PATCH v3 3/6] asus-wmi: Implement TUF laptop keyboard power states Luke D. Jones
2022-08-09 8:52 ` Andy Shevchenko
2022-08-09 8:58 ` Luke Jones [this message]
2022-08-09 2:50 ` [PATCH v3 4/6] asus-wmi: Document previously added attributes Luke D. Jones
2022-08-09 9:25 ` Andy Shevchenko
2022-08-11 15:08 ` Hans de Goede
2022-08-11 22:08 ` Luke Jones
2022-08-09 2:50 ` [PATCH v3 5/6] asus-wmi: Convert all attr-show to use sysfs_emit Luke D. Jones
2022-08-09 9:27 ` Andy Shevchenko
2022-08-11 18:52 ` Hans de Goede
2022-08-09 2:50 ` [PATCH v3 6/6] asus-wmi: Support the hardware GPU MUX on some laptops Luke D. Jones
2022-08-09 7:19 ` Luke Jones
2022-08-11 13:53 ` Hans de Goede
2022-08-11 22:01 ` Luke Jones
2022-08-12 7:59 ` Hans de Goede
2022-08-12 8:31 ` Thomas Weißschuh
2022-08-12 8:44 ` Hans de Goede
2022-08-09 8:55 ` [PATCH v3 0/6] asus-wmi: Add support for RGB keyboards Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0LBCGR.NDLPJAR4JTJQ@ljones.dev \
--to=luke@ljones.dev \
--cc=andy.shevchenko@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pobrn@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).