Re: [PATCH v3 1/6] asus-wmi: Implement TUF laptop keyboard RGB control

From: Luke Jones <luke@ljones.dev>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
	"Barnabás Pőcze" <pobrn@protonmail.com>,
	"Pavel Machek" <pavel@ucw.cz>,
	"Platform Driver" <platform-driver-x86@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/6] asus-wmi: Implement TUF laptop keyboard RGB control
Date: Tue, 09 Aug 2022 21:31:34 +1200	[thread overview]
Message-ID: <6fee3e143bd339ac9e4e8513c96a3af2137a3b3a.camel@ljones.dev> (raw)
In-Reply-To: <CAHp75VepmbLv1cx2cS6gbe_prs+cHZ0DYjJNkcuOXxeJaCqDGw@mail.gmail.com>

On Tue, 2022-08-09 at 11:29 +0200, Andy Shevchenko wrote:
> On Tue, Aug 9, 2022 at 10:56 AM Luke Jones <luke@ljones.dev> wrote:
> > On Tue, Aug 9 2022 at 10:46:33 +0200, Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > > On Tue, Aug 9, 2022 at 4:51 AM Luke D. Jones <luke@ljones.dev>
> > > wrote:
> 
> ...
> 
> > > >  +       err =
> > > > asus_wmi_evaluate_method3(ASUS_WMI_METHODID_DEVS,
> > > > ASUS_WMI_DEVID_TUF_RGB_MODE,
> > > >  +                               rgb->save | (rgb->mode << 8) |
> > > > (r
> > > > << 16) | (g << 24),
> > > >  +                               (b) | (rgb->speed << 8),
> > > 
> > > Too many parentheses.
> > 
> > Uh, yeah. I was unable to find concrete info on this. I at one
> > point
> > experienced an issue where the order of operations *without*
> > parentheses ended up as "x | y << (8 | z) << 16". But now I'm not
> > even
> > sure if I remember that correctly. I see the order here
> > https://www.cs.uic.edu/~i109/Notes/COperatorPrecedenceTable.pdf
> > 
> > I'll do as said and test it to be certain.
> 
> I'm talking about the '(b)' part. The rest is okay to me.
> 

Understood, thanks.