Re: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

Re: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

[Alex Dewar]

Friendly ping? 🙂

I'm also CC'ing the x86 platform people into this, as I'm not sure
whether this problem is something more within their remit.

Best,
Alex

On Wed, 2022-06-29 at 10:43 +0100, Alex Dewar wrote:
> Hi,
> 
> I'm running Linux 5.18.7 on an HP Elite Dragonfly G2 laptop, which
> seems
> to use the i8042 driver. Mostly things seem to work (including
> hotkeys)
> except that the increase/decrease brightness keys instead send the
> "mic
> mute" keycode. (The *actual* mic mute key works fine.)
> 
> Any ideas? Do we need to add a quirk?
> 
> Best,
> Alex

Re: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

[Hans de Goede]

Hi,

On 7/5/22 19:25, Alex Dewar wrote:
> Friendly ping? 🙂
> 
> I'm also CC'ing the x86 platform people into this, as I'm not sure
> whether this problem is something more within their remit.

Please test the atbkd device with "sudo evemu-record" or "sudo evtest"
and if the brightness keys generate events there, write down the
raw event codes (MSC events).

Assuming the brightness keys indeed send events here, then:

After that you need to create an update to:
/lib/udev/hwdb.d/60-keyboard.hwdb to fix the mapping for your laptop.
See the "To update this file, create a new file ..." section.

You can find the DMI match pattern used in this file by doing:

cat /sys/class/dmi/id/modalias

Once you have things working, please submit a pull-req to upstream
systemd to get these quirk included in the offical hwdb. Or send
me a copy of the local 70-keyboard.hwdb override you have created
and I can submit it upstream for you.

Regards,

Hans



> 
> Best,
> Alex
> 
> On Wed, 2022-06-29 at 10:43 +0100, Alex Dewar wrote:
>> Hi,
>>
>> I'm running Linux 5.18.7 on an HP Elite Dragonfly G2 laptop, which
>> seems
>> to use the i8042 driver. Mostly things seem to work (including
>> hotkeys)
>> except that the increase/decrease brightness keys instead send the
>> "mic
>> mute" keycode. (The *actual* mic mute key works fine.)
>>
>> Any ideas? Do we need to add a quirk?
>>
>> Best,
>> Alex
> 

Re: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

[Alex Dewar]

Hi Hans,

On Sat, 2022-07-09 at 16:56 +0200, Hans de Goede wrote:
> Hi,
> 
> On 7/5/22 19:25, Alex Dewar wrote:
> > Friendly ping? 🙂
> > 
> > I'm also CC'ing the x86 platform people into this, as I'm not sure
> > whether this problem is something more within their remit.
> 
> Please test the atbkd device with "sudo evemu-record" or "sudo
> evtest"
> and if the brightness keys generate events there, write down the
> raw event codes (MSC events).

I tried this but unfortunately this doesn't seem to be the whole story.
If I press "decrease brightness" I get:
Event: time 1657525393.922727, -------------- SYN_REPORT ------------
Event: time 1657525397.043348, type 4 (EV_MSC), code 4 (MSC_SCAN),
value 81
Event: time 1657525397.043348, type 1 (EV_KEY), code 190 (KEY_F20),
value 1
Event: time 1657525397.043348, -------------- SYN_REPORT ------------
Event: time 1657525397.050384, type 4 (EV_MSC), code 4 (MSC_SCAN),
value 81
Event: time 1657525397.050384, type 1 (EV_KEY), code 190 (KEY_F20),
value 0

And if I press "increase brightness" I get:
Event: time 1657525397.050384, -------------- SYN_REPORT ------------
Event: time 1657525398.607184, type 4 (EV_MSC), code 4 (MSC_SCAN),
value 81
Event: time 1657525398.607184, type 1 (EV_KEY), code 190 (KEY_F20),
value 1
Event: time 1657525398.607184, -------------- SYN_REPORT ------------
Event: time 1657525398.614190, type 4 (EV_MSC), code 4 (MSC_SCAN),
value 81
Event: time 1657525398.614190, type 1 (EV_KEY), code 190 (KEY_F20),
value 0

There's no difference! And I also get the same thing if I press the
*actual* mute mic button 😞.

Any ideas?

Best,
Alex

Re: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

[Hans de Goede]

Hi Alex,

On 7/11/22 09:49, Alex Dewar wrote:
> Hi Hans,
> 
> On Sat, 2022-07-09 at 16:56 +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 7/5/22 19:25, Alex Dewar wrote:
>>> Friendly ping? 🙂
>>>
>>> I'm also CC'ing the x86 platform people into this, as I'm not sure
>>> whether this problem is something more within their remit.
>>
>> Please test the atbkd device with "sudo evemu-record" or "sudo
>> evtest"
>> and if the brightness keys generate events there, write down the
>> raw event codes (MSC events).
> 
> I tried this but unfortunately this doesn't seem to be the whole story.
> If I press "decrease brightness" I get:
> Event: time 1657525393.922727, -------------- SYN_REPORT ------------
> Event: time 1657525397.043348, type 4 (EV_MSC), code 4 (MSC_SCAN),
> value 81
> Event: time 1657525397.043348, type 1 (EV_KEY), code 190 (KEY_F20),
> value 1
> Event: time 1657525397.043348, -------------- SYN_REPORT ------------
> Event: time 1657525397.050384, type 4 (EV_MSC), code 4 (MSC_SCAN),
> value 81
> Event: time 1657525397.050384, type 1 (EV_KEY), code 190 (KEY_F20),
> value 0
> 
> And if I press "increase brightness" I get:
> Event: time 1657525397.050384, -------------- SYN_REPORT ------------
> Event: time 1657525398.607184, type 4 (EV_MSC), code 4 (MSC_SCAN),
> value 81
> Event: time 1657525398.607184, type 1 (EV_KEY), code 190 (KEY_F20),
> value 1
> Event: time 1657525398.607184, -------------- SYN_REPORT ------------
> Event: time 1657525398.614190, type 4 (EV_MSC), code 4 (MSC_SCAN),
> value 81
> Event: time 1657525398.614190, type 1 (EV_KEY), code 190 (KEY_F20),
> value 0
> 
> There's no difference! And I also get the same thing if I press the
> *actual* mute mic button 😞.
> 
> Any ideas?

From this it looks like we need to use some other interface to get
these events (+ ignore the above events).

Do you have a "HP WMI hotkeys" device in your list of input
devices?  And are you getting any events on that ?

Likewise do you have a "Video Bus" device and any events on that ?

I've also added Jorge from HP to the Cc. Jorge, can you help with this ?

Regards,

Hans

RE: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

[Lopez, Jorge A (Security)]

Hi Alex,

Let me investigate this issue.  The driver maps some keys, so it is possible the list is incomplete.  
It is expected hp_wmi driver to be loaded, Correct?
Can you provide the BIOS version current in your system?


Regards,

Jorge Lopez
Hewlett-Packard 

“Once you stop learning, you start dying”
Albert Einstein

-----Original Message-----
From: Hans de Goede <hdegoede@redhat.com> 
Sent: Monday, July 11, 2022 7:10 AM
To: Alex Dewar <alex.dewar@gmx.co.uk>; dmitry.torokhov@gmail.com; tiwai@suse.de; markgross@kernel.org; Lopez, Jorge A (Security) <jorge.lopez2@hp.com>
Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org
Subject: Re: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

Hi Alex,

On 7/11/22 09:49, Alex Dewar wrote:
> Hi Hans,
> 
> On Sat, 2022-07-09 at 16:56 +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 7/5/22 19:25, Alex Dewar wrote:
>>> Friendly ping? 🙂
>>>
>>> I'm also CC'ing the x86 platform people into this, as I'm not sure 
>>> whether this problem is something more within their remit.
>>
>> Please test the atbkd device with "sudo evemu-record" or "sudo 
>> evtest"
>> and if the brightness keys generate events there, write down the raw 
>> event codes (MSC events).
> 
> I tried this but unfortunately this doesn't seem to be the whole story.
> If I press "decrease brightness" I get:
> Event: time 1657525393.922727, -------------- SYN_REPORT ------------
> Event: time 1657525397.043348, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> value 81
> Event: time 1657525397.043348, type 1 (EV_KEY), code 190 (KEY_F20), 
> value 1
> Event: time 1657525397.043348, -------------- SYN_REPORT ------------
> Event: time 1657525397.050384, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> value 81
> Event: time 1657525397.050384, type 1 (EV_KEY), code 190 (KEY_F20), 
> value 0
> 
> And if I press "increase brightness" I get:
> Event: time 1657525397.050384, -------------- SYN_REPORT ------------
> Event: time 1657525398.607184, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> value 81
> Event: time 1657525398.607184, type 1 (EV_KEY), code 190 (KEY_F20), 
> value 1
> Event: time 1657525398.607184, -------------- SYN_REPORT ------------
> Event: time 1657525398.614190, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> value 81
> Event: time 1657525398.614190, type 1 (EV_KEY), code 190 (KEY_F20), 
> value 0
> 
> There's no difference! And I also get the same thing if I press the
> *actual* mute mic button 😞.
> 
> Any ideas?

From this it looks like we need to use some other interface to get these events (+ ignore the above events).

Do you have a "HP WMI hotkeys" device in your list of input devices?  And are you getting any events on that ?

Likewise do you have a "Video Bus" device and any events on that ?

I've also added Jorge from HP to the Cc. Jorge, can you help with this ?

Regards,

Hans

RE: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

[Lopez, Jorge A (Security)]

Hi Alex,

I confirmed brightness up/down and mute are AT translated set of keys and not handled by HP-WMI driver.
BIOS should be sending an 0x4 event which keycode 224 (brightness up), 225 (brightness down), and 190 (microphone).
Instead, BIOS is sending keycode 190 for all three keys.

I will search for an Elite Dragonfly G2 unit and try to duplicate the problem.  Please send the BIOS version your system is running on.
This problem could have been reported and fixed in the latest BIOS version.

Look forward to hearing back from you.


Regards,

Jorge Lopez
Hewlett-Packard 

“Once you stop learning, you start dying”
Albert Einstein

-----Original Message-----
From: Lopez, Jorge A (Security) 
Sent: Monday, July 11, 2022 8:10 AM
To: 'Hans de Goede' <hdegoede@redhat.com>; Alex Dewar <alex.dewar@gmx.co.uk>; dmitry.torokhov@gmail.com; tiwai@suse.de; markgross@kernel.org
Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org
Subject: RE: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

Hi Alex,

Let me investigate this issue.  The driver maps some keys, so it is possible the list is incomplete.  
It is expected hp_wmi driver to be loaded, Correct?
Can you provide the BIOS version current in your system?


Regards,

Jorge Lopez
Hewlett-Packard 

“Once you stop learning, you start dying”
Albert Einstein

-----Original Message-----
From: Hans de Goede <hdegoede@redhat.com>
Sent: Monday, July 11, 2022 7:10 AM
To: Alex Dewar <alex.dewar@gmx.co.uk>; dmitry.torokhov@gmail.com; tiwai@suse.de; markgross@kernel.org; Lopez, Jorge A (Security) <jorge.lopez2@hp.com>
Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org
Subject: Re: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

Hi Alex,

On 7/11/22 09:49, Alex Dewar wrote:
> Hi Hans,
> 
> On Sat, 2022-07-09 at 16:56 +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 7/5/22 19:25, Alex Dewar wrote:
>>> Friendly ping? 🙂
>>>
>>> I'm also CC'ing the x86 platform people into this, as I'm not sure 
>>> whether this problem is something more within their remit.
>>
>> Please test the atbkd device with "sudo evemu-record" or "sudo 
>> evtest"
>> and if the brightness keys generate events there, write down the raw 
>> event codes (MSC events).
> 
> I tried this but unfortunately this doesn't seem to be the whole story.
> If I press "decrease brightness" I get:
> Event: time 1657525393.922727, -------------- SYN_REPORT ------------
> Event: time 1657525397.043348, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> value 81
> Event: time 1657525397.043348, type 1 (EV_KEY), code 190 (KEY_F20), 
> value 1
> Event: time 1657525397.043348, -------------- SYN_REPORT ------------
> Event: time 1657525397.050384, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> value 81
> Event: time 1657525397.050384, type 1 (EV_KEY), code 190 (KEY_F20), 
> value 0
> 
> And if I press "increase brightness" I get:
> Event: time 1657525397.050384, -------------- SYN_REPORT ------------
> Event: time 1657525398.607184, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> value 81
> Event: time 1657525398.607184, type 1 (EV_KEY), code 190 (KEY_F20), 
> value 1
> Event: time 1657525398.607184, -------------- SYN_REPORT ------------
> Event: time 1657525398.614190, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> value 81
> Event: time 1657525398.614190, type 1 (EV_KEY), code 190 (KEY_F20), 
> value 0
> 
> There's no difference! And I also get the same thing if I press the
> *actual* mute mic button 😞.
> 
> Any ideas?

From this it looks like we need to use some other interface to get these events (+ ignore the above events).

Do you have a "HP WMI hotkeys" device in your list of input devices?  And are you getting any events on that ?

Likewise do you have a "Video Bus" device and any events on that ?

I've also added Jorge from HP to the Cc. Jorge, can you help with this ?

Regards,

Hans

Re: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

[Alex Dewar]

On Mon, 2022-07-11 at 14:26 +0000, Lopez, Jorge A (Security) wrote:
> Hi Alex,
> 
> I confirmed brightness up/down and mute are AT translated set of keys
> and not handled by HP-WMI driver.
> BIOS should be sending an 0x4 event which keycode 224 (brightness
> up), 225 (brightness down), and 190 (microphone).
> Instead, BIOS is sending keycode 190 for all three keys.
> 
> I will search for an Elite Dragonfly G2 unit and try to duplicate the
> problem.  Please send the BIOS version your system is running on.
> This problem could have been reported and fixed in the latest BIOS
> version.
> 
> Look forward to hearing back from you.
> 
> 
> Regards,
> 
> Jorge Lopez
> Hewlett-Packard 
> 
> “Once you stop learning, you start dying”
> Albert Einstein

Hi Jorge,

Thanks for looking into this 🙂

Here is my BIOS info:
Handle 0x0001, DMI type 0, 26 bytes
BIOS Information
        Vendor: HP
        Version: T90 Ver. 01.04.01
        Release Date: 06/01/2021
        Address: 0xF0000
        Runtime Size: 64 kB
        ROM Size: 32 MB
        Characteristics:
                PCI is supported
                PC Card (PCMCIA) is supported
                BIOS is upgradeable
                BIOS shadowing is allowed
                Boot from CD is supported
                Selectable boot is supported
                EDD is supported
                Print screen service is supported (int 5h)
                8042 keyboard services are supported (int 9h)
                Serial services are supported (int 14h)
                Printer services are supported (int 17h)
                ACPI is supported
                USB legacy is supported
                Smart battery is supported
                BIOS boot specification is supported
                Function key-initiated network boot is supported
                Targeted content distribution is supported
                UEFI is supported
        BIOS Revision: 4.1
        Firmware Revision: 55.29

I should maybe add that I think the keyboard was working fine when I
had Windows 10 running on this machine and I haven't updated the BIOS
since installing Linux.

In case it's relevant, I'm running Arch Linux with the following
kernel:
Linux ic-alex-elitebook 5.18.9-arch1-1 #1 SMP PREEMPT_DYNAMIC Sat, 02
Jul 2022 21:03:06 +0000 x86_64 GNU/Linux

Best,
Alex

> 
> -----Original Message-----
> From: Lopez, Jorge A (Security) 
> Sent: Monday, July 11, 2022 8:10 AM
> To: 'Hans de Goede' <hdegoede@redhat.com>; Alex Dewar
> <alex.dewar@gmx.co.uk>; dmitry.torokhov@gmail.com; tiwai@suse.de;
> markgross@kernel.org
> Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org;
> platform-driver-x86@vger.kernel.org
> Subject: RE: input/i8042: Malfunctioning brightness keys on HP Elite
> Dragonfly G2
> 
> Hi Alex,
> 
> Let me investigate this issue.  The driver maps some keys, so it is
> possible the list is incomplete.  
> It is expected hp_wmi driver to be loaded, Correct?
> Can you provide the BIOS version current in your system?
> 
> 
> Regards,
> 
> Jorge Lopez
> Hewlett-Packard 
> 
> “Once you stop learning, you start dying”
> Albert Einstein
> 
> -----Original Message-----
> From: Hans de Goede <hdegoede@redhat.com>
> Sent: Monday, July 11, 2022 7:10 AM
> To: Alex Dewar <alex.dewar@gmx.co.uk>; dmitry.torokhov@gmail.com;
> tiwai@suse.de; markgross@kernel.org; Lopez, Jorge A (Security)
> <jorge.lopez2@hp.com>
> Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org;
> platform-driver-x86@vger.kernel.org
> Subject: Re: input/i8042: Malfunctioning brightness keys on HP Elite
> Dragonfly G2
> 
> Hi Alex,
> 
> On 7/11/22 09:49, Alex Dewar wrote:
> > Hi Hans,
> > 
> > On Sat, 2022-07-09 at 16:56 +0200, Hans de Goede wrote:
> > > Hi,
> > > 
> > > On 7/5/22 19:25, Alex Dewar wrote:
> > > > Friendly ping? 🙂
> > > > 
> > > > I'm also CC'ing the x86 platform people into this, as I'm not
> > > > sure 
> > > > whether this problem is something more within their remit.
> > > 
> > > Please test the atbkd device with "sudo evemu-record" or "sudo 
> > > evtest"
> > > and if the brightness keys generate events there, write down the
> > > raw 
> > > event codes (MSC events).
> > 
> > I tried this but unfortunately this doesn't seem to be the whole
> > story.
> > If I press "decrease brightness" I get:
> > Event: time 1657525393.922727, -------------- SYN_REPORT ----------
> > --
> > Event: time 1657525397.043348, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> > value 81
> > Event: time 1657525397.043348, type 1 (EV_KEY), code 190 (KEY_F20),
> > value 1
> > Event: time 1657525397.043348, -------------- SYN_REPORT ----------
> > --
> > Event: time 1657525397.050384, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> > value 81
> > Event: time 1657525397.050384, type 1 (EV_KEY), code 190 (KEY_F20),
> > value 0
> > 
> > And if I press "increase brightness" I get:
> > Event: time 1657525397.050384, -------------- SYN_REPORT ----------
> > --
> > Event: time 1657525398.607184, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> > value 81
> > Event: time 1657525398.607184, type 1 (EV_KEY), code 190 (KEY_F20),
> > value 1
> > Event: time 1657525398.607184, -------------- SYN_REPORT ----------
> > --
> > Event: time 1657525398.614190, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> > value 81
> > Event: time 1657525398.614190, type 1 (EV_KEY), code 190 (KEY_F20),
> > value 0
> > 
> > There's no difference! And I also get the same thing if I press the
> > *actual* mute mic button 😞.
> > 
> > Any ideas?
> 
> From this it looks like we need to use some other interface to get
> these events (+ ignore the above events).
> 
> Do you have a "HP WMI hotkeys" device in your list of input devices? 
> And are you getting any events on that ?
> 
> Likewise do you have a "Video Bus" device and any events on that ?
> 
> I've also added Jorge from HP to the Cc. Jorge, can you help with
> this ?
> 
> Regards,
> 
> Hans
> 

RE: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

[Lopez, Jorge A (Security)]

Hi Alex,

Thank you for the BIOS information.   The problem you are experiencing was fixed in BIOS version 01.07.02 Rev.A

	- Fixes an issue where Fn+F3/F4 do not change the brightness of the display panel when the Privacy Panel is enabled in the F10 settings.

The latest BIOS version is 01.09.01 Rev.A so the problem will be resolved after BIOS upgrade.    BIOS is not available via LVFS, you will need to install it via Windows executable.
https://support.hp.com/us-en/drivers/laptops

Let me know if the problem is resolved.


Regards,

Jorge Lopez
Hewlett-Packard 

“Once you stop learning, you start dying”
Albert Einstein

-----Original Message-----
From: Alex Dewar <alex.dewar@gmx.co.uk> 
Sent: Monday, July 11, 2022 9:36 AM
To: Lopez, Jorge A (Security) <jorge.lopez2@hp.com>; Hans de Goede <hdegoede@redhat.com>; dmitry.torokhov@gmail.com; tiwai@suse.de; markgross@kernel.org
Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org
Subject: Re: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

On Mon, 2022-07-11 at 14:26 +0000, Lopez, Jorge A (Security) wrote:
> Hi Alex,
> 
> I confirmed brightness up/down and mute are AT translated set of keys 
> and not handled by HP-WMI driver.
> BIOS should be sending an 0x4 event which keycode 224 (brightness up), 
> 225 (brightness down), and 190 (microphone).
> Instead, BIOS is sending keycode 190 for all three keys.
> 
> I will search for an Elite Dragonfly G2 unit and try to duplicate the 
> problem.  Please send the BIOS version your system is running on.
> This problem could have been reported and fixed in the latest BIOS 
> version.
> 
> Look forward to hearing back from you.
> 
> 
> Regards,
> 
> Jorge Lopez
> Hewlett-Packard
> 
> “Once you stop learning, you start dying”
> Albert Einstein

Hi Jorge,

Thanks for looking into this 🙂

Here is my BIOS info:
Handle 0x0001, DMI type 0, 26 bytes
BIOS Information
        Vendor: HP
        Version: T90 Ver. 01.04.01
        Release Date: 06/01/2021
        Address: 0xF0000
        Runtime Size: 64 kB
        ROM Size: 32 MB
        Characteristics:
                PCI is supported
                PC Card (PCMCIA) is supported
                BIOS is upgradeable
                BIOS shadowing is allowed
                Boot from CD is supported
                Selectable boot is supported
                EDD is supported
                Print screen service is supported (int 5h)
                8042 keyboard services are supported (int 9h)
                Serial services are supported (int 14h)
                Printer services are supported (int 17h)
                ACPI is supported
                USB legacy is supported
                Smart battery is supported
                BIOS boot specification is supported
                Function key-initiated network boot is supported
                Targeted content distribution is supported
                UEFI is supported
        BIOS Revision: 4.1
        Firmware Revision: 55.29

I should maybe add that I think the keyboard was working fine when I had Windows 10 running on this machine and I haven't updated the BIOS since installing Linux.

In case it's relevant, I'm running Arch Linux with the following
kernel:
Linux ic-alex-elitebook 5.18.9-arch1-1 #1 SMP PREEMPT_DYNAMIC Sat, 02 Jul 2022 21:03:06 +0000 x86_64 GNU/Linux

Best,
Alex

> 
> -----Original Message-----
> From: Lopez, Jorge A (Security)
> Sent: Monday, July 11, 2022 8:10 AM
> To: 'Hans de Goede' <hdegoede@redhat.com>; Alex Dewar 
> <alex.dewar@gmx.co.uk>; dmitry.torokhov@gmail.com; tiwai@suse.de; 
> markgross@kernel.org
> Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; 
> platform-driver-x86@vger.kernel.org
> Subject: RE: input/i8042: Malfunctioning brightness keys on HP Elite 
> Dragonfly G2
> 
> Hi Alex,
> 
> Let me investigate this issue.  The driver maps some keys, so it is 
> possible the list is incomplete.
> It is expected hp_wmi driver to be loaded, Correct?
> Can you provide the BIOS version current in your system?
> 
> 
> Regards,
> 
> Jorge Lopez
> Hewlett-Packard
> 
> “Once you stop learning, you start dying”
> Albert Einstein
> 
> -----Original Message-----
> From: Hans de Goede <hdegoede@redhat.com>
> Sent: Monday, July 11, 2022 7:10 AM
> To: Alex Dewar <alex.dewar@gmx.co.uk>; dmitry.torokhov@gmail.com; 
> tiwai@suse.de; markgross@kernel.org; Lopez, Jorge A (Security) 
> <jorge.lopez2@hp.com>
> Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; 
> platform-driver-x86@vger.kernel.org
> Subject: Re: input/i8042: Malfunctioning brightness keys on HP Elite 
> Dragonfly G2
> 
> Hi Alex,
> 
> On 7/11/22 09:49, Alex Dewar wrote:
> > Hi Hans,
> > 
> > On Sat, 2022-07-09 at 16:56 +0200, Hans de Goede wrote:
> > > Hi,
> > > 
> > > On 7/5/22 19:25, Alex Dewar wrote:
> > > > Friendly ping? 🙂
> > > > 
> > > > I'm also CC'ing the x86 platform people into this, as I'm not 
> > > > sure whether this problem is something more within their remit.
> > > 
> > > Please test the atbkd device with "sudo evemu-record" or "sudo 
> > > evtest"
> > > and if the brightness keys generate events there, write down the 
> > > raw event codes (MSC events).
> > 
> > I tried this but unfortunately this doesn't seem to be the whole 
> > story.
> > If I press "decrease brightness" I get:
> > Event: time 1657525393.922727, -------------- SYN_REPORT ----------
> > --
> > Event: time 1657525397.043348, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> > value 81
> > Event: time 1657525397.043348, type 1 (EV_KEY), code 190 (KEY_F20), 
> > value 1
> > Event: time 1657525397.043348, -------------- SYN_REPORT ----------
> > --
> > Event: time 1657525397.050384, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> > value 81
> > Event: time 1657525397.050384, type 1 (EV_KEY), code 190 (KEY_F20), 
> > value 0
> > 
> > And if I press "increase brightness" I get:
> > Event: time 1657525397.050384, -------------- SYN_REPORT ----------
> > --
> > Event: time 1657525398.607184, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> > value 81
> > Event: time 1657525398.607184, type 1 (EV_KEY), code 190 (KEY_F20), 
> > value 1
> > Event: time 1657525398.607184, -------------- SYN_REPORT ----------
> > --
> > Event: time 1657525398.614190, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> > value 81
> > Event: time 1657525398.614190, type 1 (EV_KEY), code 190 (KEY_F20), 
> > value 0
> > 
> > There's no difference! And I also get the same thing if I press the
> > *actual* mute mic button 😞.
> > 
> > Any ideas?
> 
> From this it looks like we need to use some other interface to get 
> these events (+ ignore the above events).
> 
> Do you have a "HP WMI hotkeys" device in your list of input devices? 
> And are you getting any events on that ?
> 
> Likewise do you have a "Video Bus" device and any events on that ?
> 
> I've also added Jorge from HP to the Cc. Jorge, can you help with this 
> ?
> 
> Regards,
> 
> Hans
> 

Re: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

[Alex Dewar]

On Mon, 2022-07-11 at 14:59 +0000, Lopez, Jorge A (Security) wrote:
> Hi Alex,
> 
> Thank you for the BIOS information.   The problem you are
> experiencing was fixed in BIOS version 01.07.02 Rev.A
> 
>         - Fixes an issue where Fn+F3/F4 do not change the brightness
> of the display panel when the Privacy Panel is enabled in the F10
> settings.
> 
> The latest BIOS version is 01.09.01 Rev.A so the problem will be
> resolved after BIOS upgrade.    BIOS is not available via LVFS, you
> will need to install it via Windows executable.
> https://support.hp.com/us-en/drivers/laptops
> 
> Let me know if the problem is resolved.

That worked a treat. Thanks!

And if you have an internal ticked called "Support Elitebooks on LVFS"
or similar, feel free to add my +1 to it 😉

Best,
Alex

RE: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

[Lopez, Jorge A (Security)]

HI Alex,

HP is working in publishing HP BIOS to LVFS and the team is making progress.  
There are several BIOS published and it appears BIOS for your Elite Dragonfly is one of them.   
See https://fwupd.org/lvfs/firmware/10948.

The BIOS is applicable to notebooks with T90 type BIOS.  If you decide to try flashing the firmware, please do it at your own risk.

BIOS-System Firmware (1)
HP BIOS and System Firmware (T90)
Version: 01.09.10 Rev.A	



Regards,

Jorge Lopez
Hewlett-Packard 

“Once you stop learning, you start dying”
Albert Einstein

-----Original Message-----
From: Alex Dewar <alex.dewar@gmx.co.uk> 
Sent: Wednesday, July 13, 2022 3:17 AM
To: Lopez, Jorge A (Security) <jorge.lopez2@hp.com>; Hans de Goede <hdegoede@redhat.com>; dmitry.torokhov@gmail.com; tiwai@suse.de; markgross@kernel.org
Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org
Subject: Re: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

On Mon, 2022-07-11 at 14:59 +0000, Lopez, Jorge A (Security) wrote:
> Hi Alex,
> 
> Thank you for the BIOS information.   The problem you are experiencing 
> was fixed in BIOS version 01.07.02 Rev.A
> 
>         - Fixes an issue where Fn+F3/F4 do not change the brightness 
> of the display panel when the Privacy Panel is enabled in the F10 
> settings.
> 
> The latest BIOS version is 01.09.01 Rev.A so the problem will be 
> resolved after BIOS upgrade.    BIOS is not available via LVFS, you 
> will need to install it via Windows executable.
> https://support.hp.com/us-en/drivers/laptops
> 
> Let me know if the problem is resolved.

That worked a treat. Thanks!

And if you have an internal ticked called "Support Elitebooks on LVFS"
or similar, feel free to add my +1 to it 😉

Best,
Alex

Re: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

[Alex Dewar]

On Wed, 2022-07-13 at 16:34 +0000, Lopez, Jorge A (Security) wrote:
> HI Alex,
> 
> HP is working in publishing HP BIOS to LVFS and the team is making
> progress.  
> There are several BIOS published and it appears BIOS for your Elite
> Dragonfly is one of them.   
> See https://fwupd.org/lvfs/firmware/10948.
> 
> The BIOS is applicable to notebooks with T90 type BIOS.  If you
> decide to try flashing the firmware, please do it at your own risk.
> 
> BIOS-System Firmware (1)
> HP BIOS and System Firmware (T90)
> Version: 01.09.10 Rev.A 
> 
> 

Great! Thanks 🙂
> 
> Regards,
> 
> Jorge Lopez
> Hewlett-Packard 
> 
> “Once you stop learning, you start dying”
> Albert Einstein
> 
> -----Original Message-----
> From: Alex Dewar <alex.dewar@gmx.co.uk> 
> Sent: Wednesday, July 13, 2022 3:17 AM
> To: Lopez, Jorge A (Security) <jorge.lopez2@hp.com>; Hans de Goede
> <hdegoede@redhat.com>; dmitry.torokhov@gmail.com; tiwai@suse.de;
> markgross@kernel.org
> Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org;
> platform-driver-x86@vger.kernel.org
> Subject: Re: input/i8042: Malfunctioning brightness keys on HP Elite
> Dragonfly G2
> 
> On Mon, 2022-07-11 at 14:59 +0000, Lopez, Jorge A (Security) wrote:
> > Hi Alex,
> > 
> > Thank you for the BIOS information.   The problem you are
> > experiencing 
> > was fixed in BIOS version 01.07.02 Rev.A
> > 
> >         - Fixes an issue where Fn+F3/F4 do not change the
> > brightness 
> > of the display panel when the Privacy Panel is enabled in the F10 
> > settings.
> > 
> > The latest BIOS version is 01.09.01 Rev.A so the problem will be 
> > resolved after BIOS upgrade.    BIOS is not available via LVFS, you
> > will need to install it via Windows executable.
> > https://support.hp.com/us-en/drivers/laptops
> > 
> > Let me know if the problem is resolved.
> 
> That worked a treat. Thanks!
> 
> And if you have an internal ticked called "Support Elitebooks on
> LVFS"
> or similar, feel free to add my +1 to it 😉
> 
> Best,
> Alex
> 

Re: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

[Alex Dewar]

Friendly ping? 🙂

I'm also CC'ing the x86 platform people into this, as I'm not sure
whether this problem is something more within their remit.

Best,
Alex

On Wed, 2022-06-29 at 10:43 +0100, Alex Dewar wrote:
> Hi,
> 
> I'm running Linux 5.18.7 on an HP Elite Dragonfly G2 laptop, which
> seems
> to use the i8042 driver. Mostly things seem to work (including
> hotkeys)
> except that the increase/decrease brightness keys instead send the
> "mic
> mute" keycode. (The *actual* mic mute key works fine.)
> 
> Any ideas? Do we need to add a quirk?
> 
> Best,
> Alex