* [PATCH -next] platform/x86/dell-wmi-sysman: Make some symbols static
@ 2020-10-29 11:34 Zou Wei
2020-10-29 11:54 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2020-10-29 11:34 UTC (permalink / raw)
To: hdegoede, mgross; +Cc: platform-driver-x86, linux-kernel, Zou Wei
Fix the following sparse warnings:
drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:38:23:
warning: symbol 'po_is_pass_set' was not declared. Should it be static?
drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:70:23: warning:
symbol 'po_current_password' was not declared. Should it be static?
drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:99:23:
warning: symbol 'po_new_password' was not declared. Should it be static?
drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:103:23:
warning: symbol 'po_min_pass_length' was not declared. Should it be static?
drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:107:23:
warning: symbol 'po_max_pass_length' was not declared. Should it be static?
drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:116:23:
warning: symbol 'po_mechanism' was not declared. Should it be static?
drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:129:23:
warning: symbol 'po_role' was not declared. Should it be static?
po_is_pass_set, po_current_password, po_new_password,
po_min_pass_length, po_max_pass_length, po_mechanism and po_role
have only call within passobj-attributes.c
They should be static
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c b/drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c
index e6199fb..81562b1 100644
--- a/drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c
+++ b/drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c
@@ -35,7 +35,7 @@ static ssize_t is_enabled_show(struct kobject *kobj, struct kobj_attribute *attr
return ret;
}
-struct kobj_attribute po_is_pass_set =
+static struct kobj_attribute po_is_pass_set =
__ATTR_RO(is_enabled);
static ssize_t current_password_store(struct kobject *kobj,
@@ -67,7 +67,7 @@ static ssize_t current_password_store(struct kobject *kobj,
return count;
}
-struct kobj_attribute po_current_password =
+static struct kobj_attribute po_current_password =
__ATTR_WO(current_password);
static ssize_t new_password_store(struct kobject *kobj,
@@ -96,15 +96,15 @@ static ssize_t new_password_store(struct kobject *kobj,
return ret ? ret : count;
}
-struct kobj_attribute po_new_password =
+static struct kobj_attribute po_new_password =
__ATTR_WO(new_password);
attribute_n_property_show(min_password_length, po);
-struct kobj_attribute po_min_pass_length =
+static struct kobj_attribute po_min_pass_length =
__ATTR_RO(min_password_length);
attribute_n_property_show(max_password_length, po);
-struct kobj_attribute po_max_pass_length =
+static struct kobj_attribute po_max_pass_length =
__ATTR_RO(max_password_length);
static ssize_t mechanism_show(struct kobject *kobj, struct kobj_attribute *attr,
@@ -113,7 +113,7 @@ static ssize_t mechanism_show(struct kobject *kobj, struct kobj_attribute *attr,
return sprintf(buf, "password\n");
}
-struct kobj_attribute po_mechanism =
+static struct kobj_attribute po_mechanism =
__ATTR_RO(mechanism);
static ssize_t role_show(struct kobject *kobj, struct kobj_attribute *attr,
@@ -126,7 +126,7 @@ static ssize_t role_show(struct kobject *kobj, struct kobj_attribute *attr,
return -EIO;
}
-struct kobj_attribute po_role =
+static struct kobj_attribute po_role =
__ATTR_RO(role);
static struct attribute *po_attrs[] = {
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] platform/x86/dell-wmi-sysman: Make some symbols static
2020-10-29 11:34 [PATCH -next] platform/x86/dell-wmi-sysman: Make some symbols static Zou Wei
@ 2020-10-29 11:54 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2020-10-29 11:54 UTC (permalink / raw)
To: Zou Wei
Cc: Hans de Goede, Mark Gross, Platform Driver, Linux Kernel Mailing List
On Thu, Oct 29, 2020 at 1:22 PM Zou Wei <zou_wei@huawei.com> wrote:
>
> Fix the following sparse warnings:
>
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:38:23:
> warning: symbol 'po_is_pass_set' was not declared. Should it be static?
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:70:23: warning:
> symbol 'po_current_password' was not declared. Should it be static?
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:99:23:
> warning: symbol 'po_new_password' was not declared. Should it be static?
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:103:23:
> warning: symbol 'po_min_pass_length' was not declared. Should it be static?
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:107:23:
> warning: symbol 'po_max_pass_length' was not declared. Should it be static?
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:116:23:
> warning: symbol 'po_mechanism' was not declared. Should it be static?
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:129:23:
> warning: symbol 'po_role' was not declared. Should it be static?
>
> po_is_pass_set, po_current_password, po_new_password,
> po_min_pass_length, po_max_pass_length, po_mechanism and po_role
> have only call within passobj-attributes.c
> They should be static
I think at the same time you may put all of them in a way that each
occupies only a single line.
...
> -struct kobj_attribute po_role =
> +static struct kobj_attribute po_role =
> __ATTR_RO(role);
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-29 11:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-29 11:34 [PATCH -next] platform/x86/dell-wmi-sysman: Make some symbols static Zou Wei
2020-10-29 11:54 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).