* [PATCH] platform/surface: gpe: Add support for 13" Intel version of Surface Laptop 4
@ 2022-07-21 12:11 Maximilian Luz
2022-07-28 18:44 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Maximilian Luz @ 2022-07-21 12:11 UTC (permalink / raw)
To: Hans de Goede
Cc: Mark Gross, platform-driver-x86, linux-kernel, Maximilian Luz
The 13" Intel version of the Surface Laptop 4 uses the same GPE as the
Surface Laptop Studio for wakeups via the lid. Set it up accordingly.
Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
---
drivers/platform/surface/surface_gpe.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/platform/surface/surface_gpe.c b/drivers/platform/surface/surface_gpe.c
index 27365cbe1ee9..c219b840d491 100644
--- a/drivers/platform/surface/surface_gpe.c
+++ b/drivers/platform/surface/surface_gpe.c
@@ -171,6 +171,18 @@ static const struct dmi_system_id dmi_lid_device_table[] = {
},
.driver_data = (void *)lid_device_props_l4D,
},
+ {
+ .ident = "Surface Laptop 4 (Intel 13\")",
+ .matches = {
+ /*
+ * We match for SKU here due to different variants: The
+ * AMD (15") version does not rely on GPEs.
+ */
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "Surface_Laptop_4_1950:1951"),
+ },
+ .driver_data = (void *)lid_device_props_l4B,
+ },
{
.ident = "Surface Laptop Studio",
.matches = {
--
2.37.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/surface: gpe: Add support for 13" Intel version of Surface Laptop 4
2022-07-21 12:11 [PATCH] platform/surface: gpe: Add support for 13" Intel version of Surface Laptop 4 Maximilian Luz
@ 2022-07-28 18:44 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2022-07-28 18:44 UTC (permalink / raw)
To: Maximilian Luz; +Cc: Mark Gross, platform-driver-x86, linux-kernel
Hi,
On 7/21/22 14:11, Maximilian Luz wrote:
> The 13" Intel version of the Surface Laptop 4 uses the same GPE as the
> Surface Laptop Studio for wakeups via the lid. Set it up accordingly.
>
> Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/surface/surface_gpe.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/platform/surface/surface_gpe.c b/drivers/platform/surface/surface_gpe.c
> index 27365cbe1ee9..c219b840d491 100644
> --- a/drivers/platform/surface/surface_gpe.c
> +++ b/drivers/platform/surface/surface_gpe.c
> @@ -171,6 +171,18 @@ static const struct dmi_system_id dmi_lid_device_table[] = {
> },
> .driver_data = (void *)lid_device_props_l4D,
> },
> + {
> + .ident = "Surface Laptop 4 (Intel 13\")",
> + .matches = {
> + /*
> + * We match for SKU here due to different variants: The
> + * AMD (15") version does not rely on GPEs.
> + */
> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "Surface_Laptop_4_1950:1951"),
> + },
> + .driver_data = (void *)lid_device_props_l4B,
> + },
> {
> .ident = "Surface Laptop Studio",
> .matches = {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-28 18:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-21 12:11 [PATCH] platform/surface: gpe: Add support for 13" Intel version of Surface Laptop 4 Maximilian Luz
2022-07-28 18:44 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).