From: Henning Schild <henning.schild@siemens.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>, Pavel Machek <pavel@ucw.cz>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Lee Jones <lee@kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
Sheng-Yuan Huang <syhuang3@nuvoton.com>,
Tasanakorn Phaipool <tasanakorn@gmail.com>,
"simon.guinot@sequanux.org" <simon.guinot@sequanux.org>
Subject: Re: [PATCH v3 2/4] gpio-f7188x: use unique labels for banks/chips
Date: Mon, 22 Aug 2022 15:21:33 +0200 [thread overview]
Message-ID: <20220822152133.5e8f257e@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <CAHp75VdWdzsT9wc9BNNKTJ3-eBn3uWdCFXqE2TT+CiJnoTOQYw@mail.gmail.com>
Am Fri, 12 Aug 2022 10:39:08 +0200
schrieb Andy Shevchenko <andy.shevchenko@gmail.com>:
> On Thursday, August 11, 2022, Henning Schild
> <henning.schild@siemens.com> wrote:
>
> > So that drivers building on top can find those pins with GPIO_LOOKUP
> > helpers.
>
>
>
> Missed given tag. Do we need to bother reviewing your patches?
Sorry but i have no idea what you are talking about, please help me
out. Whatever i did miss seems to be pretty relevant it seems.
Henning
>
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> > drivers/gpio/gpio-f7188x.c | 138
> > ++++++++++++++++++------------------- 1 file changed, 69
> > insertions(+), 69 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c
> > index 7b05ecc611e9..45b466b04070 100644
> > --- a/drivers/gpio/gpio-f7188x.c
> > +++ b/drivers/gpio/gpio-f7188x.c
> > @@ -149,10 +149,10 @@ static void f7188x_gpio_set(struct gpio_chip
> > *chip, unsigned offset, int value);
> > static int f7188x_gpio_set_config(struct gpio_chip *chip, unsigned
> > offset, unsigned long config);
> >
> > -#define F7188X_GPIO_BANK(_base, _ngpio, _regbase)
> > \ +#define F7188X_GPIO_BANK(_base, _ngpio, _regbase, _label)
> > \
> > {
> > \ .chip = { \
> > - .label = DRVNAME,
> > \
> > + .label = _label,
> > \ .owner = THIS_MODULE, \
> > .get_direction =
> > f7188x_gpio_get_direction, \ .direction_input =
> > f7188x_gpio_direction_in, \ @@ -177,98 +177,98 @@ static int
> > f7188x_gpio_set_config(struct gpio_chip *chip, unsigned offset,
> > #define gpio_data_single(type) ((type) == nct6116d)
> >
> > static struct f7188x_gpio_bank f71869_gpio_bank[] = {
> > - F7188X_GPIO_BANK(0, 6, 0xF0),
> > - F7188X_GPIO_BANK(10, 8, 0xE0),
> > - F7188X_GPIO_BANK(20, 8, 0xD0),
> > - F7188X_GPIO_BANK(30, 8, 0xC0),
> > - F7188X_GPIO_BANK(40, 8, 0xB0),
> > - F7188X_GPIO_BANK(50, 5, 0xA0),
> > - F7188X_GPIO_BANK(60, 6, 0x90),
> > + F7188X_GPIO_BANK(0, 6, 0xF0, DRVNAME "-0"),
> > + F7188X_GPIO_BANK(10, 8, 0xE0, DRVNAME "-1"),
> > + F7188X_GPIO_BANK(20, 8, 0xD0, DRVNAME "-2"),
> > + F7188X_GPIO_BANK(30, 8, 0xC0, DRVNAME "-3"),
> > + F7188X_GPIO_BANK(40, 8, 0xB0, DRVNAME "-4"),
> > + F7188X_GPIO_BANK(50, 5, 0xA0, DRVNAME "-5"),
> > + F7188X_GPIO_BANK(60, 6, 0x90, DRVNAME "-6"),
> > };
> >
> > static struct f7188x_gpio_bank f71869a_gpio_bank[] = {
> > - F7188X_GPIO_BANK(0, 6, 0xF0),
> > - F7188X_GPIO_BANK(10, 8, 0xE0),
> > - F7188X_GPIO_BANK(20, 8, 0xD0),
> > - F7188X_GPIO_BANK(30, 8, 0xC0),
> > - F7188X_GPIO_BANK(40, 8, 0xB0),
> > - F7188X_GPIO_BANK(50, 5, 0xA0),
> > - F7188X_GPIO_BANK(60, 8, 0x90),
> > - F7188X_GPIO_BANK(70, 8, 0x80),
> > + F7188X_GPIO_BANK(0, 6, 0xF0, DRVNAME "-0"),
> > + F7188X_GPIO_BANK(10, 8, 0xE0, DRVNAME "-1"),
> > + F7188X_GPIO_BANK(20, 8, 0xD0, DRVNAME "-2"),
> > + F7188X_GPIO_BANK(30, 8, 0xC0, DRVNAME "-3"),
> > + F7188X_GPIO_BANK(40, 8, 0xB0, DRVNAME "-4"),
> > + F7188X_GPIO_BANK(50, 5, 0xA0, DRVNAME "-5"),
> > + F7188X_GPIO_BANK(60, 8, 0x90, DRVNAME "-6"),
> > + F7188X_GPIO_BANK(70, 8, 0x80, DRVNAME "-7"),
> > };
> >
> > static struct f7188x_gpio_bank f71882_gpio_bank[] = {
> > - F7188X_GPIO_BANK(0, 8, 0xF0),
> > - F7188X_GPIO_BANK(10, 8, 0xE0),
> > - F7188X_GPIO_BANK(20, 8, 0xD0),
> > - F7188X_GPIO_BANK(30, 4, 0xC0),
> > - F7188X_GPIO_BANK(40, 4, 0xB0),
> > + F7188X_GPIO_BANK(0, 8, 0xF0, DRVNAME "-0"),
> > + F7188X_GPIO_BANK(10, 8, 0xE0, DRVNAME "-1"),
> > + F7188X_GPIO_BANK(20, 8, 0xD0, DRVNAME "-2"),
> > + F7188X_GPIO_BANK(30, 4, 0xC0, DRVNAME "-3"),
> > + F7188X_GPIO_BANK(40, 4, 0xB0, DRVNAME "-4"),
> > };
> >
> > static struct f7188x_gpio_bank f71889a_gpio_bank[] = {
> > - F7188X_GPIO_BANK(0, 7, 0xF0),
> > - F7188X_GPIO_BANK(10, 7, 0xE0),
> > - F7188X_GPIO_BANK(20, 8, 0xD0),
> > - F7188X_GPIO_BANK(30, 8, 0xC0),
> > - F7188X_GPIO_BANK(40, 8, 0xB0),
> > - F7188X_GPIO_BANK(50, 5, 0xA0),
> > - F7188X_GPIO_BANK(60, 8, 0x90),
> > - F7188X_GPIO_BANK(70, 8, 0x80),
> > + F7188X_GPIO_BANK(0, 7, 0xF0, DRVNAME "-0"),
> > + F7188X_GPIO_BANK(10, 7, 0xE0, DRVNAME "-1"),
> > + F7188X_GPIO_BANK(20, 8, 0xD0, DRVNAME "-2"),
> > + F7188X_GPIO_BANK(30, 8, 0xC0, DRVNAME "-3"),
> > + F7188X_GPIO_BANK(40, 8, 0xB0, DRVNAME "-4"),
> > + F7188X_GPIO_BANK(50, 5, 0xA0, DRVNAME "-5"),
> > + F7188X_GPIO_BANK(60, 8, 0x90, DRVNAME "-6"),
> > + F7188X_GPIO_BANK(70, 8, 0x80, DRVNAME "-7"),
> > };
> >
> > static struct f7188x_gpio_bank f71889_gpio_bank[] = {
> > - F7188X_GPIO_BANK(0, 7, 0xF0),
> > - F7188X_GPIO_BANK(10, 7, 0xE0),
> > - F7188X_GPIO_BANK(20, 8, 0xD0),
> > - F7188X_GPIO_BANK(30, 8, 0xC0),
> > - F7188X_GPIO_BANK(40, 8, 0xB0),
> > - F7188X_GPIO_BANK(50, 5, 0xA0),
> > - F7188X_GPIO_BANK(60, 8, 0x90),
> > - F7188X_GPIO_BANK(70, 8, 0x80),
> > + F7188X_GPIO_BANK(0, 7, 0xF0, DRVNAME "-0"),
> > + F7188X_GPIO_BANK(10, 7, 0xE0, DRVNAME "-1"),
> > + F7188X_GPIO_BANK(20, 8, 0xD0, DRVNAME "-2"),
> > + F7188X_GPIO_BANK(30, 8, 0xC0, DRVNAME "-3"),
> > + F7188X_GPIO_BANK(40, 8, 0xB0, DRVNAME "-4"),
> > + F7188X_GPIO_BANK(50, 5, 0xA0, DRVNAME "-5"),
> > + F7188X_GPIO_BANK(60, 8, 0x90, DRVNAME "-6"),
> > + F7188X_GPIO_BANK(70, 8, 0x80, DRVNAME "-7"),
> > };
> >
> > static struct f7188x_gpio_bank f81866_gpio_bank[] = {
> > - F7188X_GPIO_BANK(0, 8, 0xF0),
> > - F7188X_GPIO_BANK(10, 8, 0xE0),
> > - F7188X_GPIO_BANK(20, 8, 0xD0),
> > - F7188X_GPIO_BANK(30, 8, 0xC0),
> > - F7188X_GPIO_BANK(40, 8, 0xB0),
> > - F7188X_GPIO_BANK(50, 8, 0xA0),
> > - F7188X_GPIO_BANK(60, 8, 0x90),
> > - F7188X_GPIO_BANK(70, 8, 0x80),
> > - F7188X_GPIO_BANK(80, 8, 0x88),
> > + F7188X_GPIO_BANK(0, 8, 0xF0, DRVNAME "-0"),
> > + F7188X_GPIO_BANK(10, 8, 0xE0, DRVNAME "-1"),
> > + F7188X_GPIO_BANK(20, 8, 0xD0, DRVNAME "-2"),
> > + F7188X_GPIO_BANK(30, 8, 0xC0, DRVNAME "-3"),
> > + F7188X_GPIO_BANK(40, 8, 0xB0, DRVNAME "-4"),
> > + F7188X_GPIO_BANK(50, 8, 0xA0, DRVNAME "-5"),
> > + F7188X_GPIO_BANK(60, 8, 0x90, DRVNAME "-6"),
> > + F7188X_GPIO_BANK(70, 8, 0x80, DRVNAME "-7"),
> > + F7188X_GPIO_BANK(80, 8, 0x88, DRVNAME "-8"),
> > };
> >
> >
> > static struct f7188x_gpio_bank f81804_gpio_bank[] = {
> > - F7188X_GPIO_BANK(0, 8, 0xF0),
> > - F7188X_GPIO_BANK(10, 8, 0xE0),
> > - F7188X_GPIO_BANK(20, 8, 0xD0),
> > - F7188X_GPIO_BANK(50, 8, 0xA0),
> > - F7188X_GPIO_BANK(60, 8, 0x90),
> > - F7188X_GPIO_BANK(70, 8, 0x80),
> > - F7188X_GPIO_BANK(90, 8, 0x98),
> > + F7188X_GPIO_BANK(0, 8, 0xF0, DRVNAME "-0"),
> > + F7188X_GPIO_BANK(10, 8, 0xE0, DRVNAME "-1"),
> > + F7188X_GPIO_BANK(20, 8, 0xD0, DRVNAME "-2"),
> > + F7188X_GPIO_BANK(50, 8, 0xA0, DRVNAME "-3"),
> > + F7188X_GPIO_BANK(60, 8, 0x90, DRVNAME "-4"),
> > + F7188X_GPIO_BANK(70, 8, 0x80, DRVNAME "-5"),
> > + F7188X_GPIO_BANK(90, 8, 0x98, DRVNAME "-6"),
> > };
> >
> > static struct f7188x_gpio_bank f81865_gpio_bank[] = {
> > - F7188X_GPIO_BANK(0, 8, 0xF0),
> > - F7188X_GPIO_BANK(10, 8, 0xE0),
> > - F7188X_GPIO_BANK(20, 8, 0xD0),
> > - F7188X_GPIO_BANK(30, 8, 0xC0),
> > - F7188X_GPIO_BANK(40, 8, 0xB0),
> > - F7188X_GPIO_BANK(50, 8, 0xA0),
> > - F7188X_GPIO_BANK(60, 5, 0x90),
> > + F7188X_GPIO_BANK(0, 8, 0xF0, DRVNAME "-0"),
> > + F7188X_GPIO_BANK(10, 8, 0xE0, DRVNAME "-1"),
> > + F7188X_GPIO_BANK(20, 8, 0xD0, DRVNAME "-2"),
> > + F7188X_GPIO_BANK(30, 8, 0xC0, DRVNAME "-3"),
> > + F7188X_GPIO_BANK(40, 8, 0xB0, DRVNAME "-4"),
> > + F7188X_GPIO_BANK(50, 8, 0xA0, DRVNAME "-5"),
> > + F7188X_GPIO_BANK(60, 5, 0x90, DRVNAME "-6"),
> > };
> >
> > static struct f7188x_gpio_bank nct6116d_gpio_bank[] = {
> > - F7188X_GPIO_BANK(0, 8, 0xE0),
> > - F7188X_GPIO_BANK(10, 8, 0xE4),
> > - F7188X_GPIO_BANK(20, 8, 0xE8),
> > - F7188X_GPIO_BANK(30, 8, 0xEC),
> > - F7188X_GPIO_BANK(40, 8, 0xF0),
> > - F7188X_GPIO_BANK(50, 8, 0xF4),
> > - F7188X_GPIO_BANK(60, 8, 0xF8),
> > - F7188X_GPIO_BANK(70, 1, 0xFC),
> > + F7188X_GPIO_BANK(0, 8, 0xE0, DRVNAME "-0"),
> > + F7188X_GPIO_BANK(10, 8, 0xE4, DRVNAME "-1"),
> > + F7188X_GPIO_BANK(20, 8, 0xE8, DRVNAME "-2"),
> > + F7188X_GPIO_BANK(30, 8, 0xEC, DRVNAME "-3"),
> > + F7188X_GPIO_BANK(40, 8, 0xF0, DRVNAME "-4"),
> > + F7188X_GPIO_BANK(50, 8, 0xF4, DRVNAME "-5"),
> > + F7188X_GPIO_BANK(60, 8, 0xF8, DRVNAME "-6"),
> > + F7188X_GPIO_BANK(70, 1, 0xFC, DRVNAME "-7"),
> > };
> >
> > static int f7188x_gpio_get_direction(struct gpio_chip *chip,
> > unsigned offset)
> > --
> > 2.35.1
> >
> >
>
next prev parent reply other threads:[~2022-08-22 13:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 15:39 [PATCH v3 0/4] add support for another simatic board Henning Schild
2022-08-11 15:39 ` [PATCH v3 1/4] gpio-f7188x: Add GPIO support for Nuvoton NCT6116 Henning Schild
2022-08-12 8:43 ` simon.guinot
2022-08-12 10:23 ` Henning Schild
2022-08-12 11:22 ` simon.guinot
2022-08-23 9:26 ` Henning Schild
2022-08-22 16:01 ` Henning Schild
[not found] ` <CAHp75VdgKHh+ma34pY=PzS6MB6NWNtzBAADqQmaJgT+couN1Dg@mail.gmail.com>
2022-08-22 13:26 ` Henning Schild
2022-08-22 14:58 ` Henning Schild
2022-08-11 15:39 ` [PATCH v3 2/4] gpio-f7188x: use unique labels for banks/chips Henning Schild
[not found] ` <CAHp75VdWdzsT9wc9BNNKTJ3-eBn3uWdCFXqE2TT+CiJnoTOQYw@mail.gmail.com>
2022-08-22 13:21 ` Henning Schild [this message]
2022-08-22 21:36 ` Andy Shevchenko
2022-08-26 8:31 ` Linus Walleij
2022-08-11 15:39 ` [PATCH v3 3/4] leds: simatic-ipc-leds-gpio: add new model 227G Henning Schild
2022-08-11 18:53 ` Hans de Goede
2022-08-11 15:39 ` [PATCH v3 4/4] platform/x86: simatic-ipc: enable watchdog for 227G Henning Schild
2022-08-11 18:53 ` Hans de Goede
2022-08-11 18:34 ` [PATCH v3 0/4] add support for another simatic board Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220822152133.5e8f257e@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=hdegoede@redhat.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=simon.guinot@sequanux.org \
--cc=syhuang3@nuvoton.com \
--cc=tasanakorn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).