From: Vadim Pasternak <vadimp@nvidia.com>
To: <hdegoede@redhat.com>
Cc: <dan.carpenter@oracle.comq>,
<platform-driver-x86@vger.kernel.org>,
"Vadim Pasternak" <vadimp@nvidia.com>
Subject: [PATCH platform 4/4] platform/mellanox: Remove redundant 'NULL' check
Date: Tue, 23 Aug 2022 23:19:37 +0300 [thread overview]
Message-ID: <20220823201937.46855-5-vadimp@nvidia.com> (raw)
In-Reply-To: <20220823201937.46855-1-vadimp@nvidia.com>
Remove 'NULL' check for 'data->hpdev.client' in error flow of
mlxreg_lc_probe(). It cannot be 'NULL' at this point.
Fixes: b4b830a34d80 ("platform/mellanox: mlxreg-lc: Fix error flow and extend verbosity")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
---
drivers/platform/mellanox/mlxreg-lc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/mellanox/mlxreg-lc.c b/drivers/platform/mellanox/mlxreg-lc.c
index 1e0c3ddc46cd..1e071df4c9f5 100644
--- a/drivers/platform/mellanox/mlxreg-lc.c
+++ b/drivers/platform/mellanox/mlxreg-lc.c
@@ -893,10 +893,8 @@ static int mlxreg_lc_probe(struct platform_device *pdev)
regcache_sync_fail:
regmap_write_fail:
devm_regmap_init_i2c_fail:
- if (data->hpdev.client) {
- i2c_unregister_device(data->hpdev.client);
- data->hpdev.client = NULL;
- }
+ i2c_unregister_device(data->hpdev.client);
+ data->hpdev.client = NULL;
i2c_new_device_fail:
i2c_put_adapter(data->hpdev.adapter);
data->hpdev.adapter = NULL;
--
2.20.1
next prev parent reply other threads:[~2022-08-23 20:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 20:19 [PATCH platform 0/4] Fixes for issues with coverity, locking, redundant checks Vadim Pasternak
2022-08-23 20:19 ` [PATCH platform 1/4] platform/mellanox: mlxreg-lc: Fix coverity warning Vadim Pasternak
2022-08-23 20:19 ` [PATCH platform 2/4] platform/mellanox: mlxreg-lc: Fix locking issue Vadim Pasternak
2022-09-01 12:48 ` Hans de Goede
2022-08-23 20:19 ` [PATCH platform 3/4] platform/mellanox: Remove unnecessary code Vadim Pasternak
2022-08-23 20:19 ` Vadim Pasternak [this message]
2022-09-01 12:46 ` [PATCH platform 0/4] Fixes for issues with coverity, locking, redundant checks Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220823201937.46855-5-vadimp@nvidia.com \
--to=vadimp@nvidia.com \
--cc=dan.carpenter@oracle.comq \
--cc=hdegoede@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).