platform-driver-x86.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Vadim Pasternak <vadimp@nvidia.com>
Cc: dan.carpenter@oracle.comq, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH platform 0/4] Fixes for issues with coverity, locking, redundant checks
Date: Thu, 1 Sep 2022 14:46:10 +0200	[thread overview]
Message-ID: <c6607aca-9e7d-08e6-f5ea-675cdd31584d@redhat.com> (raw)
In-Reply-To: <20220823201937.46855-1-vadimp@nvidia.com>

Hi All,

On 8/23/22 22:19, Vadim Pasternak wrote:
> The patch set includes fixes for several issues:
> Patch #1: fixes coverity issue.
> Patch #2: fixes locking dependency issue.
> Patches #3-#4: remove unnecessary code.

Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

I will also send this out as part of my next fixes
pull-req for 6.0-rc#.

Note I do have one code-style remark to patch 2/4,
since I want to add this to my fixes pull-req I've
taken 2/4 as is. Please send a follow-up (incremental)
patch addressing the code-style issue. See my reply
to patch 2/4.

Regards,

Hans


> 
> Vadim Pasternak (4):
>   platform/mellanox: mlxreg-lc: Fix coverity warning
>   platform/mellanox: mlxreg-lc: Fix locking issue
>   platform/mellanox: Remove unnecessary code
>   platform/mellanox: Remove redundant 'NULL' check
> 
>  drivers/platform/mellanox/mlxreg-lc.c | 53 ++++++++++++++++-----------
>  1 file changed, 31 insertions(+), 22 deletions(-)
> 


      parent reply	other threads:[~2022-09-01 12:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23 20:19 [PATCH platform 0/4] Fixes for issues with coverity, locking, redundant checks Vadim Pasternak
2022-08-23 20:19 ` [PATCH platform 1/4] platform/mellanox: mlxreg-lc: Fix coverity warning Vadim Pasternak
2022-08-23 20:19 ` [PATCH platform 2/4] platform/mellanox: mlxreg-lc: Fix locking issue Vadim Pasternak
2022-09-01 12:48   ` Hans de Goede
2022-08-23 20:19 ` [PATCH platform 3/4] platform/mellanox: Remove unnecessary code Vadim Pasternak
2022-08-23 20:19 ` [PATCH platform 4/4] platform/mellanox: Remove redundant 'NULL' check Vadim Pasternak
2022-09-01 12:46 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6607aca-9e7d-08e6-f5ea-675cdd31584d@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=dan.carpenter@oracle.comq \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=vadimp@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).