From: Pavel Machek <pavel@ucw.cz>
To: Hans de Goede <hdegoede@redhat.com>
Cc: PaddyKP_Yao <ispaddy@gmail.com>,
PaddyKP_Yao@asus.com, acpi4asus-user@lists.sourceforge.net,
andy.shevchenko@gmail.com, corentin.chary@gmail.com,
linux-kernel@vger.kernel.org, luke@ljones.dev,
mgross@linux.intel.com, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v3 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev support
Date: Wed, 24 Aug 2022 12:06:22 +0200 [thread overview]
Message-ID: <20220824100622.GB1049@bug> (raw)
In-Reply-To: <e120ac7c-7abb-4999-efe8-6b3b697d12d6@redhat.com>
Hi!
> > LED is present by checking WMI ASUS_WMI_DEVID_MICMUTE_LED, we will add a
> > mic-mute LED classdev, asus::micmute, in the asus-wmi driver to control
> > it. The binding of mic-mute LED controls will be swithched with LED
> > trigger.
> >
> > Signed-off-by: PaddyKP_Yao <PaddyKP_Yao@asus.com>
> > ---
> > V1 -> V2: fix typo for 'present' and remove unnecessary pr_info() log
> > V2 -> V3: resend patch again by gmail to avoid Asus legal in the mail
>
> Thank you for your patch, I've applied this patch to my review-hans
> branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
>
> Once I've run some tests on this branch the patches there will be
> added to the platform-drivers-x86/for-next branch and eventually
> will be included in the pdx86 pull-request to Linus for the next
> merge-window.
> > + if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_MICMUTE_LED)) {
> > + asus->micmute_led.name = "asus::micmute";
It would be good to get the API right before it hits mainline release.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2022-08-24 10:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 8:48 [PATCH 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev support PaddyKP_Yao
2022-07-08 9:07 ` PaddyKP_Yao
2022-07-09 11:44 ` Andy Shevchenko
2022-07-09 14:48 ` Hans de Goede
2022-07-09 14:49 ` Hans de Goede
2022-07-11 2:12 ` PaddyKP Yao(姚國鵬)
2022-07-11 2:40 ` [PATCH v2 " PaddyKP_Yao
2022-07-11 2:47 ` PaddyKP_Yao
2022-07-11 8:50 ` Andy Shevchenko
2022-07-11 11:41 ` PaddyKP Yao
2022-07-11 11:47 ` Hans de Goede
2022-07-11 11:51 ` [PATCH v3 " PaddyKP_Yao
2022-07-14 20:04 ` Hans de Goede
2022-08-24 10:06 ` Pavel Machek [this message]
2022-08-24 10:59 ` PaddyKP Yao
2022-08-25 7:55 ` Pavel Machek
2022-08-25 8:05 ` PaddyKP Yao
2022-08-24 10:06 ` [PATCH v2 " Pavel Machek
2022-08-24 11:09 ` PaddyKP Yao
2022-08-24 11:11 ` Hans de Goede
2022-08-24 11:17 ` PaddyKP Yao
2022-08-25 1:29 ` PaddyKP Yao
2022-08-25 8:13 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220824100622.GB1049@bug \
--to=pavel@ucw.cz \
--cc=PaddyKP_Yao@asus.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=andy.shevchenko@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ispaddy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).