From: Hans de Goede <hdegoede@redhat.com>
To: PaddyKP Yao <ispaddy@gmail.com>, Pavel Machek <pavel@ucw.cz>
Cc: PaddyKP_Yao@asus.com, andy.shevchenko@gmail.com,
acpi4asus-user@lists.sourceforge.net, corentin.chary@gmail.com,
linux-kernel@vger.kernel.org, luke@ljones.dev,
mgross@linux.intel.com, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev support
Date: Wed, 24 Aug 2022 13:11:32 +0200 [thread overview]
Message-ID: <ca13b742-7bb9-da20-4e50-2d04233aaf93@redhat.com> (raw)
In-Reply-To: <20220824110908.GB111@AA2000783-NB2.corpnet.asus>
Hi,
On 8/24/22 13:09, PaddyKP Yao wrote:
> Hi Pavel,
>
> On Wed, Aug 24, 2022 at 12:06:15PM +0200, Pavel Machek wrote:
>>> drivers/platform/x86/asus-wmi.c | 25 ++++++++++++++++++++++
>>> include/linux/platform_data/x86/asus-wmi.h | 1 +
>>> 3 files changed, 28 insertions(+)
>>>
>>> asus->micmute_led.name = "asus::micmute";
>>
>> Please see/modify well-known-leds.txt file. We want this consistent on all devices.
>
> Thanks for your feedback.
> Do you mean I should use "platform::micmute" instead of "asus::micmute"?
Yes. Since I have already merged your original patch can you please make
this a new patch on top of your original patch ? In other words just
make this 1 small change in the new patch:
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index 2d9d709aa59f..18e584eb9f0f 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -1060,7 +1060,7 @@ static int asus_wmi_led_init(struct asus_wmi *asus)
}
if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_MICMUTE_LED)) {
- asus->micmute_led.name = "asus::micmute";
+ asus->micmute_led.name = "platform::micmute";
asus->micmute_led.max_brightness = 1;
asus->micmute_led.brightness = ledtrig_audio_get(LED_AUDIO_MICMUTE);
asus->micmute_led.brightness_set_blocking = micmute_led_set;
Regards,
Hans
next prev parent reply other threads:[~2022-08-24 11:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 8:48 [PATCH 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev support PaddyKP_Yao
2022-07-08 9:07 ` PaddyKP_Yao
2022-07-09 11:44 ` Andy Shevchenko
2022-07-09 14:48 ` Hans de Goede
2022-07-09 14:49 ` Hans de Goede
2022-07-11 2:12 ` PaddyKP Yao(姚國鵬)
2022-07-11 2:40 ` [PATCH v2 " PaddyKP_Yao
2022-07-11 2:47 ` PaddyKP_Yao
2022-07-11 8:50 ` Andy Shevchenko
2022-07-11 11:41 ` PaddyKP Yao
2022-07-11 11:47 ` Hans de Goede
2022-07-11 11:51 ` [PATCH v3 " PaddyKP_Yao
2022-07-14 20:04 ` Hans de Goede
2022-08-24 10:06 ` Pavel Machek
2022-08-24 10:59 ` PaddyKP Yao
2022-08-25 7:55 ` Pavel Machek
2022-08-25 8:05 ` PaddyKP Yao
2022-08-24 10:06 ` [PATCH v2 " Pavel Machek
2022-08-24 11:09 ` PaddyKP Yao
2022-08-24 11:11 ` Hans de Goede [this message]
2022-08-24 11:17 ` PaddyKP Yao
2022-08-25 1:29 ` PaddyKP Yao
2022-08-25 8:13 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca13b742-7bb9-da20-4e50-2d04233aaf93@redhat.com \
--to=hdegoede@redhat.com \
--cc=PaddyKP_Yao@asus.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=andy.shevchenko@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=ispaddy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=mgross@linux.intel.com \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).