From: Hans de Goede <hdegoede@redhat.com>
To: Luca Stefani <luca.stefani.ge1@gmail.com>
Cc: chiu@endlessm.com, Corentin Chary <corentin.chary@gmail.com>,
Mark Gross <mgross@linux.intel.com>,
acpi4asus-user@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: asus-wmi: Disable fn-lock mode by default
Date: Tue, 23 Mar 2021 20:56:13 +0100 [thread overview]
Message-ID: <2b060044-1010-4c8c-571f-b037d96670bb@redhat.com> (raw)
In-Reply-To: <20210316221747.90829-1-luca.stefani.ge1@gmail.com>
Hi,
On 3/16/21 11:17 PM, Luca Stefani wrote:
> * On recent ZenBooks the fn-lock is disabled
> by default on boot while running Windows.
>
> * Follow the same paradigm also here.
>
> Signed-off-by: Luca Stefani <luca.stefani.ge1@gmail.com>
This will be a behavioral change for many users where their F-keys will
now all of a sudden work different after boot under Linux then they
did before.
As such this seems like a bad idea, so I'm not going to merge this patch.
What might be an option is adding a module-option which allows users to
configure the default setting at boot that way, while keeping the current
default.
Regards,
Hans
> ---
> drivers/platform/x86/asus-wmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 9ca15f724343..32319f7d6e17 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -2673,7 +2673,7 @@ static int asus_wmi_add(struct platform_device *pdev)
> err = asus_wmi_set_devstate(ASUS_WMI_DEVID_BACKLIGHT, 2, NULL);
>
> if (asus_wmi_has_fnlock_key(asus)) {
> - asus->fnlock_locked = true;
> + asus->fnlock_locked = false;
> asus_wmi_fnlock_update(asus);
> }
>
>
prev parent reply other threads:[~2021-03-23 19:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 22:17 [PATCH] platform/x86: asus-wmi: Disable fn-lock mode by default Luca Stefani
2021-03-23 19:56 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b060044-1010-4c8c-571f-b037d96670bb@redhat.com \
--to=hdegoede@redhat.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=chiu@endlessm.com \
--cc=corentin.chary@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.stefani.ge1@gmail.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).