* [PATCH] platform/x86: asus-wmi: Disable fn-lock mode by default
@ 2021-03-16 22:17 Luca Stefani
2021-03-23 19:56 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Luca Stefani @ 2021-03-16 22:17 UTC (permalink / raw)
Cc: chiu, Luca Stefani, Corentin Chary, Hans de Goede, Mark Gross,
acpi4asus-user, platform-driver-x86, linux-kernel
* On recent ZenBooks the fn-lock is disabled
by default on boot while running Windows.
* Follow the same paradigm also here.
Signed-off-by: Luca Stefani <luca.stefani.ge1@gmail.com>
---
drivers/platform/x86/asus-wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index 9ca15f724343..32319f7d6e17 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -2673,7 +2673,7 @@ static int asus_wmi_add(struct platform_device *pdev)
err = asus_wmi_set_devstate(ASUS_WMI_DEVID_BACKLIGHT, 2, NULL);
if (asus_wmi_has_fnlock_key(asus)) {
- asus->fnlock_locked = true;
+ asus->fnlock_locked = false;
asus_wmi_fnlock_update(asus);
}
--
2.31.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: asus-wmi: Disable fn-lock mode by default
2021-03-16 22:17 [PATCH] platform/x86: asus-wmi: Disable fn-lock mode by default Luca Stefani
@ 2021-03-23 19:56 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-03-23 19:56 UTC (permalink / raw)
To: Luca Stefani
Cc: chiu, Corentin Chary, Mark Gross, acpi4asus-user,
platform-driver-x86, linux-kernel
Hi,
On 3/16/21 11:17 PM, Luca Stefani wrote:
> * On recent ZenBooks the fn-lock is disabled
> by default on boot while running Windows.
>
> * Follow the same paradigm also here.
>
> Signed-off-by: Luca Stefani <luca.stefani.ge1@gmail.com>
This will be a behavioral change for many users where their F-keys will
now all of a sudden work different after boot under Linux then they
did before.
As such this seems like a bad idea, so I'm not going to merge this patch.
What might be an option is adding a module-option which allows users to
configure the default setting at boot that way, while keeping the current
default.
Regards,
Hans
> ---
> drivers/platform/x86/asus-wmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 9ca15f724343..32319f7d6e17 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -2673,7 +2673,7 @@ static int asus_wmi_add(struct platform_device *pdev)
> err = asus_wmi_set_devstate(ASUS_WMI_DEVID_BACKLIGHT, 2, NULL);
>
> if (asus_wmi_has_fnlock_key(asus)) {
> - asus->fnlock_locked = true;
> + asus->fnlock_locked = false;
> asus_wmi_fnlock_update(asus);
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-23 19:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-16 22:17 [PATCH] platform/x86: asus-wmi: Disable fn-lock mode by default Luca Stefani
2021-03-23 19:56 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).