* [PATCH] Add "X570S AORUS ELITE" to known working boards
@ 2023-03-31 1:49 Brandon Nielsen
2023-03-31 9:44 ` linux
0 siblings, 1 reply; 3+ messages in thread
From: Brandon Nielsen @ 2023-03-31 1:49 UTC (permalink / raw)
Cc: Thomas Weißschuh, Hans de Goede, Mark Gross,
platform-driver-x86, linux-kernel, Brandon Nielsen
---
drivers/platform/x86/gigabyte-wmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/gigabyte-wmi.c b/drivers/platform/x86/gigabyte-wmi.c
index 4dd39ab6ecfa..ca5124e31d2c 100644
--- a/drivers/platform/x86/gigabyte-wmi.c
+++ b/drivers/platform/x86/gigabyte-wmi.c
@@ -160,6 +160,7 @@ static const struct dmi_system_id gigabyte_wmi_known_working_platforms[] = {
DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 GAMING X"),
DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 I AORUS PRO WIFI"),
DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 UD"),
+ DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570S AORUS ELITE"),
DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("Z690M AORUS ELITE AX DDR4"),
{ }
};
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Add "X570S AORUS ELITE" to known working boards
2023-03-31 1:49 [PATCH] Add "X570S AORUS ELITE" to known working boards Brandon Nielsen
@ 2023-03-31 9:44 ` linux
2023-03-31 17:34 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: linux @ 2023-03-31 9:44 UTC (permalink / raw)
To: Brandon Nielsen
Cc: Hans de Goede, Mark Gross, platform-driver-x86, linux-kernel
Hi,
thanks for the patch!
Mar 31, 2023 04:01:37 Brandon Nielsen <nielsenb@jetfuse.net>:
> ---
> drivers/platform/x86/gigabyte-wmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/gigabyte-wmi.c b/drivers/platform/x86/gigabyte-wmi.c
> index 4dd39ab6ecfa..ca5124e31d2c 100644
> --- a/drivers/platform/x86/gigabyte-wmi.c
> +++ b/drivers/platform/x86/gigabyte-wmi.c
> @@ -160,6 +160,7 @@ static const struct dmi_system_id gigabyte_wmi_known_working_platforms[] = {
> DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 GAMING X"),
> DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 I AORUS PRO WIFI"),
> DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 UD"),
> + DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570S AORUS ELITE"),
> DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("Z690M AORUS ELITE AX DDR4"),
> { }
> };
> -- > 2.39.2
This patch is missing a proper subject line, a commit message and Signed-off-by.
Please send a v2 and take a look how similar patches are structured.
https://lore.kernel.org/lkml/20220705184407.14181-1-parherman@gmail.com/
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Add "X570S AORUS ELITE" to known working boards
2023-03-31 9:44 ` linux
@ 2023-03-31 17:34 ` Hans de Goede
0 siblings, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2023-03-31 17:34 UTC (permalink / raw)
To: linux, Brandon Nielsen; +Cc: Mark Gross, platform-driver-x86, linux-kernel
Hi,
On 3/31/23 11:44, linux@weissschuh.net wrote:
> Hi,
>
> thanks for the patch!
>
>
> Mar 31, 2023 04:01:37 Brandon Nielsen <nielsenb@jetfuse.net>:
>
>> ---
>> drivers/platform/x86/gigabyte-wmi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/platform/x86/gigabyte-wmi.c b/drivers/platform/x86/gigabyte-wmi.c
>> index 4dd39ab6ecfa..ca5124e31d2c 100644
>> --- a/drivers/platform/x86/gigabyte-wmi.c
>> +++ b/drivers/platform/x86/gigabyte-wmi.c
>> @@ -160,6 +160,7 @@ static const struct dmi_system_id gigabyte_wmi_known_working_platforms[] = {
>> DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 GAMING X"),
>> DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 I AORUS PRO WIFI"),
>> DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 UD"),
>> + DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570S AORUS ELITE"),
>> DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("Z690M AORUS ELITE AX DDR4"),
>> { }
>> };
>> -- > 2.39.2
>
>
> This patch is missing a proper subject line, a commit message and Signed-off-by.
> Please send a v2 and take a look how similar patches are structured.
>
> https://lore.kernel.org/lkml/20220705184407.14181-1-parherman@gmail.com/
Since I'm preparing a fixes pull-req to send to Linus today
and since this is just a simple hw-id addition I have merged this now,
so that it can be included in the fixes pull-req.
I have fixed the subject and solved the missing Signed-off-by problem
by setting myself as author and crediting Brandon with a:
Reported-by: Brandon Nielsen <nielsenb@jetfuse.net>
Regards,
Hans
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-31 17:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-31 1:49 [PATCH] Add "X570S AORUS ELITE" to known working boards Brandon Nielsen
2023-03-31 9:44 ` linux
2023-03-31 17:34 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).