platform-driver-x86.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Kate Hsuan <hpa@redhat.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com,
	Mark Gross <mgross@linux.intel.com>,
	Alex Hung <alex.hung@canonical.com>,
	Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>,
	David E Box <david.e.box@intel.com>,
	Zha Qipeng <qipeng.zha@intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	"David E. Box" <david.e.box@linux.intel.com>,
	AceLan Kao <acelan.kao@canonical.com>,
	Jithu Joseph <jithu.joseph@intel.com>,
	Maurice Ma <maurice.ma@intel.com>
Subject: Re: [PATCH v4 00/21] platform/x86: Intel platform driver code movement
Date: Fri, 20 Aug 2021 12:22:19 +0200	[thread overview]
Message-ID: <35fcce39-dc82-a656-a3f5-0a39dee39cff@redhat.com> (raw)
In-Reply-To: <YR9/83LozDtedLKZ@smile.fi.intel.com>

Hi,

On 8/20/21 12:12 PM, Andy Shevchenko wrote:
> On Thu, Aug 19, 2021 at 08:46:14PM +0200, Hans de Goede wrote:
>> On 8/19/21 6:37 PM, Andy Shevchenko wrote:
>>> This is v4 of the Intel drivers move on in the source tree.
>>> v3 has been done by Kate:
>>> https://lore.kernel.org/platform-driver-x86/20210819033001.20136-1-hpa@redhat.com/
>>>
>>> I have taken the initial set from review-hans branch and removed Hans' SoB
>>> along with Link, while leaving others' tags.
>>>
>>> Changelog v4:
>>> - spelled fully the driver names in the commit messages
>>> - fixed SCU *.ko module names
>>
>> Actually I checked this during review and
>> CONFIG_INTEL_SCU_IPC, CONFIG_INTEL_SCU_PCI and CONFIG_INTEL_SCU_WDT
>> are booleans, iow if enabled they are always builtin so the
>> drivers/platform/x86/intel/scu/Makefile from v3 was correct.
>>
>> Since the v3 Makefile is more simple I prefer that version,
>> but if you prefer to keep the v4 version that is fine too.
> 
> I prefer mine, but we need to fix what kbuild bot complained about.

Right, so I've taken a look at that and I believe that
we need to change 2 things:

1. In drivers/platform/x86/intel/Makefile, use:

obj-$(CONFIG_INTEL_SCU_IPC)		+= scu/

Instead of:

obj-$(CONFIG_INTEL_SCU)			+= scu/

Since "config MFD_INTEL_PMC_BXT" from drivers/mfd/Kconfig
selects INTEL_SCU_IPC not INTEL_SCU. From a pdx86 pov thos
makes on difference since CONFIG_INTEL_SCU selects
INTEL_SCU_IPC too, so all pdx86 Kconfig options needing us to
dive into the scu subdir also end up selecting INTEL_SCU_IPC
(through INTEL_SC).

2. The "select INTEL_SCU_IPC" done by CONFIG_MFD_INTEL_PMC_BXT
only works if make will actually dive into the
drivers/platform/x86/intel subdir which requires
CONFIG_X86_PLATFORM_DRIVERS_INTEL to be set, so in the
"config MFD_INTEL_PMC_BXT" section of drivers/mfd/Kconfig

The following change should be made:

-	depends on X86_PLATFORM_DEVICES
+	depends on X86_PLATFORM_DRIVERS_INTEL

To ensure that we dive into the intel subdir of
drivers/platform/x86, note that X86_PLATFORM_DRIVERS_INTEL
depends on X86_PLATFORM_DEVICES (through being part of a
"if X86_PLATFORM_DEVICES" Kconfig section), so we can just
replace the depends on, rather then adding a new one.

With those 2 things changed that error should be gone.

This requires an ack from Lee to merge the drivers/mfd/Kconfig
change through pdx86, so as discussed I agree that it is best
to delay moving the scu bits till after 5.15-rc1 is out.

> 
>>> - dropped extra prefix in PMC files
>>> - dropped stray changes within the series
>>> - removed confusing comments in Makefile and Kconfig files
>>> - embedded a few of Kconfig improvements here and there (ordering, spelling)
>>> - split miscellaneous group
>>> - added a patch to fix kernel doc issue in SCU IPC code
>>
>> Thanks, I've not (re)reviewed things, but this all sounds good.
>>
>>> So, I have noticed the report about SCU and taking into account IPS
>>> header deferred move, I think those two should be excluded from the
>>> series and sent after rc1, it will also eliminate trampoline move for
>>> IPS header, since we may send one patch which includes DRM changes.
>>>
>>> Hans, what do you think?
>>
>> Fixing the SCU thing will require coordination with / an 
>> ack from the MFD maintainer (Lee) so yeah dropping that for
>> now and doing the SCU move next cycle is probably the best.
>>
>> Dropping the IPS move for now is fine with me too.
>>
>> Can you send a v5 with those 2 patches dropped ?> 
> Yes.

Great, thank you.

Regards,

Hans


      reply	other threads:[~2021-08-20 10:22 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-19 16:37 Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 01/21] platform/x86: intel_bxtwc_tmu: Move to intel sub-directory Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 02/21] platform/x86: intel_chtdc_ti_pwrbtn: " Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 03/21] platform/x86: intel_mrfld_pwrbtn: " Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 04/21] platform/x86: intel_punit_ipc: " Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 05/21] platform/x86: intel_pmc_core: " Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 06/21] platform/x86: intel_scu: " Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 07/21] platform/x86: intel_telemetry: " Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 08/21] platform/x86: intel_ips: " Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 09/21] platform/x86: intel-rst: " Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 10/21] platform/x86: intel-smartconnect: " Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 11/21] platform/x86: intel_turbo_max_3: " Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 12/21] platform/x86: intel-uncore-frequency: " Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 13/21] platform/x86: intel_speed_select_if: " Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 14/21] platform/x86: intel_atomisp2: " Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 15/21] platform/x86: intel-hid: " Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 16/21] platform/x86: intel_int0002_vgpio: " Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 17/21] platform/x86: intel_oaktrail: " Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 18/21] platform/x86: intel-vbtn: " Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 19/21] platform/x86: intel-wmi-sbl-fw-update: " Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 20/21] platform/x86: intel-wmi-thunderbolt: " Andy Shevchenko
2021-08-19 16:37 ` [PATCH v4 21/21] platform/x86/intel: scu: Fix doc of intel_scu_ipc_dev_command_with_size() Andy Shevchenko
2021-08-19 17:46 ` [PATCH v4 00/21] platform/x86: Intel platform driver code movement Andy Shevchenko
2021-08-19 18:46 ` Hans de Goede
2021-08-20 10:12   ` Andy Shevchenko
2021-08-20 10:22     ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35fcce39-dc82-a656-a3f5-0a39dee39cff@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=Dell.Client.Kernel@dell.com \
    --cc=acelan.kao@canonical.com \
    --cc=alex.hung@canonical.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=david.e.box@intel.com \
    --cc=david.e.box@linux.intel.com \
    --cc=hpa@redhat.com \
    --cc=irenic.rajneesh@gmail.com \
    --cc=jithu.joseph@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maurice.ma@intel.com \
    --cc=mgross@linux.intel.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=qipeng.zha@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --subject='Re: [PATCH v4 00/21] platform/x86: Intel platform driver code movement' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).