* [PATCH] platform/x86: intel-vbtn: Remove unused KEYMAP_LEN define
@ 2021-03-25 12:32 Hans de Goede
2021-03-25 12:59 ` Andy Shevchenko
2021-04-07 11:23 ` Hans de Goede
0 siblings, 2 replies; 3+ messages in thread
From: Hans de Goede @ 2021-03-25 12:32 UTC (permalink / raw)
To: Mark Gross, Andy Shevchenko; +Cc: Hans de Goede, platform-driver-x86
Now that we have 2 separate input_dev-s for the buttons and thw switches,
this is no longer used, remove it.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/platform/x86/intel-vbtn.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
index 3fdf4cbec9ad..888a764efad1 100644
--- a/drivers/platform/x86/intel-vbtn.c
+++ b/drivers/platform/x86/intel-vbtn.c
@@ -63,9 +63,6 @@ static const struct key_entry intel_vbtn_switchmap[] = {
{ KE_END }
};
-#define KEYMAP_LEN \
- (ARRAY_SIZE(intel_vbtn_keymap) + ARRAY_SIZE(intel_vbtn_switchmap) + 1)
-
struct intel_vbtn_priv {
struct input_dev *buttons_dev;
struct input_dev *switches_dev;
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: intel-vbtn: Remove unused KEYMAP_LEN define
2021-03-25 12:32 [PATCH] platform/x86: intel-vbtn: Remove unused KEYMAP_LEN define Hans de Goede
@ 2021-03-25 12:59 ` Andy Shevchenko
2021-04-07 11:23 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2021-03-25 12:59 UTC (permalink / raw)
To: Hans de Goede; +Cc: Mark Gross, Andy Shevchenko, Platform Driver
On Thu, Mar 25, 2021 at 2:34 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Now that we have 2 separate input_dev-s for the buttons and thw switches,
> this is no longer used, remove it.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/platform/x86/intel-vbtn.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
> index 3fdf4cbec9ad..888a764efad1 100644
> --- a/drivers/platform/x86/intel-vbtn.c
> +++ b/drivers/platform/x86/intel-vbtn.c
> @@ -63,9 +63,6 @@ static const struct key_entry intel_vbtn_switchmap[] = {
> { KE_END }
> };
>
> -#define KEYMAP_LEN \
> - (ARRAY_SIZE(intel_vbtn_keymap) + ARRAY_SIZE(intel_vbtn_switchmap) + 1)
> -
> struct intel_vbtn_priv {
> struct input_dev *buttons_dev;
> struct input_dev *switches_dev;
> --
> 2.30.2
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: intel-vbtn: Remove unused KEYMAP_LEN define
2021-03-25 12:32 [PATCH] platform/x86: intel-vbtn: Remove unused KEYMAP_LEN define Hans de Goede
2021-03-25 12:59 ` Andy Shevchenko
@ 2021-04-07 11:23 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2021-04-07 11:23 UTC (permalink / raw)
To: Mark Gross, Andy Shevchenko; +Cc: platform-driver-x86
Hi,
On 3/25/21 1:32 PM, Hans de Goede wrote:
> Now that we have 2 separate input_dev-s for the buttons and thw switches,
> this is no longer used, remove it.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied to my review-hans branch. Andy, thank you for the review.
Regards,
Hans
> ---
> drivers/platform/x86/intel-vbtn.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
> index 3fdf4cbec9ad..888a764efad1 100644
> --- a/drivers/platform/x86/intel-vbtn.c
> +++ b/drivers/platform/x86/intel-vbtn.c
> @@ -63,9 +63,6 @@ static const struct key_entry intel_vbtn_switchmap[] = {
> { KE_END }
> };
>
> -#define KEYMAP_LEN \
> - (ARRAY_SIZE(intel_vbtn_keymap) + ARRAY_SIZE(intel_vbtn_switchmap) + 1)
> -
> struct intel_vbtn_priv {
> struct input_dev *buttons_dev;
> struct input_dev *switches_dev;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-07 11:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-25 12:32 [PATCH] platform/x86: intel-vbtn: Remove unused KEYMAP_LEN define Hans de Goede
2021-03-25 12:59 ` Andy Shevchenko
2021-04-07 11:23 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).