Re: [PATCH] platform/x86: gigabyte-wmi: add X570 AORUS ELITE

["Thomas Weißschuh" <thomas@weissschuh.net>]

Hi Hans, Hi Julian,

Acked-By: Thomas Weißschuh <thomas@weissschuh.net>

Thomas

On Do, 2021-04-15T10:33+0200, Hans de Goede wrote:
> Date: Thu, 15 Apr 2021 10:33:59 +0200
> From: Hans de Goede <hdegoede@redhat.com>
> To: Julian Labus <julian@labus-online.de>,
>  platform-driver-x86@vger.kernel.org, Thomas Weißschuh
>  <thomas@weissschuh.net>
> Subject: Re: [PATCH] platform/x86: gigabyte-wmi: add X570 AORUS ELITE
> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
>  Thunderbird/78.8.1
> 
> Hi Julian,
> 
> Thank you for your patch.
> 
> As indicated in the MAINTAINERS file the gigabyte-wmi driver
> is maintained by Thomas Weißschuh (added to the Cc), so you should
> have Cc-ed Thomas on this submission.
> 
> Thomas can you review/ack this please ?
> 
> (the patch looks fine to me but I want to give you a chance to comment
> on it before merging it)
> 
> Regards,
> 
> Hans
> 
> 
> 
> 
> On 4/15/21 9:45 AM, Julian Labus wrote:
> > Add the X570 AORUS ELITE to gigabyte_wmi_known_working_platforms
> > 
> > Signed-off-by: Julian Labus <julian@labus-online.de>
> > ---
> > 
> > I read on phoronix.com that a driver for Gigabyte WMI will be added.
> > I gave it a try on my Gigabyte X570 AORUS ELITE with force_load=1 and
> > it seem to work fine. lm_sensors shows 6 sensors with reasonable values.
> > 
> > gigabyte_wmi-virtual-0
> > Adapter: Virtual device
> > temp1:        +26.0°C  
> > temp2:        +30.0°C  
> > temp3:        +27.0°C  
> > temp4:        +34.0°C  
> > temp5:        +29.0°C  
> > temp6:        +43.0°C  
> > 
> > The patch was created against the for-next branch of platform-drivers-x86.git
> > 
> >  drivers/platform/x86/gigabyte-wmi.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/platform/x86/gigabyte-wmi.c b/drivers/platform/x86/gigabyte-wmi.c
> > index bb1b0b205fa7..e127a2077bbc 100644
> > --- a/drivers/platform/x86/gigabyte-wmi.c
> > +++ b/drivers/platform/x86/gigabyte-wmi.c
> > @@ -146,6 +146,10 @@ static const struct dmi_system_id gigabyte_wmi_known_working_platforms[] = {
> >  		DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
> >  		DMI_EXACT_MATCH(DMI_BOARD_NAME, "Z390 I AORUS PRO WIFI-CF"),
> >  	}},
> > +	{ .matches = {
> > +		DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
> > +		DMI_EXACT_MATCH(DMI_BOARD_NAME, "X570 AORUS ELITE"),
> > +	}},
> >  	{ .matches = {
> >  		DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
> >  		DMI_EXACT_MATCH(DMI_BOARD_NAME, "X570 I AORUS PRO WIFI"),
> > 
>