Re: [PATCH] platform/x86: gigabyte-wmi: add X570 AORUS ELITE

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 4/15/21 9:45 AM, Julian Labus wrote:
> Add the X570 AORUS ELITE to gigabyte_wmi_known_working_platforms
> 
> Signed-off-by: Julian Labus <julian@labus-online.de>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans



> ---
> 
> I read on phoronix.com that a driver for Gigabyte WMI will be added.
> I gave it a try on my Gigabyte X570 AORUS ELITE with force_load=1 and
> it seem to work fine. lm_sensors shows 6 sensors with reasonable values.
> 
> gigabyte_wmi-virtual-0
> Adapter: Virtual device
> temp1:        +26.0°C  
> temp2:        +30.0°C  
> temp3:        +27.0°C  
> temp4:        +34.0°C  
> temp5:        +29.0°C  
> temp6:        +43.0°C  
> 
> The patch was created against the for-next branch of platform-drivers-x86.git
> 
>  drivers/platform/x86/gigabyte-wmi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/platform/x86/gigabyte-wmi.c b/drivers/platform/x86/gigabyte-wmi.c
> index bb1b0b205fa7..e127a2077bbc 100644
> --- a/drivers/platform/x86/gigabyte-wmi.c
> +++ b/drivers/platform/x86/gigabyte-wmi.c
> @@ -146,6 +146,10 @@ static const struct dmi_system_id gigabyte_wmi_known_working_platforms[] = {
>  		DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
>  		DMI_EXACT_MATCH(DMI_BOARD_NAME, "Z390 I AORUS PRO WIFI-CF"),
>  	}},
> +	{ .matches = {
> +		DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
> +		DMI_EXACT_MATCH(DMI_BOARD_NAME, "X570 AORUS ELITE"),
> +	}},
>  	{ .matches = {
>  		DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
>  		DMI_EXACT_MATCH(DMI_BOARD_NAME, "X570 I AORUS PRO WIFI"),
>