From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Mark Gross <markgross@kernel.org>,
Andy Shevchenko <andy@infradead.org>,
Wolfram Sang <wsa@the-dreams.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Daniel Scally <djrscally@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-i2c <linux-i2c@vger.kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Kate Hsuan <hpa@redhat.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v4 08/11] platform/x86: int3472: Add get_sensor_adev_and_name() helper
Date: Mon, 25 Oct 2021 14:31:32 +0300 [thread overview]
Message-ID: <CAHp75VeLAW6ZBQYidnD7PDYfAH3A2bq+oMJTru-9OW_t-XS26g@mail.gmail.com> (raw)
In-Reply-To: <20211025094119.82967-9-hdegoede@redhat.com>
On Mon, Oct 25, 2021 at 12:42 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> The discrete.c code is not the only code which needs to lookup the
> acpi_device and device-name for the sensor for which the INT3472
> ACPI-device is a GPIO/clk/regulator provider.
>
> The tps68470.c code also needs this functionality, so factor this
> out into a new get_sensor_adev_and_name() helper.
...
> +int skl_int3472_get_sensor_adev_and_name(struct device *dev,
> + struct acpi_device **sensor_adev_ret,
> + const char **name_ret)
> +{
> + struct acpi_device *adev = ACPI_COMPANION(dev);
> + struct acpi_device *sensor;
> + int ret = 0;
> +
> + sensor = acpi_dev_get_first_consumer_dev(adev);
> + if (!sensor) {
> + dev_err(dev, "INT3472 seems to have no dependents.\n");
> + return -ENODEV;
> + }
> +
> + *name_ret = devm_kasprintf(dev, GFP_KERNEL, I2C_DEV_NAME_FORMAT,
> + acpi_dev_name(sensor));
> + if (!*name_ret)
> + ret = -ENOMEM;
> +
> + if (ret == 0 && sensor_adev_ret)
> + *sensor_adev_ret = sensor;
> + else
> + acpi_dev_put(sensor);
> +
> + return ret;
The error path is twisted a bit including far staying ret=0 assignment.
Can it be
int ret;
...
*name_ret = devm_kasprintf(dev, GFP_KERNEL, I2C_DEV_NAME_FORMAT,
acpi_dev_name(sensor));
if (!*name_ret) {
acpi_dev_put(sensor);
return -ENOMEM;
}
if (sensor_adev_ret)
*sensor_adev_ret = sensor;
return 0;
?
> +}
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-10-25 11:32 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 9:41 [PATCH v4 00/11] Add support for X86/ACPI camera sensor/PMIC setup with clk and regulator platform data Hans de Goede
2021-10-25 9:41 ` [PATCH v4 01/11] ACPI: delay enumeration of devices with a _DEP pointing to an INT3472 device Hans de Goede
2021-10-27 18:52 ` Rafael J. Wysocki
2021-11-01 11:16 ` Hans de Goede
2021-10-25 9:41 ` [PATCH v4 02/11] i2c: acpi: Use acpi_dev_ready_for_enumeration() helper Hans de Goede
2021-10-27 18:53 ` Rafael J. Wysocki
2021-10-25 9:41 ` [PATCH v4 03/11] platform_data: Add linux/platform_data/tps68470.h file Hans de Goede
2021-10-25 9:41 ` [PATCH v4 04/11] regulator: Introduce tps68470-regulator driver Hans de Goede
2021-10-25 11:11 ` Andy Shevchenko
2021-11-01 10:20 ` Hans de Goede
2021-10-28 16:23 ` Mark Brown
2021-11-09 12:14 ` Sakari Ailus
2021-11-09 12:29 ` Andy Shevchenko
2021-11-11 15:13 ` Hans de Goede
2021-10-25 9:41 ` [PATCH v4 05/11] clk: Introduce clk-tps68470 driver Hans de Goede
2021-10-25 11:24 ` Andy Shevchenko
2021-11-01 10:27 ` Hans de Goede
2021-11-01 10:42 ` Andy Shevchenko
2021-11-01 11:00 ` Hans de Goede
2021-11-01 11:11 ` Andy Shevchenko
2021-10-25 9:41 ` [PATCH v4 06/11] platform/x86: int3472: Enable I2c daisy chain Hans de Goede
2021-10-25 9:41 ` [PATCH v4 07/11] platform/x86: int3472: Split into 2 drivers Hans de Goede
2021-10-25 9:41 ` [PATCH v4 08/11] platform/x86: int3472: Add get_sensor_adev_and_name() helper Hans de Goede
2021-10-25 11:31 ` Andy Shevchenko [this message]
2021-11-01 10:31 ` Hans de Goede
2021-11-01 10:44 ` Andy Shevchenko
2021-11-01 10:46 ` Andy Shevchenko
2021-11-01 10:49 ` Hans de Goede
2021-11-01 10:51 ` Andy Shevchenko
2021-11-01 10:48 ` Hans de Goede
2021-10-25 9:41 ` [PATCH v4 09/11] platform/x86: int3472: Pass tps68470_clk_platform_data to the tps68470-regulator MFD-cell Hans de Goede
2021-10-25 11:33 ` Andy Shevchenko
2021-10-25 9:41 ` [PATCH v4 10/11] platform/x86: int3472: Pass tps68470_regulator_platform_data " Hans de Goede
2021-10-25 11:38 ` Andy Shevchenko
2021-11-01 11:31 ` Hans de Goede
2021-11-01 14:25 ` Andy Shevchenko
2021-10-25 9:41 ` [PATCH v4 11/11] platform/x86: int3472: Deal with probe ordering issues Hans de Goede
2021-10-25 11:40 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeLAW6ZBQYidnD7PDYfAH3A2bq+oMJTru-9OW_t-XS26g@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=broonie@kernel.org \
--cc=djrscally@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lenb@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mchehab@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mturquette@baylibre.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sakari.ailus@linux.intel.com \
--cc=sboyd@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).