* WMI driver duplicate UUID
@ 2022-07-09 1:33 Armin Wolf
2022-07-09 11:21 ` Hans de Goede
0 siblings, 1 reply; 4+ messages in thread
From: Armin Wolf @ 2022-07-09 1:33 UTC (permalink / raw)
To: Hans de Goede; +Cc: Mark Gross, platform-driver-x86
Hello,
while trying to write my own WMI driver, i noticed that the WMI bus driver complained
about duplicated WMI UUIDs. After doing some research, i think i found the reason for
these messages:
Apparently, the ACPI WMI specification by Microsoft treats the _UID of the WMI PnP-device
like a namespace, which means that duplicate UUIDs are llegal if they do not share the same
namespace (= PnP-device).
In my case, only one wmi-bmof device is used, the rest is filtered out despite laying in
a different namespace since they have the same UUID.
Could it be theoretically possible to fix this issue with the WMI bus?
Armin Wolf
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: WMI driver duplicate UUID
2022-07-09 1:33 WMI driver duplicate UUID Armin Wolf
@ 2022-07-09 11:21 ` Hans de Goede
2022-07-09 11:49 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Hans de Goede @ 2022-07-09 11:21 UTC (permalink / raw)
To: Armin Wolf, Limonciello, Mario; +Cc: Mark Gross, platform-driver-x86
Hi Armin,
On 7/9/22 03:33, Armin Wolf wrote:
> Hello,
>
> while trying to write my own WMI driver, i noticed that the WMI bus driver complained
> about duplicated WMI UUIDs. After doing some research, i think i found the reason for
> these messages:
>
> Apparently, the ACPI WMI specification by Microsoft treats the _UID of the WMI PnP-device
> like a namespace, which means that duplicate UUIDs are llegal if they do not share the same
> namespace (= PnP-device).
>
> In my case, only one wmi-bmof device is used, the rest is filtered out despite laying in
> a different namespace since they have the same UUID.
>
> Could it be theoretically possible to fix this issue with the WMI bus?
Yes this has been a known issue for quite a while now, there
is a bugzilla for this here:
https://bugzilla.kernel.org/show_bug.cgi?id=201885
As pointed out there, patches fixing this have been posted
a few years ago already, but they did not get merged.
The patches are here:
https://lkml.org/lkml/2017/12/8/912
https://lkml.org/lkml/2017/12/8/914
There is one review comment which needs to be addressed:
https://lkml.org/lkml/2017/12/9/165
If you can pick these patches up, address the review
comment, test them and then submit a version 2 upstream
I would be happy to merge this into the platform-drivers-x86
tree.
Regards,
Hans
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: WMI driver duplicate UUID
2022-07-09 11:21 ` Hans de Goede
@ 2022-07-09 11:49 ` Andy Shevchenko
2022-07-11 17:29 ` Limonciello, Mario
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2022-07-09 11:49 UTC (permalink / raw)
To: Hans de Goede; +Cc: Armin Wolf, Limonciello, Mario, Mark Gross, Platform Driver
On Sat, Jul 9, 2022 at 1:39 PM Hans de Goede <hdegoede@redhat.com> wrote:
> On 7/9/22 03:33, Armin Wolf wrote:
> > while trying to write my own WMI driver, i noticed that the WMI bus driver complained
> > about duplicated WMI UUIDs. After doing some research, i think i found the reason for
> > these messages:
> >
> > Apparently, the ACPI WMI specification by Microsoft treats the _UID of the WMI PnP-device
> > like a namespace, which means that duplicate UUIDs are llegal if they do not share the same
> > namespace (= PnP-device).
> >
> > In my case, only one wmi-bmof device is used, the rest is filtered out despite laying in
> > a different namespace since they have the same UUID.
> >
> > Could it be theoretically possible to fix this issue with the WMI bus?
>
> Yes this has been a known issue for quite a while now, there
> is a bugzilla for this here:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=201885
>
> As pointed out there, patches fixing this have been posted
> a few years ago already, but they did not get merged.
>
> The patches are here:
>
> https://lkml.org/lkml/2017/12/8/912
> https://lkml.org/lkml/2017/12/8/914
>
> There is one review comment which needs to be addressed:
>
> https://lkml.org/lkml/2017/12/9/165
>
> If you can pick these patches up, address the review
> comment, test them and then submit a version 2 upstream
> I would be happy to merge this into the platform-drivers-x86
> tree.
https://lore.kernel.org/all/1512786861-1014-1-git-send-email-mario.limonciello@dell.com/
This way it's easier to handle with `b4`
b4 am -s https://lore.kernel.org/all/1512786861-1014-1-git-send-email-mario.limonciello@dell.com/
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: WMI driver duplicate UUID
2022-07-09 11:49 ` Andy Shevchenko
@ 2022-07-11 17:29 ` Limonciello, Mario
0 siblings, 0 replies; 4+ messages in thread
From: Limonciello, Mario @ 2022-07-11 17:29 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede; +Cc: Armin Wolf, Mark Gross, Platform Driver
[Public]
> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: Saturday, July 9, 2022 06:49
> To: Hans de Goede <hdegoede@redhat.com>
> Cc: Armin Wolf <W_Armin@gmx.de>; Limonciello, Mario
> <Mario.Limonciello@amd.com>; Mark Gross <markgross@kernel.org>;
> Platform Driver <platform-driver-x86@vger.kernel.org>
> Subject: Re: WMI driver duplicate UUID
>
> On Sat, Jul 9, 2022 at 1:39 PM Hans de Goede <hdegoede@redhat.com>
> wrote:
> > On 7/9/22 03:33, Armin Wolf wrote:
>
> > > while trying to write my own WMI driver, i noticed that the WMI bus
> driver complained
> > > about duplicated WMI UUIDs. After doing some research, i think i found
> the reason for
> > > these messages:
> > >
> > > Apparently, the ACPI WMI specification by Microsoft treats the _UID of
> the WMI PnP-device
> > > like a namespace, which means that duplicate UUIDs are llegal if they do
> not share the same
> > > namespace (= PnP-device).
> > >
> > > In my case, only one wmi-bmof device is used, the rest is filtered out
> despite laying in
> > > a different namespace since they have the same UUID.
> > >
> > > Could it be theoretically possible to fix this issue with the WMI bus?
> >
> > Yes this has been a known issue for quite a while now, there
> > is a bugzilla for this here:
> >
> >
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugz
> illa.kernel.org%2Fshow_bug.cgi%3Fid%3D201885&data=05%7C01%7CM
> ario.Limonciello%40amd.com%7C68ec85e0fe614746fd3208da61a11fc3%7C3d
> d8961fe4884e608e11a82d994e183d%7C0%7C0%7C637929641896425658%7CU
> nknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI
> 6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=6uVZ3KvXGg
> R4AoW9r%2B%2FGN%2BJtdzlQnVtsxp0v5DGsVEY%3D&reserved=0
> >
> > As pointed out there, patches fixing this have been posted
> > a few years ago already, but they did not get merged.
> >
> > The patches are here:
> >
> >
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flkml.
> org%2Flkml%2F2017%2F12%2F8%2F912&data=05%7C01%7CMario.Limo
> nciello%40amd.com%7C68ec85e0fe614746fd3208da61a11fc3%7C3dd8961fe4
> 884e608e11a82d994e183d%7C0%7C0%7C637929641896425658%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=GlS4xGplKlj6IBbrySl
> 3Pm55CNKsMr4meOyAG3%2B1%2Brw%3D&reserved=0
> >
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flkml.
> org%2Flkml%2F2017%2F12%2F8%2F914&data=05%7C01%7CMario.Limo
> nciello%40amd.com%7C68ec85e0fe614746fd3208da61a11fc3%7C3dd8961fe4
> 884e608e11a82d994e183d%7C0%7C0%7C637929641896425658%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=16UieLiYmcRdsB0E
> P%2B2ftVQ5MrrnzkpF6rCAw%2BZkBX8%3D&reserved=0
> >
> > There is one review comment which needs to be addressed:
> >
> >
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flkml.
> org%2Flkml%2F2017%2F12%2F9%2F165&data=05%7C01%7CMario.Limo
> nciello%40amd.com%7C68ec85e0fe614746fd3208da61a11fc3%7C3dd8961fe4
> 884e608e11a82d994e183d%7C0%7C0%7C637929641896425658%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=K0L8i9lsTyl%2FT3c5
> RNBWFc4kjbtWgzPNUuB5ew7EYGs%3D&reserved=0
> >
> > If you can pick these patches up, address the review
> > comment, test them and then submit a version 2 upstream
> > I would be happy to merge this into the platform-drivers-x86
> > tree.
>
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.
> kernel.org%2Fall%2F1512786861-1014-1-git-send-email-
> mario.limonciello%40dell.com%2F&data=05%7C01%7CMario.Limonciello
> %40amd.com%7C68ec85e0fe614746fd3208da61a11fc3%7C3dd8961fe4884e60
> 8e11a82d994e183d%7C0%7C0%7C637929641896425658%7CUnknown%7CTW
> FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJX
> VCI6Mn0%3D%7C3000%7C%7C%7C&sdata=TjNdUrnI3nndRIkRpDkReuE
> VGQeVBeMuLtO%2FrK3yGdM%3D&reserved=0
>
> This way it's easier to handle with `b4`
>
> b4 am -s
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.
> kernel.org%2Fall%2F1512786861-1014-1-git-send-email-
> mario.limonciello%40dell.com%2F&data=05%7C01%7CMario.Limonciello
> %40amd.com%7C68ec85e0fe614746fd3208da61a11fc3%7C3dd8961fe4884e60
> 8e11a82d994e183d%7C0%7C0%7C637929641896425658%7CUnknown%7CTW
> FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJX
> VCI6Mn0%3D%7C3000%7C%7C%7C&sdata=TjNdUrnI3nndRIkRpDkReuE
> VGQeVBeMuLtO%2FrK3yGdM%3D&reserved=0
>
> --
> With Best Regards,
> Andy Shevchenko
I forgot all about those patches, blast from the past. Yes, please pick them up
and carry the torch to fix this issue.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-11 17:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-09 1:33 WMI driver duplicate UUID Armin Wolf
2022-07-09 11:21 ` Hans de Goede
2022-07-09 11:49 ` Andy Shevchenko
2022-07-11 17:29 ` Limonciello, Mario
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).