platform-driver-x86.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] platform/x86: amd-pmc: Make CONFIG_AMD_PMC depend on RTC_CLASS
@ 2021-11-02 15:32 Hans de Goede
  2021-11-02 15:34 ` Limonciello, Mario
  0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2021-11-02 15:32 UTC (permalink / raw)
  To: Mark Gross, Andy Shevchenko
  Cc: Hans de Goede, platform-driver-x86, Mario Limonciello, Randy Dunlap

Since the "Add special handling for timer based S0i3 wakeup" changes
the amd-pmc code now relies on symbols from the RTC-class code,
add a dependency for this to Kconfig.

Fixes: 59348401ebed ("platform/x86: amd-pmc: Add special handling for timer based S0i3 wakeup")
Cc: Mario Limonciello <mario.limonciello@amd.com>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/platform/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index d4c079f4afc6..7400bc5da5be 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -185,7 +185,7 @@ config ACER_WMI
 
 config AMD_PMC
 	tristate "AMD SoC PMC driver"
-	depends on ACPI && PCI
+	depends on ACPI && PCI && RTC_CLASS
 	help
 	  The driver provides support for AMD Power Management Controller
 	  primarily responsible for S2Idle transactions that are driven from
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH] platform/x86: amd-pmc: Make CONFIG_AMD_PMC depend on RTC_CLASS
  2021-11-02 15:32 [PATCH] platform/x86: amd-pmc: Make CONFIG_AMD_PMC depend on RTC_CLASS Hans de Goede
@ 2021-11-02 15:34 ` Limonciello, Mario
  0 siblings, 0 replies; 2+ messages in thread
From: Limonciello, Mario @ 2021-11-02 15:34 UTC (permalink / raw)
  To: Hans de Goede, Mark Gross, Andy Shevchenko
  Cc: platform-driver-x86, Randy Dunlap

[Public]



> -----Original Message-----
> From: Hans de Goede <hdegoede@redhat.com>
> Sent: Tuesday, November 2, 2021 10:33
> To: Mark Gross <markgross@kernel.org>; Andy Shevchenko
> <andy@infradead.org>
> Cc: Hans de Goede <hdegoede@redhat.com>; platform-driver-
> x86@vger.kernel.org; Limonciello, Mario <Mario.Limonciello@amd.com>;
> Randy Dunlap <rdunlap@infradead.org>
> Subject: [PATCH] platform/x86: amd-pmc: Make CONFIG_AMD_PMC depend on
> RTC_CLASS
> 
> Since the "Add special handling for timer based S0i3 wakeup" changes
> the amd-pmc code now relies on symbols from the RTC-class code,
> add a dependency for this to Kconfig.
> 
> Fixes: 59348401ebed ("platform/x86: amd-pmc: Add special handling for timer
> based S0i3 wakeup")
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Thanks!

Acked-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>  drivers/platform/x86/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index d4c079f4afc6..7400bc5da5be 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -185,7 +185,7 @@ config ACER_WMI
> 
>  config AMD_PMC
>  	tristate "AMD SoC PMC driver"
> -	depends on ACPI && PCI
> +	depends on ACPI && PCI && RTC_CLASS
>  	help
>  	  The driver provides support for AMD Power Management Controller
>  	  primarily responsible for S2Idle transactions that are driven from
> --
> 2.31.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-02 15:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-02 15:32 [PATCH] platform/x86: amd-pmc: Make CONFIG_AMD_PMC depend on RTC_CLASS Hans de Goede
2021-11-02 15:34 ` Limonciello, Mario

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).