From: "Yuan, Perry" <Perry.Yuan@dell.com>
To: Hans de Goede <hdegoede@redhat.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"pobrn@protonmail.com" <pobrn@protonmail.com>,
"oder_chiou@realtek.com" <oder_chiou@realtek.com>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.com" <tiwai@suse.com>,
"mgross@linux.intel.com" <mgross@linux.intel.com>,
"Limonciello, Mario" <Mario.Limonciello@dell.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>
Subject: RE: [PATCH v5 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy
Date: Thu, 25 Mar 2021 07:52:15 +0000 [thread overview]
Message-ID: <SJ0PR19MB4528ED97AA4A5D0821A3E68584629@SJ0PR19MB4528.namprd19.prod.outlook.com> (raw)
In-Reply-To: <c61b975a-a771-eb63-5232-2da184ca95fe@redhat.com>
Hi Hans.
> -----Original Message-----
> From: Hans de Goede <hdegoede@redhat.com>
> Sent: Wednesday, March 24, 2021 3:40 AM
> To: Pierre-Louis Bossart; Yuan, Perry; pobrn@protonmail.com;
> oder_chiou@realtek.com; perex@perex.cz; tiwai@suse.com;
> mgross@linux.intel.com; Limonciello, Mario
> Cc: alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org;
> lgirdwood@gmail.com; platform-driver-x86@vger.kernel.org;
> broonie@kernel.org
> Subject: Re: [PATCH v5 1/2] platform/x86: dell-privacy: Add support for Dell
> hardware privacy
>
>
> [EXTERNAL EMAIL]
>
> Hi,
>
> On 3/23/21 7:57 PM, Pierre-Louis Bossart wrote:
> > Minor comments below.
>
> <snip<
>
> >> +int __init dell_privacy_acpi_init(void)
> >
> > is the __init necessary? You call this routine from another which already has
> this qualifier.
>
> Yes this is necessary, all functions which are only used during module_load /
> from the module's init function must be marked as __init so that the kernel
> can unload them after module loading is done.
>
> I do wonder if this one should not be static though (I've not looked at this
> patch in detail yet).
>
> >
> >> +{
> >> + int err;
> >> + struct platform_device *pdev;
> >> +
> >> + if (!wmi_has_guid(DELL_PRIVACY_GUID))
> >> + return -ENODEV;
> >> +
> >> + privacy_acpi = kzalloc(sizeof(*privacy_acpi), GFP_KERNEL);
> >> + if (!privacy_acpi)
> >> + return -ENOMEM;
> >> +
> >> + err = platform_driver_register(&dell_privacy_platform_drv);
> >> + if (err)
> >> + goto pdrv_err;
> >> +
> >> + pdev = platform_device_register_simple(
> >> + PRIVACY_PLATFORM_NAME, PLATFORM_DEVID_NONE, NULL, 0);
> >> + if (IS_ERR(pdev)) {
> >> + err = PTR_ERR(pdev);
> >> + goto pdev_err;
> >> + }
> >> +
> >> + return 0;
> >> +
> >> +pdev_err:
> >> + platform_device_unregister(pdev);
> >> +pdrv_err:
> >> + kfree(privacy_acpi);
> >> + return err;
> >> +}
> >> +
> >> +void __exit dell_privacy_acpi_exit(void)
> >
> > is the __exit required here?
>
> Idem. Also static ?
>
> Regards,
>
> Hans
>
If adding static to the function, I will be worried about that the init and exit cannot be called by another file .
>
>
> >
> >> +{
> >> + struct platform_device *pdev =
> >> +to_platform_device(privacy_acpi->dev);
> >> +
> >> + platform_device_unregister(pdev);
> >> + platform_driver_unregister(&dell_privacy_platform_drv);
> >> + kfree(privacy_acpi);
> >> +}
> >> +
> >> +MODULE_AUTHOR("Perry Yuan <perry_yuan@dell.com>");
> >> +MODULE_DESCRIPTION("DELL Privacy ACPI Driver");
> >> +MODULE_LICENSE("GPL");
> >
> >
next prev parent reply other threads:[~2021-03-25 7:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 9:38 [PATCH v5 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy Perry Yuan
2021-03-22 17:15 ` Randy Dunlap
2021-03-23 6:19 ` Yuan, Perry
2021-03-23 18:57 ` Pierre-Louis Bossart
2021-03-23 19:40 ` Hans de Goede
2021-03-25 7:52 ` Yuan, Perry [this message]
2021-03-25 8:23 ` Hans de Goede
2021-03-27 3:39 ` Perry Yuan
2021-03-24 11:19 ` Hans de Goede
2021-03-24 11:39 ` Hans de Goede
2021-03-28 14:32 ` Perry Yuan
2021-03-25 14:53 ` Yuan, Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR19MB4528ED97AA4A5D0821A3E68584629@SJ0PR19MB4528.namprd19.prod.outlook.com \
--to=perry.yuan@dell.com \
--cc=Mario.Limonciello@dell.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pobrn@protonmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).