From: Randy Dunlap <rdunlap@infradead.org>
To: Perry Yuan <Perry.Yuan@dell.com>,
pobrn@protonmail.com, pierre-louis.bossart@linux.intel.com,
oder_chiou@realtek.com, perex@perex.cz, tiwai@suse.com,
hdegoede@redhat.com, mgross@linux.intel.com,
Mario.Limonciello@dell.com
Cc: lgirdwood@gmail.com, broonie@kernel.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v5 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy
Date: Mon, 22 Mar 2021 10:15:07 -0700 [thread overview]
Message-ID: <a1bdec21-efd9-ebf5-1b45-c0a364e0914c@infradead.org> (raw)
In-Reply-To: <20210322093841.11840-1-Perry_Yuan@Dell.com>
On 3/22/21 2:38 AM, Perry Yuan wrote:
> From: Perry Yuan <perry_yuan@dell.com>
>
> diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/dell/Kconfig
> index e0a55337f51a..0e0f1eb35bd6 100644
> --- a/drivers/platform/x86/dell/Kconfig
> +++ b/drivers/platform/x86/dell/Kconfig
> @@ -204,4 +204,20 @@ config DELL_WMI_SYSMAN
> To compile this driver as a module, choose M here: the module will
> be called dell-wmi-sysman.
>
> +config DELL_PRIVACY
> + tristate "Dell Hardware Privacy Support"
> + depends on ACPI
> + depends on ACPI_WMI
> + depends on INPUT
> + depends on DELL_LAPTOP
> + depends on LEDS_TRIGGER_AUDIO
> + select DELL_WMI
> + help
> + This driver provides support for the "Dell Hardware Privacy" feature
> + of Dell laptops.
> + Support for a micmute and camera mute privacy will be provided as
better:
are provided as
> + hardware button Ctrl+F4 and Ctrl+F9 hotkey.
Does that say that Ctrl+F4 is a hardware button
and that Ctrl+F9 is a hotkey?
If so, what's the difference? and why? Are they different
hardware implementations? Does the user care?
> +
> + To compile this driver as a module, choose M here: the module will
> + be called dell_privacy.
> endif # X86_PLATFORM_DRIVERS_DELL
thanks.
--
~Randy
next prev parent reply other threads:[~2021-03-22 17:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 9:38 [PATCH v5 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy Perry Yuan
2021-03-22 17:15 ` Randy Dunlap [this message]
2021-03-23 6:19 ` Yuan, Perry
2021-03-23 18:57 ` Pierre-Louis Bossart
2021-03-23 19:40 ` Hans de Goede
2021-03-25 7:52 ` Yuan, Perry
2021-03-25 8:23 ` Hans de Goede
2021-03-27 3:39 ` Perry Yuan
2021-03-24 11:19 ` Hans de Goede
2021-03-24 11:39 ` Hans de Goede
2021-03-28 14:32 ` Perry Yuan
2021-03-25 14:53 ` Yuan, Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1bdec21-efd9-ebf5-1b45-c0a364e0914c@infradead.org \
--to=rdunlap@infradead.org \
--cc=Mario.Limonciello@dell.com \
--cc=Perry.Yuan@dell.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pobrn@protonmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).