From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
Eric Piel <eric.piel@tremplin-utc.net>,
Mark Gross <mgross@linux.intel.com>
Subject: Re: [RFT, PATCH v1 1/1] platform/x86: hp_accel: Convert to be a platform driver
Date: Mon, 23 Aug 2021 12:33:18 +0300 [thread overview]
Message-ID: <YSNrXkDpG0k3eTgd@smile.fi.intel.com> (raw)
In-Reply-To: <48332796-1b9a-c897-c695-e66b116386be@redhat.com>
On Fri, Aug 06, 2021 at 03:42:40PM +0200, Hans de Goede wrote:
> Hi,
>
> On 8/3/21 10:08 PM, Andy Shevchenko wrote:
> > ACPI core in conjunction with platform driver core provides
> > an infrastructure to enumerate ACPI devices. Use it in order
> > to remove a lot of boilerplate code.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >
> > Not sure what buys us to run _INI on PM calls. It's against the spec AFAICT.
> > In any case ACPICA runs _INI as per specification when devices are
> > instantiated.
>
> _INI used to also be ran on resume for some reason, but that was recently
> changed.
>
> You're right that calling it is no longer necessary now that we no longer
> do that.
>
> But the changes related to this are really separate from the platform
> driver conversion, please split this into 2 patches.
>
> Also for the next version please Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
> and ask him to test, I think he has access to hardware to test this.
v2 has been sent.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-08-23 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 20:08 [RFT, PATCH v1 1/1] platform/x86: hp_accel: Convert to be a platform driver Andy Shevchenko
2021-08-06 13:42 ` Hans de Goede
2021-08-23 9:33 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSNrXkDpG0k3eTgd@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=eric.piel@tremplin-utc.net \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).