From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Mark Brown <broonie@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
Daniel Scally <djrscally@gmail.com>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Gross <mgross@linux.intel.com>,
Maximilian Luz <luzmaximilian@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Sakari Ailus <sakari.ailus@iki.fi>
Subject: Re: [RFC PATCH v2 1/3] regulator: core: Add regulator_lookup_list
Date: Wed, 25 Aug 2021 18:42:30 +0300 [thread overview]
Message-ID: <YSZk5tyAxZoosXS3@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210825152735.GJ5186@sirena.org.uk>
On Wed, Aug 25, 2021 at 04:27:35PM +0100, Mark Brown wrote:
> On Wed, Aug 25, 2021 at 04:48:15PM +0200, Hans de Goede wrote:
>
> > Daniel, I believe that what Mark wants here is something similar to what
> > we already do for the 5v boost converter regulator in the TI bq24190 charger
> > chip used on some Cherry Trail devices.
>
> Yeah, that or something like a generalized version of it which lets a
> separate quirk file like they seem to have register the data to insert -
> I'd be happy enough with the simple thing too given that it's not
> visible to anything, or with DMI quirks in the regulator driver too for
> that matter if it's just one or two platforms but there do seem to be
> rather a lot of these platforms which need quirks.
Let's also remember that we have to handle not just regulators, but also
GPIOs and clocks. And I'm pretty sure there will be more. We could have
a mechanism specific to the tps68470 driver to pass platform data from
the board file to the driver, and replicate that mechanism in different
drivers (for other regulators, clocks and GPIOs), but I really would
like to avoid splitting the DMI-conditioned platform data in those
drivers directly. I'd like to store all the init data for a given
platform in a single "board" file.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-08-25 15:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 23:06 [RFC PATCH v2 0/3] Add regulator_lookup_list and API Daniel Scally
2021-08-24 23:06 ` [RFC PATCH v2 1/3] regulator: core: Add regulator_lookup_list Daniel Scally
2021-08-25 10:33 ` Mark Brown
2021-08-25 11:10 ` Andy Shevchenko
2021-08-25 11:30 ` Mark Brown
2021-08-25 12:26 ` Andy Shevchenko
2021-08-25 13:11 ` Mark Brown
2021-08-25 13:59 ` Laurent Pinchart
2021-08-25 14:03 ` Laurent Pinchart
2021-08-25 14:33 ` Andy Shevchenko
2021-08-25 14:12 ` Daniel Scally
2021-08-25 14:22 ` Laurent Pinchart
2021-08-25 14:52 ` Mark Brown
2021-08-25 22:09 ` Daniel Scally
2021-08-26 12:40 ` Mark Brown
2021-08-25 14:41 ` Mark Brown
2021-08-25 14:48 ` Hans de Goede
2021-08-25 15:27 ` Mark Brown
2021-08-25 15:42 ` Laurent Pinchart [this message]
2021-08-25 16:13 ` Mark Brown
2021-08-25 20:25 ` Hans de Goede
2021-08-25 20:40 ` Laurent Pinchart
2021-08-25 21:24 ` Daniel Scally
2021-08-25 21:17 ` Daniel Scally
2021-08-24 23:06 ` [RFC PATCH v2 2/3] Documentation: power: Document regulator_lookup_list Daniel Scally
2021-08-24 23:06 ` [RFC PATCH v2 3/3] platform/surface: Add Surface Go 2 board file Daniel Scally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSZk5tyAxZoosXS3@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=broonie@kernel.org \
--cc=djrscally@gmail.com \
--cc=hdegoede@redhat.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).