* [PATCH v1] platform/x86: intel_scu_wdt: Drop mistakenly added const
@ 2021-02-04 15:05 Andy Shevchenko
2021-02-04 16:24 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2021-02-04 15:05 UTC (permalink / raw)
To: Hans de Goede, platform-driver-x86, Mark Gross
Cc: Andy Shevchenko, Stephen Rothwell
Neither original structure nor platform_data is declared with const.
Drop mistakenly added const when assing platform_data.
Fixes: a507e5d90f3d ("platform/x86: intel_scu_wdt: Get rid of custom x86 model comparison")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/platform/x86/intel_scu_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel_scu_wdt.c b/drivers/platform/x86/intel_scu_wdt.c
index 85ee85ca2215..c2479777a1d6 100644
--- a/drivers/platform/x86/intel_scu_wdt.c
+++ b/drivers/platform/x86/intel_scu_wdt.c
@@ -63,7 +63,7 @@ static int __init register_mid_wdt(void)
if (!id)
return -ENODEV;
- wdt_dev.dev.platform_data = (const struct intel_mid_wdt_pdata *)id->driver_data;
+ wdt_dev.dev.platform_data = (struct intel_mid_wdt_pdata *)id->driver_data;
return platform_device_register(&wdt_dev);
}
arch_initcall(register_mid_wdt);
--
2.30.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] platform/x86: intel_scu_wdt: Drop mistakenly added const
2021-02-04 15:05 [PATCH v1] platform/x86: intel_scu_wdt: Drop mistakenly added const Andy Shevchenko
@ 2021-02-04 16:24 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-02-04 16:24 UTC (permalink / raw)
To: Andy Shevchenko, platform-driver-x86, Mark Gross; +Cc: Stephen Rothwell
Hi,
On 2/4/21 4:05 PM, Andy Shevchenko wrote:
> Neither original structure nor platform_data is declared with const.
> Drop mistakenly added const when assing platform_data.
>
> Fixes: a507e5d90f3d ("platform/x86: intel_scu_wdt: Get rid of custom x86 model comparison")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/intel_scu_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_scu_wdt.c b/drivers/platform/x86/intel_scu_wdt.c
> index 85ee85ca2215..c2479777a1d6 100644
> --- a/drivers/platform/x86/intel_scu_wdt.c
> +++ b/drivers/platform/x86/intel_scu_wdt.c
> @@ -63,7 +63,7 @@ static int __init register_mid_wdt(void)
> if (!id)
> return -ENODEV;
>
> - wdt_dev.dev.platform_data = (const struct intel_mid_wdt_pdata *)id->driver_data;
> + wdt_dev.dev.platform_data = (struct intel_mid_wdt_pdata *)id->driver_data;
> return platform_device_register(&wdt_dev);
> }
> arch_initcall(register_mid_wdt);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-04 16:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-04 15:05 [PATCH v1] platform/x86: intel_scu_wdt: Drop mistakenly added const Andy Shevchenko
2021-02-04 16:24 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).