* [PATCH] platform/x86/amd/pmf: Fix undefined reference to platform_profile
@ 2022-08-19 8:38 Shyam Sundar S K
2022-08-19 22:41 ` Randy Dunlap
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Shyam Sundar S K @ 2022-08-19 8:38 UTC (permalink / raw)
To: hdegoede, markgross
Cc: platform-driver-x86, Patil.Reddy, Shyam Sundar S K, Randy Dunlap
Its reported that amd-pmf driver when built with config which does not
have ACPI_PLATFORM_PROFILE set/enabled throws a undefined references to
symbols used.
---
ld: vmlinux.o: in function `amd_pmf_init_sps':
/work/lnx/next/linux-next-20220818/X64/../drivers/platform/x86/amd/pmf/sps.c:132: undefined reference to `platform_profile_register'
ld: vmlinux.o: in function `amd_pmf_deinit_sps':
/work/lnx/next/linux-next-20220818/X64/../drivers/platform/x86/amd/pmf/sps.c:142: undefined reference to `platform_profile_remove'
---
Fix it by adding a "select" to the Kconfig.
Fixes: da5ce22df5fe ("platform/x86/amd/pmf: Add support for PMF core layer")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
---
Based on "review-hans" branch.
drivers/platform/x86/amd/pmf/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/amd/pmf/Kconfig b/drivers/platform/x86/amd/pmf/Kconfig
index e65ffa52229b..c375498c4071 100644
--- a/drivers/platform/x86/amd/pmf/Kconfig
+++ b/drivers/platform/x86/amd/pmf/Kconfig
@@ -6,6 +6,7 @@
config AMD_PMF
tristate "AMD Platform Management Framework"
depends on ACPI && PCI
+ select ACPI_PLATFORM_PROFILE
help
This driver provides support for the AMD Platform Management Framework.
The goal is to enhance end user experience by making AMD PCs smarter,
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/x86/amd/pmf: Fix undefined reference to platform_profile
2022-08-19 8:38 [PATCH] platform/x86/amd/pmf: Fix undefined reference to platform_profile Shyam Sundar S K
@ 2022-08-19 22:41 ` Randy Dunlap
2022-08-24 8:31 ` Hans de Goede
2022-08-24 8:34 ` Hans de Goede
2 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2022-08-19 22:41 UTC (permalink / raw)
To: Shyam Sundar S K, hdegoede, markgross; +Cc: platform-driver-x86, Patil.Reddy
On 8/19/22 01:38, Shyam Sundar S K wrote:
> Its reported that amd-pmf driver when built with config which does not
> have ACPI_PLATFORM_PROFILE set/enabled throws a undefined references to
> symbols used.
>
> ---
> ld: vmlinux.o: in function `amd_pmf_init_sps':
> /work/lnx/next/linux-next-20220818/X64/../drivers/platform/x86/amd/pmf/sps.c:132: undefined reference to `platform_profile_register'
> ld: vmlinux.o: in function `amd_pmf_deinit_sps':
> /work/lnx/next/linux-next-20220818/X64/../drivers/platform/x86/amd/pmf/sps.c:142: undefined reference to `platform_profile_remove'
> ---
>
> Fix it by adding a "select" to the Kconfig.
>
> Fixes: da5ce22df5fe ("platform/x86/amd/pmf: Add support for PMF core layer")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
>
> Based on "review-hans" branch.
>
> drivers/platform/x86/amd/pmf/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/amd/pmf/Kconfig b/drivers/platform/x86/amd/pmf/Kconfig
> index e65ffa52229b..c375498c4071 100644
> --- a/drivers/platform/x86/amd/pmf/Kconfig
> +++ b/drivers/platform/x86/amd/pmf/Kconfig
> @@ -6,6 +6,7 @@
> config AMD_PMF
> tristate "AMD Platform Management Framework"
> depends on ACPI && PCI
> + select ACPI_PLATFORM_PROFILE
> help
> This driver provides support for the AMD Platform Management Framework.
> The goal is to enhance end user experience by making AMD PCs smarter,
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/x86/amd/pmf: Fix undefined reference to platform_profile
2022-08-19 8:38 [PATCH] platform/x86/amd/pmf: Fix undefined reference to platform_profile Shyam Sundar S K
2022-08-19 22:41 ` Randy Dunlap
@ 2022-08-24 8:31 ` Hans de Goede
2022-08-24 8:34 ` Hans de Goede
2 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2022-08-24 8:31 UTC (permalink / raw)
To: Shyam Sundar S K, markgross
Cc: platform-driver-x86, Patil.Reddy, Randy Dunlap
Hi,
On 8/19/22 10:38, Shyam Sundar S K wrote:
> Its reported that amd-pmf driver when built with config which does not
> have ACPI_PLATFORM_PROFILE set/enabled throws a undefined references to
> symbols used.
>
> ---
> ld: vmlinux.o: in function `amd_pmf_init_sps':
> /work/lnx/next/linux-next-20220818/X64/../drivers/platform/x86/amd/pmf/sps.c:132: undefined reference to `platform_profile_register'
> ld: vmlinux.o: in function `amd_pmf_deinit_sps':
> /work/lnx/next/linux-next-20220818/X64/../drivers/platform/x86/amd/pmf/sps.c:142: undefined reference to `platform_profile_remove'
> ---
>
> Fix it by adding a "select" to the Kconfig.
>
> Fixes: da5ce22df5fe ("platform/x86/amd/pmf: Add support for PMF core layer")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Thank you for your patch, I've applied this patch to
the platform-drivers-x86-amd-pmf branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=platform-drivers-x86-amd-pmf
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
>
> Based on "review-hans" branch.
>
> drivers/platform/x86/amd/pmf/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/amd/pmf/Kconfig b/drivers/platform/x86/amd/pmf/Kconfig
> index e65ffa52229b..c375498c4071 100644
> --- a/drivers/platform/x86/amd/pmf/Kconfig
> +++ b/drivers/platform/x86/amd/pmf/Kconfig
> @@ -6,6 +6,7 @@
> config AMD_PMF
> tristate "AMD Platform Management Framework"
> depends on ACPI && PCI
> + select ACPI_PLATFORM_PROFILE
> help
> This driver provides support for the AMD Platform Management Framework.
> The goal is to enhance end user experience by making AMD PCs smarter,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/x86/amd/pmf: Fix undefined reference to platform_profile
2022-08-19 8:38 [PATCH] platform/x86/amd/pmf: Fix undefined reference to platform_profile Shyam Sundar S K
2022-08-19 22:41 ` Randy Dunlap
2022-08-24 8:31 ` Hans de Goede
@ 2022-08-24 8:34 ` Hans de Goede
2 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2022-08-24 8:34 UTC (permalink / raw)
To: Shyam Sundar S K, markgross
Cc: platform-driver-x86, Patil.Reddy, Randy Dunlap
Hi,
On 8/19/22 10:38, Shyam Sundar S K wrote:
> Its reported that amd-pmf driver when built with config which does not
> have ACPI_PLATFORM_PROFILE set/enabled throws a undefined references to
> symbols used.
>
> ---
p.s.
I had to manual fixup the commit message because of the use of "---"
here, this is a so called cut line normally used for remarks at
the end of the commit msg which are to be disregarded when applying
the patch.
So this use causes the commit message to end here (without e.g.
your S-o-b). I just noticed you've done the same for quoting
the clang warnings in the other patch.
In the future please dont't use "---" in the middle of
the commit message.
Thanks & Regards,
Hans
> ld: vmlinux.o: in function `amd_pmf_init_sps':
> /work/lnx/next/linux-next-20220818/X64/../drivers/platform/x86/amd/pmf/sps.c:132: undefined reference to `platform_profile_register'
> ld: vmlinux.o: in function `amd_pmf_deinit_sps':
> /work/lnx/next/linux-next-20220818/X64/../drivers/platform/x86/amd/pmf/sps.c:142: undefined reference to `platform_profile_remove'
> ---
>
> Fix it by adding a "select" to the Kconfig.
>
> Fixes: da5ce22df5fe ("platform/x86/amd/pmf: Add support for PMF core layer")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> ---
>
> Based on "review-hans" branch.
>
> drivers/platform/x86/amd/pmf/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/amd/pmf/Kconfig b/drivers/platform/x86/amd/pmf/Kconfig
> index e65ffa52229b..c375498c4071 100644
> --- a/drivers/platform/x86/amd/pmf/Kconfig
> +++ b/drivers/platform/x86/amd/pmf/Kconfig
> @@ -6,6 +6,7 @@
> config AMD_PMF
> tristate "AMD Platform Management Framework"
> depends on ACPI && PCI
> + select ACPI_PLATFORM_PROFILE
> help
> This driver provides support for the AMD Platform Management Framework.
> The goal is to enhance end user experience by making AMD PCs smarter,
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-24 8:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-19 8:38 [PATCH] platform/x86/amd/pmf: Fix undefined reference to platform_profile Shyam Sundar S K
2022-08-19 22:41 ` Randy Dunlap
2022-08-24 8:31 ` Hans de Goede
2022-08-24 8:34 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).