From: Daniel Dadap <ddadap@nvidia.com>
To: "Thomas Weißschuh" <thomas@t-8ch.de>
Cc: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Platform Driver" <platform-driver-x86@vger.kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
mario.limonciello@outlook.com,
"Andy Shevchenko" <andy@infradead.org>,
"Darren Hart" <dvhart@infradead.org>,
"Aaron Plattner" <aplattner@nvidia.com>,
"Barnabás Pőcze" <pobrn@protonmail.com>
Subject: Re: [PATCH v3] platform/x86: Add driver for ACPI WMAA EC-based backlight control
Date: Wed, 25 Aug 2021 17:28:42 -0500 [thread overview]
Message-ID: <adf55c8d-4552-f7a9-c5a7-53dc1aa0483d@nvidia.com> (raw)
In-Reply-To: <2f969bf5-0c54-41fd-ab55-108edc0dd462@t-8ch.de>
On 8/25/21 5:06 PM, Thomas Weißschuh wrote:
> On Mi, 2021-08-25T11:47-0500, Daniel Dadap wrote:
>>> +static const struct wmi_device_id wmaa_backlight_wmi_id_table[] = {
>>> + { .guid_string = WMAA_WMI_GUID },
>>> + { },
>>>> +MODULE_ALIAS("wmi:"WMAA_WMI_GUID);
>>> Can you move this closer to GUID? But I'm not sure what is the
>>> preferred style. Hans?
>>
>> I'll do whatever is most stylistically preferred.
>>
> This could also be expressed as, which is presumably the nicer way:
>
> MODULE_DEVICE_TABLE(wmi, wmaa_backlight_wmi_id_table);
Okay, thanks. In the meantime I've moved the declaration of this table
and the #define for the WMAA_WMI_GUID macro down to the end of the file,
right before the pile of MODULE_* macros where we also use WMAA_WMI_GUID
for the modalias, but if there's a more preferred style here just let me
know.
next prev parent reply other threads:[~2021-08-25 22:28 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <DM6PR19MB2636AB267CD321DE40EF324AFA730@DM6PR19MB2636.namprd19.prod.outlook.com>
[not found] ` <20200731202154.11382-1-ddadap@nvidia.com>
[not found] ` <20200731202154.11382-2-ddadap@nvidia.com>
2020-11-10 9:34 ` [PATCH v2 2/2] platform/x86: wmi: fail wmi_driver_register when no GUID is found Hans de Goede
2020-11-12 18:54 ` Daniel Dadap
2021-08-24 22:04 ` [PATCH v3] platform/x86: Add driver for ACPI WMAA EC-based backlight control Daniel Dadap
2021-08-24 22:47 ` Barnabás Pőcze
2021-08-25 16:36 ` Daniel Dadap
2021-08-25 22:26 ` Daniel Dadap
2021-08-27 16:47 ` Daniel Dadap
2021-08-27 17:12 ` Daniel Dadap
2021-08-25 9:05 ` Andy Shevchenko
2021-08-25 16:47 ` Daniel Dadap
2021-08-25 22:06 ` Thomas Weißschuh
2021-08-25 22:28 ` Daniel Dadap [this message]
2021-08-26 13:35 ` Andy Shevchenko
2021-08-26 15:39 ` Daniel Dadap
2021-08-31 22:49 ` [PATCH v4] " Daniel Dadap
2021-09-01 9:25 ` Thomas Weißschuh
2021-09-02 2:12 ` Daniel Dadap
2021-09-02 10:19 ` Thomas Weißschuh
2021-09-02 20:15 ` Daniel Dadap
2021-09-02 20:31 ` Hans de Goede
2021-09-02 21:47 ` [PATCH v5] " Daniel Dadap
2021-09-02 23:20 ` Thomas Weißschuh
2021-09-03 0:22 ` Daniel Dadap
2021-09-03 8:14 ` Andy Shevchenko
2021-09-03 17:55 ` Daniel Dadap
2021-09-03 0:38 ` [PATCH v6] " Daniel Dadap
2021-09-13 9:01 ` Hans de Goede
2021-09-20 13:29 ` Pali Rohár
2021-09-20 13:33 ` Hans de Goede
2021-09-20 13:51 ` Pali Rohár
2021-09-20 17:34 ` Daniel Dadap
2021-09-20 17:55 ` Pali Rohár
2021-09-20 19:38 ` Daniel Dadap
2021-09-20 19:52 ` Pali Rohár
2021-09-21 13:53 ` Hans de Goede
2021-09-21 14:02 ` Pali Rohár
2021-09-21 14:29 ` Daniel Dadap
2021-09-21 14:58 ` Hans de Goede
2021-09-27 20:23 ` [PATCH 1/2] platform/x86: Remove "WMAA" from identifier names in wmaa-backlight-wmi.c Daniel Dadap
2021-09-27 20:23 ` [PATCH 2/2] platform/x86: Rename wmaa-backlight-wmi to nvidia-wmi-ec-backlight Daniel Dadap
2021-10-11 13:00 ` [PATCH 1/2] platform/x86: Remove "WMAA" from identifier names in wmaa-backlight-wmi.c Hans de Goede
2021-09-27 22:52 ` [PATCH v6] platform/x86: Add driver for ACPI WMAA EC-based backlight control Daniel Dadap
2021-09-02 9:28 ` [PATCH v4] " Andy Shevchenko
2021-09-02 9:33 ` Thomas Weißschuh
2021-09-02 9:36 ` Andy Shevchenko
2021-09-01 15:57 ` Andy Shevchenko
2021-09-01 23:12 ` Aaron Plattner
2021-09-02 2:37 ` Daniel Dadap
2021-09-02 9:35 ` Andy Shevchenko
2021-09-02 20:15 ` Daniel Dadap
2021-09-03 8:10 ` Andy Shevchenko
2021-09-02 15:38 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adf55c8d-4552-f7a9-c5a7-53dc1aa0483d@nvidia.com \
--to=ddadap@nvidia.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=aplattner@nvidia.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=mario.limonciello@outlook.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pobrn@protonmail.com \
--cc=thomas@t-8ch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).