From: Daniel Dadap <ddadap@nvidia.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Thomas Weißschuh" <linux@weissschuh.net>,
"Platform Driver" <platform-driver-x86@vger.kernel.org>,
mario.limonciello@outlook.com,
"Barnabás Pőcze" <pobrn@protonmail.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Aaron Plattner" <aplattner@nvidia.com>
Subject: Re: [PATCH v5] platform/x86: Add driver for ACPI WMAA EC-based backlight control
Date: Fri, 3 Sep 2021 12:55:55 -0500 [thread overview]
Message-ID: <dca29eda-9bc9-c8b0-9be5-b44763ed5007@nvidia.com> (raw)
In-Reply-To: <CAHp75VetBYgtE3ezS81K104PqkevvxSkO2mCa=GWLgEO2-UJxA@mail.gmail.com>
On 9/3/21 3:14 AM, Andy Shevchenko wrote:
> On Fri, Sep 3, 2021 at 3:22 AM Daniel Dadap <ddadap@nvidia.com> wrote:
>> On 9/2/21 6:20 PM, Thomas Weißschuh wrote:
> ...
>
>>>> +#define WMAA_WMI_GUID "603E9613-EF25-4338-A3D0-C46177516DB7"
>>>> +
>>>> +static const struct wmi_device_id wmaa_backlight_wmi_id_table[] = {
>>>> + { .guid_string = WMAA_WMI_GUID },
>>> This could also be inlined as:
>>> { "603E9613-EF25-4338-A3D0-C46177516DB7" },
>>>
>>> More a stylistic thing though.
>> I considered that when switching to MODULE_DEVICE_TABLE, since the value
>> is now only used in one place, but looking at other similar drivers, it
>> does seem that the most common convention is to define the GUID as a
>> macro even if it's only used once. I'll leave this as-is, I think.
> I'm on Daniel's side here. But the problem I have noticed with the
> proposal is different, i.e. it loses the C99 style of member
> definitions.
Oh. I didn't even notice that the proposal excluded the designated
initializer. What I had been considering was inlining the GUID string
and getting rid of the preprocessor macro, while retaining the
designated initializer. In any case, the prevailing style does seem to
be to avoid inlining the constant, AFAICT.
next prev parent reply other threads:[~2021-09-03 17:56 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <DM6PR19MB2636AB267CD321DE40EF324AFA730@DM6PR19MB2636.namprd19.prod.outlook.com>
[not found] ` <20200731202154.11382-1-ddadap@nvidia.com>
[not found] ` <20200731202154.11382-2-ddadap@nvidia.com>
2020-11-10 9:34 ` [PATCH v2 2/2] platform/x86: wmi: fail wmi_driver_register when no GUID is found Hans de Goede
2020-11-12 18:54 ` Daniel Dadap
2021-08-24 22:04 ` [PATCH v3] platform/x86: Add driver for ACPI WMAA EC-based backlight control Daniel Dadap
2021-08-24 22:47 ` Barnabás Pőcze
2021-08-25 16:36 ` Daniel Dadap
2021-08-25 22:26 ` Daniel Dadap
2021-08-27 16:47 ` Daniel Dadap
2021-08-27 17:12 ` Daniel Dadap
2021-08-25 9:05 ` Andy Shevchenko
2021-08-25 16:47 ` Daniel Dadap
2021-08-25 22:06 ` Thomas Weißschuh
2021-08-25 22:28 ` Daniel Dadap
2021-08-26 13:35 ` Andy Shevchenko
2021-08-26 15:39 ` Daniel Dadap
2021-08-31 22:49 ` [PATCH v4] " Daniel Dadap
2021-09-01 9:25 ` Thomas Weißschuh
2021-09-02 2:12 ` Daniel Dadap
2021-09-02 10:19 ` Thomas Weißschuh
2021-09-02 20:15 ` Daniel Dadap
2021-09-02 20:31 ` Hans de Goede
2021-09-02 21:47 ` [PATCH v5] " Daniel Dadap
2021-09-02 23:20 ` Thomas Weißschuh
2021-09-03 0:22 ` Daniel Dadap
2021-09-03 8:14 ` Andy Shevchenko
2021-09-03 17:55 ` Daniel Dadap [this message]
2021-09-03 0:38 ` [PATCH v6] " Daniel Dadap
2021-09-13 9:01 ` Hans de Goede
2021-09-20 13:29 ` Pali Rohár
2021-09-20 13:33 ` Hans de Goede
2021-09-20 13:51 ` Pali Rohár
2021-09-20 17:34 ` Daniel Dadap
2021-09-20 17:55 ` Pali Rohár
2021-09-20 19:38 ` Daniel Dadap
2021-09-20 19:52 ` Pali Rohár
2021-09-21 13:53 ` Hans de Goede
2021-09-21 14:02 ` Pali Rohár
2021-09-21 14:29 ` Daniel Dadap
2021-09-21 14:58 ` Hans de Goede
2021-09-27 20:23 ` [PATCH 1/2] platform/x86: Remove "WMAA" from identifier names in wmaa-backlight-wmi.c Daniel Dadap
2021-09-27 20:23 ` [PATCH 2/2] platform/x86: Rename wmaa-backlight-wmi to nvidia-wmi-ec-backlight Daniel Dadap
2021-10-11 13:00 ` [PATCH 1/2] platform/x86: Remove "WMAA" from identifier names in wmaa-backlight-wmi.c Hans de Goede
2021-09-27 22:52 ` [PATCH v6] platform/x86: Add driver for ACPI WMAA EC-based backlight control Daniel Dadap
2021-09-02 9:28 ` [PATCH v4] " Andy Shevchenko
2021-09-02 9:33 ` Thomas Weißschuh
2021-09-02 9:36 ` Andy Shevchenko
2021-09-01 15:57 ` Andy Shevchenko
2021-09-01 23:12 ` Aaron Plattner
2021-09-02 2:37 ` Daniel Dadap
2021-09-02 9:35 ` Andy Shevchenko
2021-09-02 20:15 ` Daniel Dadap
2021-09-03 8:10 ` Andy Shevchenko
2021-09-02 15:38 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dca29eda-9bc9-c8b0-9be5-b44763ed5007@nvidia.com \
--to=ddadap@nvidia.com \
--cc=andy.shevchenko@gmail.com \
--cc=aplattner@nvidia.com \
--cc=hdegoede@redhat.com \
--cc=linux@weissschuh.net \
--cc=mario.limonciello@outlook.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pobrn@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).