Re: [PATCH 1/3] thinkpad_acpi: add support for force_discharge

[Hans de Goede <hdegoede@redhat.com>]

Hi Nicolò,

On 9/27/21 5:00 PM, Nicolò Piazzalunga wrote:
> Hi,
> 
> On 9/27/21 3:59 PM, Mark Pearson wrote:
>> Do let me know if there are some important use cases for these so I can go back to the FW team and discuss supporting them properly.
> 
> The important use cases are force discharge and inhibit charge.
> These at present are dealt with using tpacpi-bat, which relies on (out of tree) acpi_call.
> See also your previous reply.

I can see how those can be useful in certain circumstances.

I can also understand how Lenovo does not want these to be
available by default everywhere.

I think a good compromise would be to add a bool module option
which defaults to false to enable these.

Assuming Mark is ok with that, this is still blocked on agreeing
on standard power_supply class property names for these 2 features.

Can you perhaps write a (RFC) patch adding proposed standardized
attributes for this to:

Documentation/ABI/testing/sysfs-class-power

As well as to the enum power_supply_property {}
enum in: include/linux/power_supply.h

And to the power_supply_attrs[] array in
drivers/power/supply/power_supply_sysfs.c

?

And then send that the Sebastian Reichel with the linux-pm
and platform-driver-x86 lists in the Cc? 

Regards,

Hans