* [PATCH v2 1/1] platform/x86: asus-wmi: Add key mappings
@ 2022-07-10 11:37 Misaka19465
2022-07-10 15:34 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Misaka19465 @ 2022-07-10 11:37 UTC (permalink / raw)
To: corentin.chary, hdegoede, markgross
Cc: acpi4asus-user, platform-driver-x86, linux-kernel, Misaka19465
On laptops like ASUS TUF Gaming A15, which have hotkeys to start Armoury
Crate or AURA Sync, these hotkeys are unavailable. This patch add
mappings for them.
Signed-off-by: Misaka19465 <misaka19465@olddoctor.net>
---
drivers/platform/x86/asus-nb-wmi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index 57a07db65..478dd300b 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -522,6 +522,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
{ KE_KEY, 0x31, { KEY_VOLUMEDOWN } },
{ KE_KEY, 0x32, { KEY_MUTE } },
{ KE_KEY, 0x35, { KEY_SCREENLOCK } },
+ { KE_KEY, 0x38, { KEY_PROG3 } }, /* Armoury Crate */
{ KE_KEY, 0x40, { KEY_PREVIOUSSONG } },
{ KE_KEY, 0x41, { KEY_NEXTSONG } },
{ KE_KEY, 0x43, { KEY_STOPCD } }, /* Stop/Eject */
@@ -574,6 +575,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
{ KE_KEY, 0xA5, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + TV + HDMI */
{ KE_KEY, 0xA6, { KEY_SWITCHVIDEOMODE } }, /* SDSP CRT + TV + HDMI */
{ KE_KEY, 0xA7, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + CRT + TV + HDMI */
+ { KE_KEY, 0xB3, { KEY_PROG4 } }, /* AURA */
{ KE_KEY, 0xB5, { KEY_CALC } },
{ KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
{ KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
--
2.37.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] platform/x86: asus-wmi: Add key mappings
2022-07-10 11:37 [PATCH v2 1/1] platform/x86: asus-wmi: Add key mappings Misaka19465
@ 2022-07-10 15:34 ` Hans de Goede
2022-07-10 15:46 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2022-07-10 15:34 UTC (permalink / raw)
To: Misaka19465, corentin.chary, markgross
Cc: acpi4asus-user, platform-driver-x86, linux-kernel
Hi,
On 7/10/22 13:37, Misaka19465 wrote:
> On laptops like ASUS TUF Gaming A15, which have hotkeys to start Armoury
> Crate or AURA Sync, these hotkeys are unavailable. This patch add
> mappings for them.
>
> Signed-off-by: Misaka19465 <misaka19465@olddoctor.net>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/asus-nb-wmi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index 57a07db65..478dd300b 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -522,6 +522,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
> { KE_KEY, 0x31, { KEY_VOLUMEDOWN } },
> { KE_KEY, 0x32, { KEY_MUTE } },
> { KE_KEY, 0x35, { KEY_SCREENLOCK } },
> + { KE_KEY, 0x38, { KEY_PROG3 } }, /* Armoury Crate */
> { KE_KEY, 0x40, { KEY_PREVIOUSSONG } },
> { KE_KEY, 0x41, { KEY_NEXTSONG } },
> { KE_KEY, 0x43, { KEY_STOPCD } }, /* Stop/Eject */
> @@ -574,6 +575,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
> { KE_KEY, 0xA5, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + TV + HDMI */
> { KE_KEY, 0xA6, { KEY_SWITCHVIDEOMODE } }, /* SDSP CRT + TV + HDMI */
> { KE_KEY, 0xA7, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + CRT + TV + HDMI */
> + { KE_KEY, 0xB3, { KEY_PROG4 } }, /* AURA */
> { KE_KEY, 0xB5, { KEY_CALC } },
> { KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
> { KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] platform/x86: asus-wmi: Add key mappings
2022-07-10 15:34 ` Hans de Goede
@ 2022-07-10 15:46 ` Hans de Goede
0 siblings, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2022-07-10 15:46 UTC (permalink / raw)
To: Misaka19465, corentin.chary, markgross
Cc: acpi4asus-user, platform-driver-x86, linux-kernel
Hi,
On 7/10/22 17:34, Hans de Goede wrote:
> Hi,
>
> On 7/10/22 13:37, Misaka19465 wrote:
>> On laptops like ASUS TUF Gaming A15, which have hotkeys to start Armoury
>> Crate or AURA Sync, these hotkeys are unavailable. This patch add
>> mappings for them.
>>
>> Signed-off-by: Misaka19465 <misaka19465@olddoctor.net>
>
> Thank you for your patch, I've applied this patch to my review-hans
> branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
>
> Note it will show up in my review-hans branch once I've pushed my
> local branch there, which might take a while.
>
> Once I've run some tests on this branch the patches there will be
> added to the platform-drivers-x86/for-next branch and eventually
> will be included in the pdx86 pull-request to Linus for the next
> merge-window.
I just noticed that this patch submission is not using your real name
in "<Firstname> <Lastname>" format as required by the kernel submission
guidelines:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
Since this is a very trivial patch I'm going to keep it in my
tree anyways, but for future kernel submissions please use your
real name.
Regards,
Hans
>> ---
>> drivers/platform/x86/asus-nb-wmi.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
>> index 57a07db65..478dd300b 100644
>> --- a/drivers/platform/x86/asus-nb-wmi.c
>> +++ b/drivers/platform/x86/asus-nb-wmi.c
>> @@ -522,6 +522,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>> { KE_KEY, 0x31, { KEY_VOLUMEDOWN } },
>> { KE_KEY, 0x32, { KEY_MUTE } },
>> { KE_KEY, 0x35, { KEY_SCREENLOCK } },
>> + { KE_KEY, 0x38, { KEY_PROG3 } }, /* Armoury Crate */
>> { KE_KEY, 0x40, { KEY_PREVIOUSSONG } },
>> { KE_KEY, 0x41, { KEY_NEXTSONG } },
>> { KE_KEY, 0x43, { KEY_STOPCD } }, /* Stop/Eject */
>> @@ -574,6 +575,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>> { KE_KEY, 0xA5, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + TV + HDMI */
>> { KE_KEY, 0xA6, { KEY_SWITCHVIDEOMODE } }, /* SDSP CRT + TV + HDMI */
>> { KE_KEY, 0xA7, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + CRT + TV + HDMI */
>> + { KE_KEY, 0xB3, { KEY_PROG4 } }, /* AURA */
>> { KE_KEY, 0xB5, { KEY_CALC } },
>> { KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
>> { KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-10 15:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-10 11:37 [PATCH v2 1/1] platform/x86: asus-wmi: Add key mappings Misaka19465
2022-07-10 15:34 ` Hans de Goede
2022-07-10 15:46 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).