* [PATCH -next v2] platform/surface: aggregator: Use list_move_tail instead of list_del/list_add_tail in ssh_packet_layer.c
@ 2021-06-09 7:24 Baokun Li
2021-06-09 11:37 ` Maximilian Luz
2021-06-09 14:24 ` Hans de Goede
0 siblings, 2 replies; 3+ messages in thread
From: Baokun Li @ 2021-06-09 7:24 UTC (permalink / raw)
To: linux-kernel, Maximilian Luz, Hans de Goede, Mark Gross
Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3, libaokun1,
platform-driver-x86, kernel-janitors, Hulk Robot
Using list_move_tail() instead of list_del() + list_add_tail() in ssh_packet_layer.c.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
---
V1->V2:
CC mailist
.../surface/aggregator/ssh_packet_layer.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/surface/aggregator/ssh_packet_layer.c b/drivers/platform/surface/aggregator/ssh_packet_layer.c
index 15d96eac6811..2f546ad11c4e 100644
--- a/drivers/platform/surface/aggregator/ssh_packet_layer.c
+++ b/drivers/platform/surface/aggregator/ssh_packet_layer.c
@@ -1567,9 +1567,7 @@ static void ssh_ptl_timeout_reap(struct work_struct *work)
clear_bit(SSH_PACKET_SF_PENDING_BIT, &p->state);
atomic_dec(&ptl->pending.count);
- list_del(&p->pending_node);
-
- list_add_tail(&p->pending_node, &claimed);
+ list_move_tail(&p->pending_node, &claimed);
}
spin_unlock(&ptl->pending.lock);
@@ -1957,8 +1955,7 @@ void ssh_ptl_shutdown(struct ssh_ptl *ptl)
smp_mb__before_atomic();
clear_bit(SSH_PACKET_SF_QUEUED_BIT, &p->state);
- list_del(&p->queue_node);
- list_add_tail(&p->queue_node, &complete_q);
+ list_move_tail(&p->queue_node, &complete_q);
}
spin_unlock(&ptl->queue.lock);
@@ -1970,8 +1967,7 @@ void ssh_ptl_shutdown(struct ssh_ptl *ptl)
smp_mb__before_atomic();
clear_bit(SSH_PACKET_SF_PENDING_BIT, &p->state);
- list_del(&p->pending_node);
- list_add_tail(&p->pending_node, &complete_q);
+ list_move_tail(&p->pending_node, &complete_q);
}
atomic_set(&ptl->pending.count, 0);
spin_unlock(&ptl->pending.lock);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next v2] platform/surface: aggregator: Use list_move_tail instead of list_del/list_add_tail in ssh_packet_layer.c
2021-06-09 7:24 [PATCH -next v2] platform/surface: aggregator: Use list_move_tail instead of list_del/list_add_tail in ssh_packet_layer.c Baokun Li
@ 2021-06-09 11:37 ` Maximilian Luz
2021-06-09 14:24 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Maximilian Luz @ 2021-06-09 11:37 UTC (permalink / raw)
To: Baokun Li, linux-kernel, Hans de Goede, Mark Gross
Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3,
platform-driver-x86, kernel-janitors, Hulk Robot
On 6/9/21 9:24 AM, Baokun Li wrote:
> Using list_move_tail() instead of list_del() + list_add_tail() in ssh_packet_layer.c.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
Looks good to me, thanks!
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Regards,
Max
> V1->V2:
> CC mailist
>
> .../surface/aggregator/ssh_packet_layer.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/platform/surface/aggregator/ssh_packet_layer.c b/drivers/platform/surface/aggregator/ssh_packet_layer.c
> index 15d96eac6811..2f546ad11c4e 100644
> --- a/drivers/platform/surface/aggregator/ssh_packet_layer.c
> +++ b/drivers/platform/surface/aggregator/ssh_packet_layer.c
> @@ -1567,9 +1567,7 @@ static void ssh_ptl_timeout_reap(struct work_struct *work)
> clear_bit(SSH_PACKET_SF_PENDING_BIT, &p->state);
>
> atomic_dec(&ptl->pending.count);
> - list_del(&p->pending_node);
> -
> - list_add_tail(&p->pending_node, &claimed);
> + list_move_tail(&p->pending_node, &claimed);
> }
>
> spin_unlock(&ptl->pending.lock);
> @@ -1957,8 +1955,7 @@ void ssh_ptl_shutdown(struct ssh_ptl *ptl)
> smp_mb__before_atomic();
> clear_bit(SSH_PACKET_SF_QUEUED_BIT, &p->state);
>
> - list_del(&p->queue_node);
> - list_add_tail(&p->queue_node, &complete_q);
> + list_move_tail(&p->queue_node, &complete_q);
> }
> spin_unlock(&ptl->queue.lock);
>
> @@ -1970,8 +1967,7 @@ void ssh_ptl_shutdown(struct ssh_ptl *ptl)
> smp_mb__before_atomic();
> clear_bit(SSH_PACKET_SF_PENDING_BIT, &p->state);
>
> - list_del(&p->pending_node);
> - list_add_tail(&p->pending_node, &complete_q);
> + list_move_tail(&p->pending_node, &complete_q);
> }
> atomic_set(&ptl->pending.count, 0);
> spin_unlock(&ptl->pending.lock);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next v2] platform/surface: aggregator: Use list_move_tail instead of list_del/list_add_tail in ssh_packet_layer.c
2021-06-09 7:24 [PATCH -next v2] platform/surface: aggregator: Use list_move_tail instead of list_del/list_add_tail in ssh_packet_layer.c Baokun Li
2021-06-09 11:37 ` Maximilian Luz
@ 2021-06-09 14:24 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2021-06-09 14:24 UTC (permalink / raw)
To: Baokun Li, linux-kernel, Maximilian Luz, Mark Gross
Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3,
platform-driver-x86, kernel-janitors, Hulk Robot
Hi,
On 6/9/21 9:24 AM, Baokun Li wrote:
> Using list_move_tail() instead of list_del() + list_add_tail() in ssh_packet_layer.c.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> V1->V2:
> CC mailist
>
> .../surface/aggregator/ssh_packet_layer.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/platform/surface/aggregator/ssh_packet_layer.c b/drivers/platform/surface/aggregator/ssh_packet_layer.c
> index 15d96eac6811..2f546ad11c4e 100644
> --- a/drivers/platform/surface/aggregator/ssh_packet_layer.c
> +++ b/drivers/platform/surface/aggregator/ssh_packet_layer.c
> @@ -1567,9 +1567,7 @@ static void ssh_ptl_timeout_reap(struct work_struct *work)
> clear_bit(SSH_PACKET_SF_PENDING_BIT, &p->state);
>
> atomic_dec(&ptl->pending.count);
> - list_del(&p->pending_node);
> -
> - list_add_tail(&p->pending_node, &claimed);
> + list_move_tail(&p->pending_node, &claimed);
> }
>
> spin_unlock(&ptl->pending.lock);
> @@ -1957,8 +1955,7 @@ void ssh_ptl_shutdown(struct ssh_ptl *ptl)
> smp_mb__before_atomic();
> clear_bit(SSH_PACKET_SF_QUEUED_BIT, &p->state);
>
> - list_del(&p->queue_node);
> - list_add_tail(&p->queue_node, &complete_q);
> + list_move_tail(&p->queue_node, &complete_q);
> }
> spin_unlock(&ptl->queue.lock);
>
> @@ -1970,8 +1967,7 @@ void ssh_ptl_shutdown(struct ssh_ptl *ptl)
> smp_mb__before_atomic();
> clear_bit(SSH_PACKET_SF_PENDING_BIT, &p->state);
>
> - list_del(&p->pending_node);
> - list_add_tail(&p->pending_node, &complete_q);
> + list_move_tail(&p->pending_node, &complete_q);
> }
> atomic_set(&ptl->pending.count, 0);
> spin_unlock(&ptl->pending.lock);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-09 14:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 7:24 [PATCH -next v2] platform/surface: aggregator: Use list_move_tail instead of list_del/list_add_tail in ssh_packet_layer.c Baokun Li
2021-06-09 11:37 ` Maximilian Luz
2021-06-09 14:24 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).