[Bug 216347] New: ACPI power profile keeps switching to "low-power" on ThinkPad T14 Gen1 (AMD)

[Bug 216347] New: ACPI power profile keeps switching to "low-power" on ThinkPad T14 Gen1 (AMD)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216347

            Bug ID: 216347
           Summary: ACPI power profile keeps switching to "low-power" on
                    ThinkPad T14 Gen1 (AMD)
           Product: Drivers
           Version: 2.5
    Kernel Version: 5.19
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Platform_x86
          Assignee: drivers_platform_x86@kernel-bugs.osdl.org
          Reporter: madcatx@atlas.cz
        Regression: No

Hi,

I recently discovered this annoying behavior. I use an udev script to toggle
between "low-power" and "performance" ACPI power profiles based on whether the
laptop is plugged into a wall. By cat'ing "/sys/firmware/acpi/platform_profile"
I observe the power profile always dropping to "low-power" a few seconds after
I manually change it to something else.

The machine has a 4750U Ryzen chip and the latest 1.41 firmware (DMI: LENOVO
20UDS02D00/20UDS02D00, BIOS R1BET72W(1.41 )). I run the latest 5.19 kernel.

I tried to toggle between S3 and S2idle sleep modes but that doesn't seem to
make any difference.

Is there anything I can do to help track this down?

Thanks!

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216347] ACPI power profile keeps switching to "low-power" on ThinkPad T14 Gen1 (AMD)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216347

Mario Limonciello (AMD) (mario.limonciello@amd.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.limonciello@amd.com

--- Comment #1 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
Do you have power-profiles-daemon installed?  That's the most likely cause to
this behavior I would expect.  In general it's probably better to change the
profile using the d-bus API with PPD if you have PPD installed so you don't
have two things fighting over the same file.

FYI - technically there are different profiles for Lenovo AMD systems on AC
adapter or battery but thinkpad_acpi doesn't export them right now.  If this
changes in the future you may want to keep an eye on it because your udev rules
won't make sense anymore.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216347] ACPI power profile keeps switching to "low-power" on ThinkPad T14 Gen1 (AMD)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216347

--- Comment #2 from madcatx@atlas.cz ---
I don't have PPD installed and a quick look around didn't reveal anything that
would mess with the power profile. What's the expected power_profile value
after boot when nothing touches it? I can try to boot off a lean Live distro
and check.

I tried to remove the power_profile toggle from the script I trigger through
udev rules to check that it wasn't somehow misbehaving but it made no
difference.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216347] ACPI power profile keeps switching to "low-power" on ThinkPad T14 Gen1 (AMD)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216347

--- Comment #3 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
If PPD isn't the cause maybe it's the firmware causing it?

If you can modify the kernel driver, can you please add some debugging
statement here to see if a related event is coming through:

https://github.com/torvalds/linux/blob/master/drivers/platform/x86/thinkpad_acpi.c#L11023

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216347] ACPI power profile keeps switching to "low-power" on ThinkPad T14 Gen1 (AMD)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216347

--- Comment #4 from madcatx@atlas.cz ---
I modded the driver to log the events, here's the output. Note that I log all
events and have an extra output for the THM event so the output is a bit
noisier that necessary.

[  110.307214] TPACPI event id 24626
* Manual switch to performance
[  110.307221] TPACPI event THM_CSM_COMPLETED
[  110.308287] TPACPI event id 4114
* Drop to low power
[  125.374888] TPACPI event id 24626
[  125.374894] TPACPI event THM_CSM_COMPLETED
* Manual switch to performance
[  178.560859] TPACPI event id 24626
[  178.560862] TPACPI event THM_CSM_COMPLETED
* Drop to low power
[  321.588092] TPACPI event id 24626
[  321.588100] TPACPI event THM_CSM_COMPLETED
* Manual switch to performance
[  340.418211] TPACPI event id 24626
[  340.418215] TPACPI event THM_CSM_COMPLETED
* Manual switch to performance
[  344.953610] TPACPI event id 24626
[  344.953614] TPACPI event THM_CSM_COMPLETED
* Drop to low power
[  350.357321] TPACPI event id 24626
[  350.357328] TPACPI event THM_CSM_COMPLETED
* Manual switch to performance
[  352.865566] TPACPI event id 24626
[  352.865573] TPACPI event THM_CSM_COMPLETED
* Drop to low power
[  362.030351] TPACPI event id 24626
[  362.030355] TPACPI event THM_CSM_COMPLETED

There doesn't seem to be anything hammering the toggle, it just switches itself
back to "low-power".

There doesn't seem to be any apparent pattern that would provoke this. All I
can tell is that the power profile seems to switch itself back from
"performance" to "low-power" after some time. It can take anywhere from 5 to 70
seconds for this to happen.

It also looks like the "balanced" profile seems to stick but I need to verify
this better.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216347] ACPI power profile keeps switching to "low-power" on ThinkPad T14 Gen1 (AMD)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216347

Mario Limonciello (AMD) (mario.limonciello@amd.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |markpearson@lenovo.com
           Assignee|drivers_platform_x86@kernel |markpearson@lenovo.com
                   |-bugs.osdl.org              |

--- Comment #5 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
> There doesn't seem to be anything hammering the toggle, it just switches
> itself back to "low-power".

Well it at least proves this is happening from firmware/hardware and not
(obviously) from your own doing in software.  I think it still needs further
characterization.

> There doesn't seem to be any apparent pattern that would provoke this. 

Just as a guess; could this be related to lap mode?  There is a lap mode value
stored in `dytc_lapmode`.  Can you add that to your output?


@Mark maybe you can help explain this?

If nothing else I think it would be good to extend some dev_info messaging when
this is happening.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.