From: Maximilian Luz <luzmaximilian@gmail.com>
To: Qiheng Lin <linqiheng@huawei.com>, Sebastian Reichel <sre@kernel.org>
Cc: linux-pm@vger.kernel.org, platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] power: supply: Make symbol 'surface_ac_pm_ops' static
Date: Sat, 10 Apr 2021 12:42:43 +0200 [thread overview]
Message-ID: <c5edfe56-eebe-55c0-e30f-4a552934d0b8@gmail.com> (raw)
In-Reply-To: <20210410041249.12846-1-linqiheng@huawei.com>
On 4/10/21 6:12 AM, Qiheng Lin wrote:
> The sparse tool complains as follows:
>
> drivers/power/supply/surface_charger.c:229:1: warning:
> symbol 'surface_ac_pm_ops' was not declared. Should it be static?
>
> This symbol is not used outside of surface_charger.c, so this
> commit marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
Acked-by: Maximilian Luz <luzmaximilian@gmail.com>
> ---
> drivers/power/supply/surface_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/surface_charger.c b/drivers/power/supply/surface_charger.c
> index c2dd7e604d14..81a5b79822c9 100644
> --- a/drivers/power/supply/surface_charger.c
> +++ b/drivers/power/supply/surface_charger.c
> @@ -226,7 +226,7 @@ static int __maybe_unused surface_ac_resume(struct device *dev)
> {
> return spwr_ac_recheck(dev_get_drvdata(dev));
> }
> -SIMPLE_DEV_PM_OPS(surface_ac_pm_ops, NULL, surface_ac_resume);
> +static SIMPLE_DEV_PM_OPS(surface_ac_pm_ops, NULL, surface_ac_resume);
>
> static int surface_ac_probe(struct ssam_device *sdev)
> {
>
next prev parent reply other threads:[~2021-04-10 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 4:12 [PATCH -next] power: supply: Make symbol 'surface_ac_pm_ops' static Qiheng Lin
2021-04-10 10:42 ` Maximilian Luz [this message]
2021-04-12 20:00 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5edfe56-eebe-55c0-e30f-4a552934d0b8@gmail.com \
--to=luzmaximilian@gmail.com \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linqiheng@huawei.com \
--cc=linux-pm@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).