* [PATCH -next] power: supply: Make symbol 'surface_ac_pm_ops' static
@ 2021-04-10 4:12 Qiheng Lin
2021-04-10 10:42 ` Maximilian Luz
0 siblings, 1 reply; 3+ messages in thread
From: Qiheng Lin @ 2021-04-10 4:12 UTC (permalink / raw)
To: linqiheng, Maximilian Luz, Sebastian Reichel
Cc: linux-pm, platform-driver-x86, kernel-janitors, Hulk Robot
The sparse tool complains as follows:
drivers/power/supply/surface_charger.c:229:1: warning:
symbol 'surface_ac_pm_ops' was not declared. Should it be static?
This symbol is not used outside of surface_charger.c, so this
commit marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
---
drivers/power/supply/surface_charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/surface_charger.c b/drivers/power/supply/surface_charger.c
index c2dd7e604d14..81a5b79822c9 100644
--- a/drivers/power/supply/surface_charger.c
+++ b/drivers/power/supply/surface_charger.c
@@ -226,7 +226,7 @@ static int __maybe_unused surface_ac_resume(struct device *dev)
{
return spwr_ac_recheck(dev_get_drvdata(dev));
}
-SIMPLE_DEV_PM_OPS(surface_ac_pm_ops, NULL, surface_ac_resume);
+static SIMPLE_DEV_PM_OPS(surface_ac_pm_ops, NULL, surface_ac_resume);
static int surface_ac_probe(struct ssam_device *sdev)
{
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] power: supply: Make symbol 'surface_ac_pm_ops' static
2021-04-10 4:12 [PATCH -next] power: supply: Make symbol 'surface_ac_pm_ops' static Qiheng Lin
@ 2021-04-10 10:42 ` Maximilian Luz
2021-04-12 20:00 ` Sebastian Reichel
0 siblings, 1 reply; 3+ messages in thread
From: Maximilian Luz @ 2021-04-10 10:42 UTC (permalink / raw)
To: Qiheng Lin, Sebastian Reichel
Cc: linux-pm, platform-driver-x86, kernel-janitors, Hulk Robot
On 4/10/21 6:12 AM, Qiheng Lin wrote:
> The sparse tool complains as follows:
>
> drivers/power/supply/surface_charger.c:229:1: warning:
> symbol 'surface_ac_pm_ops' was not declared. Should it be static?
>
> This symbol is not used outside of surface_charger.c, so this
> commit marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
Acked-by: Maximilian Luz <luzmaximilian@gmail.com>
> ---
> drivers/power/supply/surface_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/surface_charger.c b/drivers/power/supply/surface_charger.c
> index c2dd7e604d14..81a5b79822c9 100644
> --- a/drivers/power/supply/surface_charger.c
> +++ b/drivers/power/supply/surface_charger.c
> @@ -226,7 +226,7 @@ static int __maybe_unused surface_ac_resume(struct device *dev)
> {
> return spwr_ac_recheck(dev_get_drvdata(dev));
> }
> -SIMPLE_DEV_PM_OPS(surface_ac_pm_ops, NULL, surface_ac_resume);
> +static SIMPLE_DEV_PM_OPS(surface_ac_pm_ops, NULL, surface_ac_resume);
>
> static int surface_ac_probe(struct ssam_device *sdev)
> {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] power: supply: Make symbol 'surface_ac_pm_ops' static
2021-04-10 10:42 ` Maximilian Luz
@ 2021-04-12 20:00 ` Sebastian Reichel
0 siblings, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2021-04-12 20:00 UTC (permalink / raw)
To: Maximilian Luz
Cc: Qiheng Lin, linux-pm, platform-driver-x86, kernel-janitors, Hulk Robot
[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]
Hi,
On Sat, Apr 10, 2021 at 12:42:43PM +0200, Maximilian Luz wrote:
> On 4/10/21 6:12 AM, Qiheng Lin wrote:
> > The sparse tool complains as follows:
> >
> > drivers/power/supply/surface_charger.c:229:1: warning:
> > symbol 'surface_ac_pm_ops' was not declared. Should it be static?
> >
> > This symbol is not used outside of surface_charger.c, so this
> > commit marks it static.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
>
> Acked-by: Maximilian Luz <luzmaximilian@gmail.com>
Thanks, queued.
-- Sebastian
> > ---
> > drivers/power/supply/surface_charger.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/surface_charger.c b/drivers/power/supply/surface_charger.c
> > index c2dd7e604d14..81a5b79822c9 100644
> > --- a/drivers/power/supply/surface_charger.c
> > +++ b/drivers/power/supply/surface_charger.c
> > @@ -226,7 +226,7 @@ static int __maybe_unused surface_ac_resume(struct device *dev)
> > {
> > return spwr_ac_recheck(dev_get_drvdata(dev));
> > }
> > -SIMPLE_DEV_PM_OPS(surface_ac_pm_ops, NULL, surface_ac_resume);
> > +static SIMPLE_DEV_PM_OPS(surface_ac_pm_ops, NULL, surface_ac_resume);
> > static int surface_ac_probe(struct ssam_device *sdev)
> > {
> >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-12 20:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-10 4:12 [PATCH -next] power: supply: Make symbol 'surface_ac_pm_ops' static Qiheng Lin
2021-04-10 10:42 ` Maximilian Luz
2021-04-12 20:00 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).