* [PATCH] platform/surface: gpe: Add support for Surface Laptop Studio
@ 2021-10-21 11:10 Maximilian Luz
2021-10-21 18:33 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Maximilian Luz @ 2021-10-21 11:10 UTC (permalink / raw)
Cc: Maximilian Luz, Hans de Goede, Mark Gross, platform-driver-x86,
linux-kernel
The new Surface Laptop Studio uses GPEs for lid events as well. Add an
entry for that so that the lid can be used to wake the device.
Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
---
drivers/platform/surface/surface_gpe.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/platform/surface/surface_gpe.c b/drivers/platform/surface/surface_gpe.c
index 86f6991b1215..c1775db29efb 100644
--- a/drivers/platform/surface/surface_gpe.c
+++ b/drivers/platform/surface/surface_gpe.c
@@ -26,6 +26,11 @@ static const struct property_entry lid_device_props_l17[] = {
{},
};
+static const struct property_entry lid_device_props_l4B[] = {
+ PROPERTY_ENTRY_U32("gpe", 0x4B),
+ {},
+};
+
static const struct property_entry lid_device_props_l4D[] = {
PROPERTY_ENTRY_U32("gpe", 0x4D),
{},
@@ -158,6 +163,14 @@ static const struct dmi_system_id dmi_lid_device_table[] = {
},
.driver_data = (void *)lid_device_props_l4D,
},
+ {
+ .ident = "Surface Laptop Studio",
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Surface Laptop Studio"),
+ },
+ .driver_data = (void *)lid_device_props_l4B,
+ },
{ }
};
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/surface: gpe: Add support for Surface Laptop Studio
2021-10-21 11:10 [PATCH] platform/surface: gpe: Add support for Surface Laptop Studio Maximilian Luz
@ 2021-10-21 18:33 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-10-21 18:33 UTC (permalink / raw)
To: Maximilian Luz; +Cc: Mark Gross, platform-driver-x86, linux-kernel
Hi,
On 10/21/21 13:10, Maximilian Luz wrote:
> The new Surface Laptop Studio uses GPEs for lid events as well. Add an
> entry for that so that the lid can be used to wake the device.
>
> Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/surface/surface_gpe.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/platform/surface/surface_gpe.c b/drivers/platform/surface/surface_gpe.c
> index 86f6991b1215..c1775db29efb 100644
> --- a/drivers/platform/surface/surface_gpe.c
> +++ b/drivers/platform/surface/surface_gpe.c
> @@ -26,6 +26,11 @@ static const struct property_entry lid_device_props_l17[] = {
> {},
> };
>
> +static const struct property_entry lid_device_props_l4B[] = {
> + PROPERTY_ENTRY_U32("gpe", 0x4B),
> + {},
> +};
> +
> static const struct property_entry lid_device_props_l4D[] = {
> PROPERTY_ENTRY_U32("gpe", 0x4D),
> {},
> @@ -158,6 +163,14 @@ static const struct dmi_system_id dmi_lid_device_table[] = {
> },
> .driver_data = (void *)lid_device_props_l4D,
> },
> + {
> + .ident = "Surface Laptop Studio",
> + .matches = {
> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Surface Laptop Studio"),
> + },
> + .driver_data = (void *)lid_device_props_l4B,
> + },
> { }
> };
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-21 18:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-21 11:10 [PATCH] platform/surface: gpe: Add support for Surface Laptop Studio Maximilian Luz
2021-10-21 18:33 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).