platform-driver-x86.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] platform/x86: panasonic-laptop: remove redundant assignment of variable result
@ 2021-03-26 19:20 Colin King
  2021-04-07 11:26 ` Hans de Goede
  0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-03-26 19:20 UTC (permalink / raw)
  To: Kenneth Chan, Hans de Goede, Mark Gross, platform-driver-x86
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

The variable result is being assigned a value that is never
read and it is being updated later with a new value. The
assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/platform/x86/panasonic-laptop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/panasonic-laptop.c b/drivers/platform/x86/panasonic-laptop.c
index 6388c3c705a6..d4f444401496 100644
--- a/drivers/platform/x86/panasonic-laptop.c
+++ b/drivers/platform/x86/panasonic-laptop.c
@@ -973,7 +973,7 @@ static int acpi_pcc_hotkey_add(struct acpi_device *device)
 	pcc->mute = pcc->sinf[SINF_MUTE];
 	pcc->ac_brightness = pcc->sinf[SINF_AC_CUR_BRIGHT];
 	pcc->dc_brightness = pcc->sinf[SINF_DC_CUR_BRIGHT];
-	result = pcc->current_brightness = pcc->sinf[SINF_CUR_BRIGHT];
+	pcc->current_brightness = pcc->sinf[SINF_CUR_BRIGHT];
 
 	/* add sysfs attributes */
 	result = sysfs_create_group(&device->dev.kobj, &pcc_attr_group);
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] platform/x86: panasonic-laptop: remove redundant assignment of variable result
  2021-03-26 19:20 [PATCH] platform/x86: panasonic-laptop: remove redundant assignment of variable result Colin King
@ 2021-04-07 11:26 ` Hans de Goede
  0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-04-07 11:26 UTC (permalink / raw)
  To: Colin King, Kenneth Chan, Mark Gross, platform-driver-x86
  Cc: kernel-janitors, linux-kernel

Hi,

On 3/26/21 8:20 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The variable result is being assigned a value that is never
> read and it is being updated later with a new value. The
> assignment is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans



> ---
>  drivers/platform/x86/panasonic-laptop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/panasonic-laptop.c b/drivers/platform/x86/panasonic-laptop.c
> index 6388c3c705a6..d4f444401496 100644
> --- a/drivers/platform/x86/panasonic-laptop.c
> +++ b/drivers/platform/x86/panasonic-laptop.c
> @@ -973,7 +973,7 @@ static int acpi_pcc_hotkey_add(struct acpi_device *device)
>  	pcc->mute = pcc->sinf[SINF_MUTE];
>  	pcc->ac_brightness = pcc->sinf[SINF_AC_CUR_BRIGHT];
>  	pcc->dc_brightness = pcc->sinf[SINF_DC_CUR_BRIGHT];
> -	result = pcc->current_brightness = pcc->sinf[SINF_CUR_BRIGHT];
> +	pcc->current_brightness = pcc->sinf[SINF_CUR_BRIGHT];
>  
>  	/* add sysfs attributes */
>  	result = sysfs_create_group(&device->dev.kobj, &pcc_attr_group);
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-07 11:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26 19:20 [PATCH] platform/x86: panasonic-laptop: remove redundant assignment of variable result Colin King
2021-04-07 11:26 ` Hans de Goede

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).