* [PATCH] platform/x86: Kconfig: add missing selects for ideapad-laptop
@ 2021-02-04 14:20 Barnabás Pőcze
2021-02-04 16:23 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Barnabás Pőcze @ 2021-02-04 14:20 UTC (permalink / raw)
To: platform-driver-x86, Hans de Goede, Mark Gross, Ike Panhc
LED class support is needed by the ideapad-laptop module to compile after
the referenced commit. Add missing NEW_LEDS and LEDS_CLASS to Kconfig.
Fixes: 503325f84bc0 ("platform/x86: ideapad-laptop: add keyboard backlight control support")
Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index cf76e724e8c3..89cc2936f2ef 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -452,6 +452,8 @@ config IDEAPAD_LAPTOP
depends on ACPI_WMI || ACPI_WMI = n
depends on ACPI_PLATFORM_PROFILE
select INPUT_SPARSEKMAP
+ select NEW_LEDS
+ select LEDS_CLASS
help
This is a driver for Lenovo IdeaPad netbooks contains drivers for
rfkill switch, hotkey, fan control and backlight control.
--
2.30.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: Kconfig: add missing selects for ideapad-laptop
2021-02-04 14:20 [PATCH] platform/x86: Kconfig: add missing selects for ideapad-laptop Barnabás Pőcze
@ 2021-02-04 16:23 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-02-04 16:23 UTC (permalink / raw)
To: Barnabás Pőcze, platform-driver-x86, Mark Gross, Ike Panhc
Hi,
On 2/4/21 3:20 PM, Barnabás Pőcze wrote:
> LED class support is needed by the ideapad-laptop module to compile after
> the referenced commit. Add missing NEW_LEDS and LEDS_CLASS to Kconfig.
>
> Fixes: 503325f84bc0 ("platform/x86: ideapad-laptop: add keyboard backlight control support")
> Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index cf76e724e8c3..89cc2936f2ef 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -452,6 +452,8 @@ config IDEAPAD_LAPTOP
> depends on ACPI_WMI || ACPI_WMI = n
> depends on ACPI_PLATFORM_PROFILE
> select INPUT_SPARSEKMAP
> + select NEW_LEDS
> + select LEDS_CLASS
> help
> This is a driver for Lenovo IdeaPad netbooks contains drivers for
> rfkill switch, hotkey, fan control and backlight control.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-04 16:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-04 14:20 [PATCH] platform/x86: Kconfig: add missing selects for ideapad-laptop Barnabás Pőcze
2021-02-04 16:23 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).