* [PATCH 1/1] lib/oe/reproducible: Use git log without gpg signature
[not found] <cover.1673521664.git.bmauduit@beneth.fr>
@ 2023-01-12 11:11 ` Benoît Mauduit
2023-01-12 11:22 ` [poky] " Alexander Kanavin
0 siblings, 1 reply; 2+ messages in thread
From: Benoît Mauduit @ 2023-01-12 11:11 UTC (permalink / raw)
To: poky; +Cc: Benoît Mauduit
Previously, if "showSignature" is present in user gitconfig, parsing
of the timestamp will fail.
Ideally we should replace this command with a git plumbing command.
Signed-off-by: Benoît Mauduit <bmauduit@beneth.fr>
---
meta/lib/oe/reproducible.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/lib/oe/reproducible.py b/meta/lib/oe/reproducible.py
index 04a1810d4f2..9ac75c02e38 100644
--- a/meta/lib/oe/reproducible.py
+++ b/meta/lib/oe/reproducible.py
@@ -115,7 +115,8 @@ def get_source_date_epoch_from_git(d, sourcedir):
return None
bb.debug(1, "git repository: %s" % gitpath)
- p = subprocess.run(['git', '--git-dir', gitpath, 'log', '-1', '--pretty=%ct'], check=True, stdout=subprocess.PIPE)
+ p = subprocess.run(['git', '-c', 'log.showSignature=false', '--git-dir', gitpath, 'log', '-1', '--pretty=%ct'],
+ check=True, stdout=subprocess.PIPE)
return int(p.stdout.decode('utf-8'))
def get_source_date_epoch_from_youngest_file(d, sourcedir):
--
2.39.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [poky] [PATCH 1/1] lib/oe/reproducible: Use git log without gpg signature
2023-01-12 11:11 ` [PATCH 1/1] lib/oe/reproducible: Use git log without gpg signature Benoît Mauduit
@ 2023-01-12 11:22 ` Alexander Kanavin
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Kanavin @ 2023-01-12 11:22 UTC (permalink / raw)
To: bmauduit; +Cc: poky
Hello,
please send this to the oe-core mailing list, as changes in poky/meta/
should go there. It's something of a historical baggage :-)
Alex
On Thu, 12 Jan 2023 at 12:11, Benoît Mauduit via
lists.yoctoproject.org <bmauduit=beneth.fr@lists.yoctoproject.org>
wrote:
>
> Previously, if "showSignature" is present in user gitconfig, parsing
> of the timestamp will fail.
>
> Ideally we should replace this command with a git plumbing command.
>
> Signed-off-by: Benoît Mauduit <bmauduit@beneth.fr>
> ---
> meta/lib/oe/reproducible.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/lib/oe/reproducible.py b/meta/lib/oe/reproducible.py
> index 04a1810d4f2..9ac75c02e38 100644
> --- a/meta/lib/oe/reproducible.py
> +++ b/meta/lib/oe/reproducible.py
> @@ -115,7 +115,8 @@ def get_source_date_epoch_from_git(d, sourcedir):
> return None
>
> bb.debug(1, "git repository: %s" % gitpath)
> - p = subprocess.run(['git', '--git-dir', gitpath, 'log', '-1', '--pretty=%ct'], check=True, stdout=subprocess.PIPE)
> + p = subprocess.run(['git', '-c', 'log.showSignature=false', '--git-dir', gitpath, 'log', '-1', '--pretty=%ct'],
> + check=True, stdout=subprocess.PIPE)
> return int(p.stdout.decode('utf-8'))
>
> def get_source_date_epoch_from_youngest_file(d, sourcedir):
> --
> 2.39.0
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-12 11:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1673521664.git.bmauduit@beneth.fr>
2023-01-12 11:11 ` [PATCH 1/1] lib/oe/reproducible: Use git log without gpg signature Benoît Mauduit
2023-01-12 11:22 ` [poky] " Alexander Kanavin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).