* [PATCH] hw/input/virtio-input-hid.c: Don't undef CONFIG_CURSES
@ 2020-07-23 19:24 Peter Maydell
2020-07-24 4:27 ` Thomas Huth
2020-07-24 12:53 ` Michael S. Tsirkin
0 siblings, 2 replies; 4+ messages in thread
From: Peter Maydell @ 2020-07-23 19:24 UTC (permalink / raw)
To: qemu-devel; +Cc: Thomas Huth, Gerd Hoffmann, Michael S. Tsirkin
virtio-input-hid.c undefines CONFIG_CURSES before including
ui/console.h. However since commits e2f82e924d057935 and b0766612d16da18
that header does not have behaviour dependent on CONFIG_CURSES.
Remove the now-unneeded undef.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
NB: tested with 'make check' only.
hw/input/virtio-input-hid.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/input/virtio-input-hid.c b/hw/input/virtio-input-hid.c
index 09cf2609854..a7a244a95db 100644
--- a/hw/input/virtio-input-hid.c
+++ b/hw/input/virtio-input-hid.c
@@ -12,7 +12,6 @@
#include "hw/qdev-properties.h"
#include "hw/virtio/virtio-input.h"
-#undef CONFIG_CURSES
#include "ui/console.h"
#include "standard-headers/linux/input.h"
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/input/virtio-input-hid.c: Don't undef CONFIG_CURSES
2020-07-23 19:24 [PATCH] hw/input/virtio-input-hid.c: Don't undef CONFIG_CURSES Peter Maydell
@ 2020-07-24 4:27 ` Thomas Huth
2020-07-24 12:53 ` Michael S. Tsirkin
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2020-07-24 4:27 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: QEMU Trivial, Gerd Hoffmann, Michael S. Tsirkin
On 23/07/2020 21.24, Peter Maydell wrote:
> virtio-input-hid.c undefines CONFIG_CURSES before including
> ui/console.h. However since commits e2f82e924d057935 and b0766612d16da18
> that header does not have behaviour dependent on CONFIG_CURSES.
> Remove the now-unneeded undef.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> NB: tested with 'make check' only.
>
> hw/input/virtio-input-hid.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/input/virtio-input-hid.c b/hw/input/virtio-input-hid.c
> index 09cf2609854..a7a244a95db 100644
> --- a/hw/input/virtio-input-hid.c
> +++ b/hw/input/virtio-input-hid.c
> @@ -12,7 +12,6 @@
> #include "hw/qdev-properties.h"
> #include "hw/virtio/virtio-input.h"
>
> -#undef CONFIG_CURSES
> #include "ui/console.h"
>
> #include "standard-headers/linux/input.h"
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/input/virtio-input-hid.c: Don't undef CONFIG_CURSES
2020-07-23 19:24 [PATCH] hw/input/virtio-input-hid.c: Don't undef CONFIG_CURSES Peter Maydell
2020-07-24 4:27 ` Thomas Huth
@ 2020-07-24 12:53 ` Michael S. Tsirkin
1 sibling, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2020-07-24 12:53 UTC (permalink / raw)
To: Peter Maydell; +Cc: Thomas Huth, qemu-devel, Gerd Hoffmann
On Thu, Jul 23, 2020 at 08:24:57PM +0100, Peter Maydell wrote:
> virtio-input-hid.c undefines CONFIG_CURSES before including
> ui/console.h. However since commits e2f82e924d057935 and b0766612d16da18
> that header does not have behaviour dependent on CONFIG_CURSES.
> Remove the now-unneeded undef.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Gerd pls feel free to pick this up.
> ---
> NB: tested with 'make check' only.
>
> hw/input/virtio-input-hid.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/input/virtio-input-hid.c b/hw/input/virtio-input-hid.c
> index 09cf2609854..a7a244a95db 100644
> --- a/hw/input/virtio-input-hid.c
> +++ b/hw/input/virtio-input-hid.c
> @@ -12,7 +12,6 @@
> #include "hw/qdev-properties.h"
> #include "hw/virtio/virtio-input.h"
>
> -#undef CONFIG_CURSES
> #include "ui/console.h"
>
> #include "standard-headers/linux/input.h"
> --
> 2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] hw/input/virtio-input-hid.c: Don't undef CONFIG_CURSES
2020-10-12 15:33 [PATCH 00/10] target/arm: Various v8.1M minor features Peter Maydell
@ 2020-10-12 15:33 ` Peter Maydell
0 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2020-10-12 15:33 UTC (permalink / raw)
To: qemu-arm, qemu-devel; +Cc: Richard Henderson
virtio-input-hid.c undefines CONFIG_CURSES before including
ui/console.h. However since commits e2f82e924d057935 and b0766612d16da18
that header does not have behaviour dependent on CONFIG_CURSES.
Remove the now-unneeded undef.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
NB: tested with 'make check' only.
hw/input/virtio-input-hid.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/input/virtio-input-hid.c b/hw/input/virtio-input-hid.c
index 09cf2609854..a7a244a95db 100644
--- a/hw/input/virtio-input-hid.c
+++ b/hw/input/virtio-input-hid.c
@@ -12,7 +12,6 @@
#include "hw/qdev-properties.h"
#include "hw/virtio/virtio-input.h"
-#undef CONFIG_CURSES
#include "ui/console.h"
#include "standard-headers/linux/input.h"
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-12 15:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23 19:24 [PATCH] hw/input/virtio-input-hid.c: Don't undef CONFIG_CURSES Peter Maydell
2020-07-24 4:27 ` Thomas Huth
2020-07-24 12:53 ` Michael S. Tsirkin
2020-10-12 15:33 [PATCH 00/10] target/arm: Various v8.1M minor features Peter Maydell
2020-10-12 15:33 ` [PATCH] hw/input/virtio-input-hid.c: Don't undef CONFIG_CURSES Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).