From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Zhang Chen <chen.zhang@intel.com>, Jason Wang <jasowang@redhat.com>
Cc: Lukas Straub <lukasstraub2@web.de>,
qemu-dev <qemu-devel@nongnu.org>,
Zhang Chen <zhangckid@gmail.com>
Subject: Re: [PATCH 3/7] chardev/char.c: Use qemu_co_sleep_ns if in coroutine
Date: Wed, 20 May 2020 07:34:45 +0200 [thread overview]
Message-ID: <02f98f09-5e41-601f-4a40-9ce6236994ad@redhat.com> (raw)
In-Reply-To: <20200519200207.17773-4-chen.zhang@intel.com>
On 5/19/20 10:02 PM, Zhang Chen wrote:
> From: Lukas Straub <lukasstraub2@web.de>
>
> This will be needed in the next patch.
Can you reword to something clearer, maybe:
"To be able to convert compare_chr_send to a coroutine in the
next commit, use qemu_co_sleep_ns if in coroutine."
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Signed-off-by: Lukas Straub <lukasstraub2@web.de>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reviewed-by: Zhang Chen <chen.zhang@intel.com>
> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> ---
> chardev/char.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/chardev/char.c b/chardev/char.c
> index 0196e2887b..4c58ea1836 100644
> --- a/chardev/char.c
> +++ b/chardev/char.c
> @@ -38,6 +38,7 @@
> #include "qemu/module.h"
> #include "qemu/option.h"
> #include "qemu/id.h"
> +#include "qemu/coroutine.h"
>
> #include "chardev/char-mux.h"
>
> @@ -119,7 +120,11 @@ static int qemu_chr_write_buffer(Chardev *s,
> retry:
> res = cc->chr_write(s, buf + *offset, len - *offset);
> if (res < 0 && errno == EAGAIN && write_all) {
> - g_usleep(100);
> + if (qemu_in_coroutine()) {
> + qemu_co_sleep_ns(QEMU_CLOCK_REALTIME, 100000);
> + } else {
> + g_usleep(100);
> + }
> goto retry;
> }
>
>
next prev parent reply other threads:[~2020-05-20 5:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 20:02 [PATCH 0/7] Latest COLO tree queued patches Zhang Chen
2020-05-19 20:02 ` [PATCH 1/7] colo-compare: Fix memory leak in packet_enqueue() Zhang Chen
2020-05-20 5:52 ` Philippe Mathieu-Daudé
2020-05-19 20:02 ` [PATCH 2/7] net/colo-compare.c: Create event_bh with the right AioContext Zhang Chen
2020-05-19 20:02 ` [PATCH 3/7] chardev/char.c: Use qemu_co_sleep_ns if in coroutine Zhang Chen
2020-05-20 5:34 ` Philippe Mathieu-Daudé [this message]
2020-05-19 20:02 ` [PATCH 4/7] net/colo-compare.c: Fix deadlock in compare_chr_send Zhang Chen
2020-05-19 20:02 ` [PATCH 5/7] net/colo-compare.c: Only hexdump packets if tracing is enabled Zhang Chen
2020-05-19 20:02 ` [PATCH 6/7] net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active Zhang Chen
2020-05-19 20:02 ` [PATCH 7/7] net/colo-compare.c: Correct ordering in complete and finalize Zhang Chen
2020-05-20 2:47 ` [PATCH 0/7] Latest COLO tree queued patches Jason Wang
2020-05-20 4:41 ` no-reply
2020-05-20 9:07 ` Zhang, Chen
2020-05-20 12:22 ` Jason Wang
2020-05-21 1:30 ` Zhang, Chen
2020-05-21 19:54 ` Lukas Straub
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02f98f09-5e41-601f-4a40-9ce6236994ad@redhat.com \
--to=philmd@redhat.com \
--cc=chen.zhang@intel.com \
--cc=jasowang@redhat.com \
--cc=lukasstraub2@web.de \
--cc=qemu-devel@nongnu.org \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).