From: Lukas Straub <lukasstraub2@web.de>
To: "Zhang, Chen" <chen.zhang@intel.com>
Cc: Jason Wang <jasowang@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"zhangckid@gmail.com" <zhangckid@gmail.com>
Subject: Re: [PATCH 0/7] Latest COLO tree queued patches
Date: Thu, 21 May 2020 21:54:36 +0200 [thread overview]
Message-ID: <20200521215436.6e57e237@luklap> (raw)
In-Reply-To: <acdef015a5094522af56a40ddf2f5efa@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]
On Thu, 21 May 2020 01:30:48 +0000
"Zhang, Chen" <chen.zhang@intel.com> wrote:
> > -----Original Message-----
> > From: Jason Wang <jasowang@redhat.com>
> > Sent: Wednesday, May 20, 2020 8:23 PM
> > To: Zhang, Chen <chen.zhang@intel.com>; qemu-devel@nongnu.org; Lukas
> > Straub <lukasstraub2@web.de>
> > Cc: zhangckid@gmail.com
> > Subject: Re: [PATCH 0/7] Latest COLO tree queued patches
> >
> >
> > On 2020/5/20 下午5:07, Zhang, Chen wrote:
> > > It looks ASan doesn't fully support makecontext/swapcontext functions
> > and may produce false positives in some cases.
> > > And Lukas's patch maybe touch it.
> > > What do we need to do?
> >
> >
> > We need first identify if those are false positives. (Which I believe
> > yes, since I don't think this series have effect on the those qtests).
> >
> > And maybe we can consider to avoid using coroutine .
> >
>
> Hi Lukas, Can you double check your patches whether or not are false positives?
> If yes, maybe we can ignore this error.
Hi,
I ran the qtest's (without ASAN) on my laptop and they pass here, except for qos-test which runs into OOM. Also none of the qtest's touch colo-compare code. Anyway, I will send another version of my patches to address Philippe's comment and to avoid touching softmmu/vl.c.
Regards,
Lukas Straub
> Thanks
> Zhang Chen
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-05-21 20:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 20:02 [PATCH 0/7] Latest COLO tree queued patches Zhang Chen
2020-05-19 20:02 ` [PATCH 1/7] colo-compare: Fix memory leak in packet_enqueue() Zhang Chen
2020-05-20 5:52 ` Philippe Mathieu-Daudé
2020-05-19 20:02 ` [PATCH 2/7] net/colo-compare.c: Create event_bh with the right AioContext Zhang Chen
2020-05-19 20:02 ` [PATCH 3/7] chardev/char.c: Use qemu_co_sleep_ns if in coroutine Zhang Chen
2020-05-20 5:34 ` Philippe Mathieu-Daudé
2020-05-19 20:02 ` [PATCH 4/7] net/colo-compare.c: Fix deadlock in compare_chr_send Zhang Chen
2020-05-19 20:02 ` [PATCH 5/7] net/colo-compare.c: Only hexdump packets if tracing is enabled Zhang Chen
2020-05-19 20:02 ` [PATCH 6/7] net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active Zhang Chen
2020-05-19 20:02 ` [PATCH 7/7] net/colo-compare.c: Correct ordering in complete and finalize Zhang Chen
2020-05-20 2:47 ` [PATCH 0/7] Latest COLO tree queued patches Jason Wang
2020-05-20 4:41 ` no-reply
2020-05-20 9:07 ` Zhang, Chen
2020-05-20 12:22 ` Jason Wang
2020-05-21 1:30 ` Zhang, Chen
2020-05-21 19:54 ` Lukas Straub [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521215436.6e57e237@luklap \
--to=lukasstraub2@web.de \
--cc=chen.zhang@intel.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).